496ec1f012
Fix: use reference and array indexing to prevent suspicious pointer scaling
2023-01-06 19:34:35 +01:00
0d631a6fda
Change: Reword Finance window's Net Profit to Profit
2022-11-13 19:01:43 -07:00
adf94d7970
Change: Add a Total caption to each category of the finance window
2022-11-13 19:01:43 -07:00
bba1a16836
Change: Make Company GUI Bank Balance text white
2022-11-13 19:01:43 -07:00
920e588334
Change: Use standard dimensions instead of custom widths.
2022-11-12 18:28:39 +00:00
890b2666d3
Change: Use scaled WidgetDimensions.
2022-11-12 18:28:39 +00:00
46a1ab0937
Change: Use Rect when drawing infrastructure window.
2022-11-12 18:28:39 +00:00
6f95e04005
Change: Use Rect helpers for widget drawing.
...
This replaces repetitive and sometimes unwieldy use of constants.
2022-11-12 18:28:39 +00:00
632464a623
Codechange: Use Rect in DropDownListItem::Draw().
2022-11-12 18:28:39 +00:00
eb4ba1991b
Change: Use CenterBounds function in more places.
...
CenterBounds may have a 1 pixel difference so the result is not exactly
the same.
2022-11-12 18:28:39 +00:00
e604b76d18
Fix: List a max of four share owners instead of three
...
An AI company may have four different share owners, but the company information window is limited to display a max of three. This commit increases that limit.
2022-10-16 18:27:54 +02:00
d7ceb7efea
Change: Use widget string parameters for face window. ( #10046 )
...
The face window previously drew the buttons of face settings itself.
Instead we can provide parameters for each widget and let the widget
system draw the buttons.
2022-09-23 17:09:35 +01:00
a4e00c5cb5
Fix #9989 : Zero Net Profit is neither negative nor positive ( #9991 )
2022-09-21 12:38:03 +02:00
41de69c5b7
Feature: Improved Finance window
2022-04-25 21:51:51 +02:00
c73f578e8c
Codechange: replace magic numbers and C-style arrays with C++-style array for share owners
2022-03-09 18:05:12 +01:00
13528bfcd0
Codechange: Un-bitstuff all remaining commands.
2021-12-16 22:28:32 +01:00
58cff7b081
Codechange: Un-bitstuff the remaining on-map commands.
2021-12-16 22:28:32 +01:00
e08b3abe7f
Codechange: Un-bitstuff group and autoreplace commands.
2021-12-16 22:28:32 +01:00
0f64ee5ce1
Codechange: Template DoCommandP to automagically reflect the parameters of the command proc.
...
When finished, this will allow each command handler to take individually
different parameters, obliviating the need for bit-packing.
2021-12-16 22:28:32 +01:00
b0990fcff7
Codechange: Make TileIndex a "strong" typedef to give it a distinct type.
...
This is accomplished by changing it to a single member struct with the
appropriate operator overloads to make it all work with not too much
source modifications.
2021-12-16 22:28:32 +01:00
a38bbefe1b
Codechange: Untangle command code, flags and error string for DoCommand*.
2021-12-16 22:28:32 +01:00
549caca39c
Codechange: Move command arguments to the back of the networked command function calls.
2021-12-16 22:28:32 +01:00
994bf19aef
Fix f6d5c01: Delay deletion when closing windows
2021-05-29 21:08:25 +02:00
b791ffc6de
Fix: do not hide parameter by local variable with the same name
2021-05-27 18:30:56 +02:00
de81afdf4b
Cleanup: Replace FOR_ALL_SORTED_ROADTYPES macro with range iterator.
2021-04-28 23:54:31 +01:00
3b3d80c8ef
Cleanup: Replace FOR_ALL_SORTED_RAILTYPES macro with range iterator.
2021-04-28 23:54:31 +01:00
994ffaa382
Codechange: Use alignment feature in company finances window.
2021-04-22 16:42:04 +01:00
c361246bec
Codechange: Replace face window custom drawing with new widget features.
2021-04-22 16:42:04 +01:00
2a0365b3d9
Cleanup: Remove unnecessary parameter of GetScrolledRowFromWidget()
...
Line height defaults to the resize height of the relevant widget, which is
set in all cases. Therefore it is not necessary to specify this value every time.
Additionally fixes scrolled padding for the framerate window.
2021-04-21 23:12:10 +02:00
9b800a96ed
Codechange: Remove min/max functions in favour of STL variants ( #8502 )
2021-01-08 11:16:18 +01:00
62cdadb582
Change: move "give money" from client-list to company window
...
This is a much better location for this button, as you send
money from one company to another company, not from player
to player.
This is based on work done by JGRPP in:
f820543391https://www.tt-forums.net/viewtopic.php?p=1183311#p1183311
We did modify it to fix several bugs and clean up the code while
here anyway.
The callback was removed, as it meant a modified client could
prevent anyone from seeing money was transfered. The message
is now generated in the command itself, making that impossible.
2021-01-05 21:56:24 +01:00
d6e15d4943
Fix: make the "password" button the same size as the other buttons in Company window
...
Currently password-lock icon + button was the same size, but this
looks really weird. Now they are in sync, even with other fonts
and languages.
2021-01-05 21:56:24 +01:00
a3f0ee3b63
Codechange: fix alignment of Company GUI
...
Code acted as if WWT_TEXT starts a scope; it does not.
2021-01-05 21:56:24 +01:00
fc474b02fa
Fix: change all Company planes on paint, not only the first that needs changing
...
Otherwise it can take a few OnPaint() calls before all planes are
set correctly when switching companies.
2021-01-05 21:56:24 +01:00
860c270c73
Codechange: Replace assert_compile macro with static_assert
2020-12-27 10:55:42 +00:00
a10013dd00
Codechange: Spell 'Viewport' consistently
...
Some places in the codebase misspell 'Viewport' as 'ViewPort' or 'view_port'.
This patch makes everything consistent.
2020-07-27 17:31:29 +01:00
816fada2b1
Fix #8250 : [NRT] Company infrastructure window always omits last road/tramtype
2020-07-02 12:35:28 +02:00
c167648d75
Fix: Violation of strict weak ordering in group name sorters
...
This could be caused by a group being renamed, and the old
name being cached from a previous sort.
See: #7838
2020-06-18 12:38:43 +02:00
4ae829cb27
Codechange: Replace FOR_ALL_GROUPS with range-based for loops
2019-12-21 20:13:03 +01:00
1f6b3a37f9
Codechange: Replace FOR_ALL_ENGINES with range-based for loops
2019-12-21 20:13:03 +01:00
3a14cea068
Codechange: Replace FOR_ALL_COMPANIES with range-based for loops
2019-12-21 20:13:03 +01:00
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
c02ef3e456
Feature: Add NotRoadTypes (NRT)
2019-05-01 21:36:27 +02:00
08284e005d
Fix: Automatic line breaking of the warning
2019-04-24 17:40:11 +02:00
2db88953e7
Codechange: use std::sort() in GUIList
2019-04-13 12:49:18 +01:00
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
c7b9987d08
Codechange: Switch DropDownList to directly use std::vector, thus making AutoDeleteSmallVector obsolete.
...
DropDownListItem are strongly managed using std::unique_ptr to ensure leak-free handling. Appropriate use
of move-semantics make intent a lot clearer than parameter comments and allows the compiler to generate
copy-free code for most situations.
2019-04-09 22:45:15 +02:00
66dd7c3879
Fix: MSVC warnings ( #7423 )
2019-03-28 00:09:33 +01:00
c01a2e2a81
Codechange: Removed SmallVector completely
2019-03-26 20:15:57 +00:00
ab711e6942
Codechange: Replaced SmallVector::[Begin|End]() with std alternatives
2019-03-26 20:15:57 +00:00
a0f36a50e6
Codechange: Replaced SmallVector::Append() with std::vector::[push|emplace]_back()
2019-03-26 20:15:57 +00:00
a690936ed7
Codechange: Replace SmallVector::Length() with std::vector::size()
2019-03-26 20:15:57 +00:00
9cba6f7193
Codechange: Replaced SmallVector::Compact() with std::vector::shrink_to_fit()
2019-03-26 20:15:57 +00:00
bfd79e59dc
Codechange: Replace SmallVector::Clear() with std::vector::clear()
2019-03-26 20:15:57 +00:00
317f69c152
Codechange: Use override specifier in Window-derived classes.
2019-03-24 16:10:04 +01:00
aafce47596
Codechange: Use override specifier for DropDownListItem classes.
2019-03-24 16:10:04 +01:00
e3c639a09f
Remove: ENABLE_NETWORK switch
...
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
2019-03-20 19:24:55 +01:00
fb35cb5ed2
Remove: Unnecessary virtual destructors on drop down list items.
2019-03-10 09:20:11 +00:00
811bf22620
Codechange: Use Colours type instead of byte.
2019-03-10 09:20:11 +00:00
93a6fd42d1
Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer.
2019-03-03 13:13:35 +01:00
7ac17f5ae4
Fix #7281 : Unable to select last group in open livery window on group creation.
2019-02-26 11:20:23 +01:00
c9d801a98d
Fix: Make livery window resize properly if GUI scale changes whilst open.
2019-02-02 16:57:47 +00:00
9e9d485713
Fix 23960d0f2c: Scrollbar was broken for non-group liveries.
...
Simplify how list position is determined by using existing functions.
Also rename livery_height -> rows and SetLiveryHeight() -> SetRows(), as height implies pixels.
2019-02-01 13:25:42 +00:00
23960d0f2c
Feature: Group liveries, and livery window usability enhancements. ( #7108 )
...
* Change: Replace checkbox in livery selection window with Default option in drop down selection.
This reduces clutter in the UI and allows for primary/secondary colours to independently follow the default scheme if desired.
* Feature: Add vehicle group liveries.
2019-01-31 14:57:44 +01:00
6e5b90f4f7
Change: For consistency, add company name to colour scheme window.
2019-01-27 12:34:49 +01:00
256b94a03d
Fix: Ignore company colour selection when showing different company's colour scheme.
2019-01-27 12:34:49 +01:00
fa95af2da8
Codechange: Fix typo in variable name: pices -> pieces ( #7033 )
2019-01-11 16:08:02 +01:00
f5b1115039
Doc: Lots and lots of doxymentation fixes
2018-10-31 12:35:54 +01:00
b4b98e5165
(svn r27893) -Codechange: Use fallthrough attribute. (LordAro)
2017-08-13 18:38:42 +00:00
a682962719
(svn r27889) -Change: Do not cancel headquarter construction and engine-preview-query when shift-clicking (adf88)
2017-07-11 19:37:10 +00:00
2d636266f5
(svn r27427) -Fix: Use the NewGRF railtype sorting order in the infrastructure window.
2015-10-30 17:24:30 +00:00
a8080b6256
(svn r27134) -Codechange: Simplify GUI scaling by adding UnScaleGUI() and ScaleGUITrad().
2015-02-01 20:54:24 +00:00
58458c6652
(svn r26935) -Codechange: Fit company colour selection drop down list to UI scale.
2014-09-28 19:19:47 +00:00
ea33b69798
(svn r26856) -Codechange: Ensure company face widgets can fit company face.
2014-09-20 09:18:22 +00:00
2a16c33461
(svn r26527) -Codechange: Rename STR_MAPGEN_RANDOM to STR_FACE_RANDOM
2014-04-27 15:30:53 +00:00
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
3dd1a6ad2d
(svn r26416) -Fix [FS#5947]: Shares button state was not appropriately updated when switching setting or company (frosch)
2014-03-18 20:53:34 +00:00
83eeba28b7
(svn r26086) -Codechange: use AutoDeleteSmallVector instead std::list for dropdowns
2013-11-24 14:46:26 +00:00
98fdd20f84
(svn r25531) -Codechange: Use separate function to set data of WWT_MATRIX widgets.
2013-06-30 14:32:31 +00:00
4356510408
(svn r25517) -Fix-ish (r25515) / Feature-ish [FS#5623]: properly align the statistics as well when the infra sharing is turned on
2013-06-29 13:19:19 +00:00
ba1e42d057
(svn r25516) -Codechange: reduce code duplication in infrastructure statistics window
2013-06-29 13:11:52 +00:00
c27ce651c9
(svn r25515) -Feature [FS#5595]: right align the infrastructure statistics
2013-06-29 12:41:43 +00:00
d724088a1c
(svn r25442) -Codechange: move height and ascender information into the FontCache instances
2013-06-23 15:32:09 +00:00
8157a8afd8
(svn r25290) -Add: Assign string names to notable windows.
2013-05-26 19:25:01 +00:00
56e4a8c4d6
(svn r25287) -Codechange: Keep a reference to the WindowDesc in the Window after construction.
2013-05-26 19:23:42 +00:00
99a08e1e8c
(svn r24968) -Fix [FS#5379]: company window was not updated when shared were enabled/disabled
2013-02-04 20:29:38 +00:00
b533523258
(svn r24801) -Codechange: Add functions to set integral DParams to suitable values for size computations.
2012-12-08 17:18:51 +00:00
03736af2ae
(svn r24700) -Cleanup: Remove WDF_UNCLICK_BUTTONS and make it the default.
2012-11-11 16:10:43 +00:00
f883454db2
(svn r24655) -Codechange(r18310): Difference between female and male is no longer needed for tie and earrings (found by botankras)
2012-10-31 20:54:19 +00:00
32ab630bda
(svn r24131) -Add [FS#1952]: Ctrl-Clicking to change colour of all colour schemes at once. (Roest)
2012-04-17 19:43:38 +00:00
0542e26460
(svn r23931) -Change: Scale infrastructure cost of rail tracks by the total number of all tracks and not independently for each rail type.
2012-02-11 22:43:39 +00:00
6d6be50ae0
(svn r23740) -Codechange: remove some 300 unneeded includes from the .cpp files
2012-01-03 21:32:51 +00:00
4af8c2d5e1
(svn r23704) -Doc: Doxygen comment fixes and additions.
2012-01-01 17:22:32 +00:00
e9f584ac21
(svn r23531) -Codechange: document and rename widgets to be consistent and understandable
2011-12-16 16:27:45 +00:00
2aa774e831
(svn r23528) -Codechange: move widget enums to widgets/NNN_type.h
2011-12-15 22:22:55 +00:00
58423b26d1
(svn r23474) -Codechange: move the declaration error related functions to error.h
2011-12-10 13:54:10 +00:00
6711026011
(svn r23428) -Fix (r23415): Initial size of the infrastructure details windows was sometimes too small.
2011-12-04 13:27:24 +00:00
1f9f73d2b6
(svn r23424) -Change: Make the company GUI somewhat smaller if there are no shareholders.
2011-12-04 11:59:08 +00:00
51da427dae
(svn r23420) -Change: Put the manager name directly under the picture instead of vertically centering it.
2011-12-04 10:47:57 +00:00
d3b7b89493
(svn r23415) -Feature: Infrastructure maintenance costs.
2011-12-03 23:40:46 +00:00
Rubidium