Hielke Morsink
f5ac98c1e2
Early out when context creation fails
2019-06-09 11:03:00 +02:00
Duncan
993709c087
Merge pull request #9321 from aw20368/fix/8723-use-rotate_map_coordinates
...
Fix #8723 Use rotate_map_coordinates to rotate coordinate
2019-06-08 07:52:52 +01:00
aw20368
e0cf476398
Fix #8723 Use rotate_map_coordinates to rotate coordinate
...
Added Rotate to CoordsXY, TileCoordsXY and used them to replace redundant rotation code.
2019-06-06 08:21:40 -04:00
Matt
f98d027a14
Fix #9377 : accumulate a list of windows to close before actual closing
2019-06-06 12:21:46 +02:00
aw20368
834d1e828a
Fix #7829 Rotated information kiosk can cause 'unreachable' messages ( #9337 )
...
Some entrance directions were lost upon rotation. Corrected rotation of entrance directions.
2019-06-05 09:33:39 +02:00
aw20368
df263eb1f6
Fix #5896 Fences not always removed when building a tracked ride through ( #9341 )
...
Fence removal did not account for track direction. Added the rotation for the track/fence intersection test.
2019-06-04 23:27:36 +02:00
aw20368
3823befa10
Fix #7323 Tunnel entrances not rendering in 'highlight path issues' ( #9339 )
...
Hiding path scenery caused function that draws tunnel to prematurely return. Changed to only skip drawing scenery.
2019-06-04 20:34:39 +02:00
Aaron van Geffen
f1ac847fce
Merge pull request #9222 from IntelOrca/implement/485-ghost-train-simulation
...
Implement #485 : ghost train simulation
2019-06-04 20:24:16 +02:00
Duncan
06c666c298
Merge pull request #9358 from ZehMatt/undo-fuckup1
...
Remove useless log_info
2019-06-04 18:45:34 +01:00
Duncan
f44d29f861
Merge pull request #9368 from ZehMatt/fix-9365
...
Fix #9365 : Crash when bringing window to front
2019-06-04 18:45:22 +01:00
Matt
d6975a8f23
Fix #9365 : Crash when bringing window to front
2019-06-04 07:02:55 +02:00
Hielke Morsink
4dea507e50
Fix #9360 : sticky windows can be closed
2019-06-03 22:49:45 +02:00
Matt
af65811f50
Remove useless log_info
2019-06-03 18:59:23 +02:00
ζeh Matt
cf9e5e14a6
Merge pull request #9330 from ZehMatt/window-refactor
...
Refactor window storage to use std::list instead of std::vector
2019-06-01 21:22:02 +02:00
aw20368
3ee6be0dbf
Fix #9288 : Replace repeated 3d to 2d functions ( #9301 )
...
Replaced duplicate 3d to 2d code with translate_3d_to_2d_with_z(...).
2019-05-30 22:41:53 +02:00
ζeh Matt
bc14f427a5
Fix #9322 : Peep crashing the game trying to find a ride to look at
2019-05-30 20:49:54 +02:00
James Warwood
67f1359936
Fix: Unable to change colours of scrolling wall banner sign via sign dialog ( #9303 )
...
1. Check in SignSetStlyeAction query was accidentally inverting value of
wallFound boolean
2. Code in action execution was not looping through the tile elements to find
the correct wall piece like the query did (which meant just fixing 1. would
cause a segfault)
Moved code to find relevant wall tile element into new helper function
banner_get_scrolling_wall_tile_element() in Banner; use in both query and action
to avoid any duplication of search logic.
2019-05-30 10:33:13 +02:00
Matt
951f5009ef
Refactor window storage to use std::list instead of std::vector
2019-05-29 19:32:18 +02:00
Ted John
efac635cfa
Do not update ride measurements when simulating
2019-05-28 22:37:54 +01:00
Ted John
8d5e083998
Remove duplicate divisions
2019-05-28 22:31:46 +01:00
Ted John
ca32357dad
Use bool for isApplying
2019-05-28 22:31:46 +01:00
Ted John
63b1649666
Do not clear construction / peeps for ghost entrance / exits
2019-05-28 16:53:31 +01:00
Ted John
1dd696d453
Do not clear construction / peeps when querying ride entrance / exit
2019-05-28 16:50:38 +01:00
Aaron van Geffen
d1f48fab53
Add RCT1 traffic light sprites for ride simulate status.
2019-05-28 16:50:38 +01:00
Aaron van Geffen
bab7711c5b
Add new simulate icon.
2019-05-28 16:50:38 +01:00
Ted John
62ff1e7534
Prevent breakdown during simulation
2019-05-28 16:50:38 +01:00
Ted John
5fa0c18455
Do not provide test results for simulate
2019-05-28 16:50:08 +01:00
Ted John
94caa46654
Allow modification of ride entrance during simulation
2019-05-28 16:50:08 +01:00
Ted John
5c8aa743f6
Implement ghost drawing for special vehicles
2019-05-28 16:50:08 +01:00
Ted John
5f1f428bce
Add and use Ride::SupportsStatus
2019-05-28 16:50:08 +01:00
Ted John
fec6d660c6
Remove obsolete configs:
...
- no crashes
- test unfinished track
2019-05-28 16:50:08 +01:00
Ted John
c4e18e570e
Add and implement simulation mode for rides
2019-05-28 16:50:08 +01:00
nexgenration
46889b5381
Implement #9231 : Add sprite_index to Guest Debug Tab
2019-05-27 22:39:03 +02:00
James Warwood
1cf4f17ee6
Fix: Unable to use second skyscraper terrain edge style
...
Code to check if selected edge style is valid was passing the wrong object type
(surface instead of edge) to GetLoadedObject, causing that method to warn that
the selected edge style index was out-of-range.
2019-05-27 22:37:31 +02:00
Sijmen Schoon
f26a1aee57
Fix compile error with DISABLE_HTTP ( #9309 )
...
There are two variables, MASTER_SERVER_REGISTER_TIME and
MASTER_SERVER_HEARTBEAT_TIME, which are unused when DISABLE_HTTP is set.
This commit fixes that.
2019-05-26 16:06:56 +02:00
aw20368
8c20b635bd
Fix #9270 : Refactor money effect
...
Changed static functions to rct_money_effect member functions. GetStringId now returns std::pair.
2019-05-21 21:22:47 +02:00
ζeh Matt
ee79c11389
Fix desync when host changes map
2019-05-19 17:44:43 +02:00
Michael Steenbeek
1de25be4fb
Merge pull request #9274 from ZehMatt/fix-mp-pause-toggle
...
Fix clients being behind one tick
2019-05-19 15:09:25 +02:00
Michael Steenbeek
1b11612e3c
Merge pull request #9259 from duncanspumpkin/scenario_set
...
Implement ScenarioSetSetting game action
2019-05-19 15:09:12 +02:00
Matt
8389e5119b
Bump up network version
2019-05-18 19:57:51 +02:00
Matt
83511c5c7f
Fix clients being behind one tick at all times
2019-05-18 19:56:03 +02:00
James Warwood
d7074e65a2
Fix: Staff patrol areas getting clobbered when hiring new staff ( #9271 )
...
Fixed incorrect indexing when resetting staff patrol areas during hiring
process.
2019-05-18 11:43:06 +02:00
nexgenration
6b232f7e53
Fix#9197: Peep insert new thought ( #9230 )
...
Improve the readability of the codebase by moving functions into the relevant structures.
- Change name of peep_insert_new_thought to InsertNewThought.
- Update InsertNewThought definition to Guest::InsertNewThought.
2019-05-18 09:47:25 +01:00
ζeh Matt
f7bd6d516a
Fix #9267 : Only check if a file is a directory before opening it ( #9269 )
2019-05-16 08:05:09 +01:00
ζeh Matt
1978372679
Merge pull request #9236 from ZehMatt/fix-ga-logging
...
Improve game action logging
2019-05-15 22:44:47 +02:00
duncanspumpkin
00c4b393a3
Take care of default case
2019-05-15 19:47:18 +01:00
ζeh Matt
1a01a49002
Fix #9124 : Disconnected clients can crash the server
2019-05-15 19:55:16 +02:00
Greg Hennis
1fcedae3bc
Fix #9258 : Rename SPRITE_LIST_NULL to ..._FREE ( #9260 )
2019-05-15 19:07:01 +02:00
duncanspumpkin
3ac596faf1
Implement ScenarioSetSetting game action
...
Further work moving game commands into the game action framework to improve design.
2019-05-14 21:46:27 +01:00
Gymnasiast
cb6a563e2d
Bump network version [ci skip]
2019-05-14 21:59:16 +02:00
duncanspumpkin
0b7d7027e1
Fix formatting
2019-05-14 21:58:55 +02:00
duncanspumpkin
e72195d16e
Make suggested changes
2019-05-14 21:58:55 +02:00
duncanspumpkin
1eb7f4d8c6
Implement Modify Group and Kick Player Actions.
...
Further work on the Game Actions porting
2019-05-14 21:58:55 +02:00
Duncan
7793001f5d
Implement BalloonPressAction
...
Furthering reducing the number of game commands and moving them to the Game Action framework
2019-05-14 21:54:54 +02:00
joshtucker132
4dc77bf121
Feature #8791 : Improved tile element flag manipulation in Tile Inspector
2019-05-14 21:38:31 +02:00
Gymnasiast
5e39640837
Also remove game_command_set_park_entrance_fee from new_game_command_table
2019-05-14 18:39:14 +02:00
Gymnasiast
4e23c42d38
Remove stub functions from new_game_command_table[]
2019-05-13 22:51:41 +02:00
Gymnasiast
8d9645a382
Remove comment
2019-05-13 22:22:14 +02:00
Gymnasiast
170307cd0f
Remove redundant semicolons after for loops
2019-05-13 22:16:30 +02:00
Gymnasiast
2ea1fcc69d
Remove unused declarations and functions
2019-05-13 22:16:14 +02:00
ζeh Matt
0ff19f071f
Fix #9240 : crash when passing directory instead of save file
2019-05-13 21:34:58 +02:00
duncanspumpkin
4de6071fb4
Increment network version
2019-05-12 19:03:03 +01:00
duncanspumpkin
b9a70d02a3
Make suggested changes
...
Implement suggestions
Fix formatting
2019-05-12 17:31:48 +01:00
duncanspumpkin
e9e445837f
Add landset/buyrights action
2019-05-12 17:29:19 +01:00
Michael Steenbeek
e5eea9d1fa
Merge pull request #9235 from ZehMatt/fix-util-rand
...
Improve util_rand
2019-05-12 13:50:19 +02:00
Ted John
15cb3e1889
Remove unnecessary new line characters from log calls ( #9237 )
2019-05-12 13:48:56 +02:00
Ted John
616fdfd96e
Merge pull request #9212 from IntelOrca/fix/2339-broadcast-lan
...
Implement searching of local servers by broadcasting UDP packets.
2019-05-12 12:07:56 +01:00
Matt
eb3018b6a9
Fix warnings
2019-05-12 11:32:41 +02:00
Matt
c6ea47c631
Make util_rand thread safe
2019-05-12 11:32:33 +02:00
Matt
5198df5c25
Improve generation of random advertisment key
2019-05-12 11:27:48 +02:00
Duncan
5da95e963d
Fix GameAction use during pause ( #9242 )
...
* Use correct flag to allow action while paused.
Mistake made during implementing on GameActions
* Increment network version
2019-05-12 09:54:21 +01:00
Ted John
dd20ebad49
Make more methods const
2019-05-12 00:57:56 +01:00
Ted John
5e94f6385d
Initialise hostname
2019-05-12 00:51:33 +01:00
Ted John
73b8310e8e
Refactor creation of UDP socket
2019-05-12 00:51:33 +01:00
Ted John
f8e3abcf4e
Remove by-reference string_view
2019-05-12 00:51:33 +01:00
Ted John
f0d1e9c320
Apply some of the code review comments
2019-05-12 00:51:33 +01:00
Ted John
3334d40da4
Explicitly use std::launch::async
2019-05-12 00:51:33 +01:00
Gymnasiast
6e6fe3c3c1
Replace optional.value() with *optional (fix Xcode compilation)
...
Xcode cannot handle the optional.value() notation, but *optional
should mean the same.
Also see https://en.cppreference.com/w/cpp/utility/optional/operator *
2019-05-12 00:51:33 +01:00
Gymnasiast
9b1321067b
Use opt:: namespace
2019-05-12 00:51:33 +01:00
Ted John
52afcb795f
Fix windows build
2019-05-12 00:51:33 +01:00
Ted John
47f48721e8
Fix clang build
2019-05-12 00:51:33 +01:00
Ted John
4b0f2bbceb
Fix disable network / disable http builds
2019-05-12 00:51:33 +01:00
Ted John
20f52a8cbe
Refactor TcpSocket and UdpSocket
2019-05-12 00:51:33 +01:00
Ted John
6a4791e39e
Only reply to broadcasts with correct message
2019-05-12 00:51:33 +01:00
Ted John
59ddd7e1ea
Get and broadcast to all broadcast address
2019-05-12 00:51:33 +01:00
Ted John
51117432f0
Improve status messages and prevent duplicates
2019-05-12 00:51:33 +01:00
Ted John
04c04d197e
Refactor broadcasting code and logging
2019-05-12 00:51:33 +01:00
Ted John
4f0a733496
Sort by LAN servers
2019-05-12 00:51:33 +01:00
Ted John
3a400a2471
Refactor server list
2019-05-12 00:51:33 +01:00
Ted John
4437113805
Fix server list LAN address and port
2019-05-12 00:51:33 +01:00
Ted John
7a20874366
Fix Windows build
2019-05-12 00:51:33 +01:00
Ted John
123a8eacad
Get the server list showing LAN servers
2019-05-12 00:51:33 +01:00
Ted John
694cb7eb3f
Implement UDP socket and broadcasting
2019-05-12 00:50:13 +01:00
Ted John
5992b9f76e
Add UDP socket class
2019-05-12 00:49:37 +01:00
Matt
2ea15ac146
Write server log as binary
2019-05-11 23:42:23 +02:00
Matt
c1d6337e3b
Increase buffer size to avoid truncating text
2019-05-11 23:40:59 +02:00
Matt
6aa0e74d3e
Fix util_rand only returning 15 bit values.
2019-05-11 22:37:19 +02:00
Matt
9561567b6c
Bump up network version
2019-05-11 21:39:01 +02:00
Matt
7c7909fb45
Fix #2294 : Clients crashing the server with invalid object selection
2019-05-11 21:39:01 +02:00
ζeh Matt
c8f822ea70
Gamestate snapshots ( #8819 )
...
* Add initial interface.
* Implement move operator in MemoryStream
* Add pod array serialisation traits.
* Add push_back with move semantics to CircularBuffer
* Initial implementation of GameStateSnapshots
* Add GameStateSnapshots to Context.
* Add mp_desync console command.
* Compare sprite data and fill change list.
* Minor changes.
* Proof of concept.
* Calculate offset instead of using offsetof
* Implement game state difference detection
* Update mp_desync console command.
* Fix identification of sprite remove/add.
* Fix crash when only one peep in park when using mp_desync
* Output state differences into user directory desync folder.
* Add desync debugging as an option.
* Add information to network status when a desync report was created.
* Cast to proper type for %llu.
* Update xcode project
* Add more information to the diffed data.
* Remove client-only relevant fields.
* Cleanup.
* Add better name output for misc sprites
* Add srand0 and tick information to the output
* Bump up network version
* Cleanup
* Set desync_debugging to false as default
* Apply suggestions
2019-05-11 21:31:34 +02:00
ζeh Matt
1f6c7c9942
Fix false positive desync when changing map during network play
2019-05-11 18:27:09 +02:00
Ted John
7074d6f3ae
Apply review suggestions
2019-05-11 13:57:18 +01:00
Tom Lankhorst
ed353faccf
Implement replace_if condition lambda
...
Fix include typo and CS
2019-05-11 13:54:16 +01:00
Tom Lankhorst
744f2225ed
Write platform tests
2019-05-11 13:54:16 +01:00
Tom Lankhorst
bbd69496b4
Sanitize screenshot path
2019-05-11 13:54:16 +01:00
nexgenration
ebefe5721b
Fix #9198 : Move vehicle invalidate to member function
...
To further improve the readability of the codebase the vehicle_invalidate function is now a member function of rct_vehicle.
2019-05-11 13:20:34 +01:00
Filip Gawin
6833da77e3
Simplify boolean expresions
2019-05-10 22:00:38 +02:00
Michał Janiszewski
7b71fe8acd
Fix error value checked from ride_get_smallest_station_length ( #8719 )
...
ride_get_smallest_station_length returns the int32_t::max instead of -1
on error.
2019-05-08 22:34:41 +01:00
Michael Steenbeek
da6794ad9e
Refactor second argument to move_sprite_to_list()
2019-05-08 22:11:51 +02:00
Gymnasiast
7f5c9622c0
Fix guests eating popcorn being drawn eating pizza
2019-05-08 20:57:20 +02:00
Gymnasiast
17ddd451db
Fix tests, fix formatting
2019-05-07 20:04:07 +02:00
Gymnasiast
916b8c2705
Use more constants
2019-05-07 19:46:58 +02:00
Gymnasiast
212f425ff0
Rename variables, change signature
2019-05-07 19:34:50 +02:00
NexGenration
846011e21b
another message here
2019-05-07 19:34:50 +02:00
NexGenration
e6c88a05db
Make peep generate a static member function
2019-05-07 19:34:50 +02:00
Ted John
0d0479f9b1
Merge pull request #8558 from richard-fine/feature/peep-inspector
...
Peep debug tab
2019-05-06 20:29:29 +01:00
Gymnasiast
2368fea91e
Bump network version
2019-05-06 19:15:32 +02:00
Ted John
a22f0a53fb
Use localised strings for guest debug tab
2019-05-04 21:48:02 +00:00
Ted John
1d296242b4
Improve text colour
2019-05-04 14:09:15 +00:00
Richard Fine
c4a449f47d
Add new debugging tab to the Guest window
...
Add a new tab to the Guest window which we can use to display debug information and tools for guests. At the moment it's blank and always visible; next step is to make it only show up when debugging tools are enabled.
2019-05-04 14:08:37 +00:00
ζeh Matt
cd8c67ddac
Implement SetCheatAction. ( #8990 )
...
* Implement SetCheatAction.
* Bump up network version
2019-05-04 15:28:38 +02:00
Ted John
e84631c273
Fix #9204 : Making screenshots from command-line is broken ( #9206 )
2019-05-04 13:22:01 +00:00
Hielke Morsink
5e9e7bcbe5
Fix: artifacts when changing ride type as client or using the in-game console ( #9202 )
2019-05-04 10:31:10 +00:00
Aaron van Geffen
0da35a599d
Merge pull request #9193 from Gymnasiast/optional-header
...
Add `optional` header
2019-05-03 10:45:50 +02:00
Aaron van Geffen
f1b9c71524
Merge pull request #8687 from Xkeeper0/f/multiplayer-plus
...
Multiplayer dropdown additions
2019-05-02 22:53:50 +02:00
Tom Lankhorst
63a38412aa
Add `optional` header
2019-05-02 22:53:19 +02:00
Duncan
a6c2aed26d
Merge pull request #9059 from duncanspumpkin/banner_ga
...
Implement Banner Place/Remove Actions
2019-05-02 21:32:51 +01:00
Florian Will
8c109307cf
Fix #8507 : Incorrect change in vehicle rolling direction
...
In OpenRCT2, when vehicles roll backward on a long, flat track piece,
they would eventually change their direction of movement and move
forward instead, after their velocity reached -4095. The acceleration
due to rolling resistance and drag changes to 0 at that point, which
caused the "implicit boost" up to a velocity of ~+32k (close to 2km/h)
to trigger.
The behavior is different in vanilla RCT2, where vehicles just keep on
very slowly rolling backwards.
This commit disables the "implicit forward boost" for vehicles rolling
backward to mimic vanilla RCT2 behavior.
2019-05-02 22:22:59 +02:00
Ted John
4746051d1b
Merge pull request #8814 from tomlankhorst/link-threads
...
Always link threads, fix linking cURL
2019-05-02 19:40:04 +00:00
Duncan
48bf5e10f3
Increment network version
2019-05-02 20:20:20 +01:00
duncanspumpkin
f0df14bb0f
Use BannerIndex type
2019-05-02 17:50:04 +01:00
duncanspumpkin
7f42824642
Update game.h
2019-05-02 17:47:01 +01:00
duncanspumpkin
d14637e1ca
Fix narrowing and formatting
2019-05-02 17:47:01 +01:00
duncanspumpkin
f6b610c325
Implement Banner Place/Remove Actions
2019-05-02 17:47:01 +01:00
Aaron van Geffen
57040c392c
Change multiplayer toolbar image to framed globe, with pressed state.
2019-05-02 12:32:45 +02:00
Ted John
39123f68eb
Fix #5889 : Giant screenshot does not work while using OpenGL renderer
2019-05-02 00:07:43 +00:00
Ted John
f842d8a693
Fix #5103 : OpenGL: ride track preview not rendered
2019-05-02 00:07:43 +00:00
Xkeeper
7e6bed39d4
Fix z->s and DISABLE_NETWORK support
2019-05-02 00:30:30 +02:00
Xkeeper
c075eec224
Update sync icons, new multiplayer toolbar button
...
The multiplayer toolbar button is the same globe used for the
multiplayer option on the title screen, since it seems like
a nicer (and better?) looking option than the two riders.
Also conflicts less with the new sync icons.
2019-05-02 00:30:30 +02:00
Xkeeper
8c4de40239
Add graphics for desync notice
2019-05-02 00:29:25 +02:00
Xkeeper
bc8ecd8e67
Add "Reconnect" option under the multiplayer button
2019-05-02 00:26:37 +02:00
Xkeeper
d614fb4035
add network indicators for desync/player count
2019-05-02 00:22:03 +02:00
Aaron van Geffen
6098c1c3cc
Merge pull request #8659 from Xkeeper0/f/better-sign-tooltips
...
Better tooltips for banners and signs
2019-05-02 00:21:26 +02:00
Aaron van Geffen
df42cfe1e1
Change map toolbar icon with current rotation ( #9154 )
2019-05-02 00:07:20 +02:00
Xkeeper
51593c540a
Fix ride entrance hut banner issue
...
This fixes the problem where the ride entrance hut
banner would show a nonsense number after auto-named
rides based on the amount the text had scrolled.
2019-05-01 23:59:09 +02:00
Xkeeper
100ee139f5
Update code style with clang-format
2019-05-01 23:59:09 +02:00
Xkeeper
877ce58f0b
Update sign tooltip to use STR_NO_ENTRY
...
Changes the number of the sign tooltip string
and removes the now-duplicate "no entry" string
2019-05-01 23:58:38 +02:00
Xkeeper
c6a4316bd4
Update banner formatting code/strings
...
Changes some things to use STR_BANNER_TEXT_FORMAT and removes
instances of " - - " attached to other strings in the
localization files.
This can be used in the future to show the messages on
a sign or banner via a tooltip without having to
duplicate those messages without " - - ".
2019-05-01 23:57:07 +02:00
Xkeeper
a1454be336
Add new localizable strings for sign tooltips
...
re: OpenRCT2/OpenRCT2#8593
These strings use high IDs right now and are probably
not entirely suited for direct inclusion. There is also
some duplication in that "No entry" had to be unique,
as the actual no entry string is "No entry - -".
2019-05-01 23:57:07 +02:00
ζeh Matt
181a722c3b
Fix game action errors not showing if no round trip was done ( #9175 )
2019-05-01 22:53:10 +02:00
Duncan
1e1d263dae
PlayerSetGroupAction ( #9072 )
...
* First pass at action.
* Version 2. Do all the work in Network.cpp
* Mark game command as complete
* Make requested changes
* Increment of network version
2019-05-01 16:54:12 +01:00
ζeh Matt
c5b66c0294
Fix #9152 : Spectators can modify ride colours
2019-04-29 20:08:09 +02:00
Michael Steenbeek
c8df801e66
Create ShopItemDescriptor
2019-04-26 20:25:11 +02:00
Michael Steenbeek
57201c12db
Merge pull request #9128 from Broxzier/feature/6116-tile-inspector-colour-scheme
...
Expose colour scheme in the tile inspector (#6116 )
2019-04-24 19:42:12 +02:00
Michael Steenbeek
b2535ba35a
Merge pull request #9117 from Gymnasiast/fix/7729
...
Fix #7729 : Money Input Prompt breaks on certain values
2019-04-24 19:41:24 +02:00
boucks
b052c4ac61
Fix #9054 : remove gSceneryTileElement by returning it within GameActi… ( #9127 )
...
* Fix #9054 : remove gSceneryTileElement by returning it within GameActionResult
* fixing Clang-format issues
* fixing clang-format
lets try this again...
* fixing clang-format
alright should be good this time
* fixing clang-format issues
using automatic clang-formatting
* initializing tileElement
2019-04-24 09:42:00 +01:00
Duncan
3f4acd7e69
Merge pull request #9120 from Gymnasiast/fix/8079
...
Fix #8079 : Crash when unloading buggy custom rides
2019-04-23 18:28:34 +01:00
Nicole
d38fb6a7a2
Fix #8800 : ensure tile_element_height is used correctly ( #9087 )
...
* Changed calls to tile_element_height to tile_element_water_height
* Changes to calls to tile_element_height
* Removed tile element_height, map_get_highest_land_height, and map_get lowest_land_height
3 functions removed due to relocation.
* Added function tile_element_height back to map.cpp
Added tile_element height back to map.cpp. Was unnecessarily deleted.
* Update Map.h
* water_height changes
* Update Scenario.cpp
* Update Scenario.cpp
* Fix 8800: applied clang format
* Removed unnecessary ANDs
2019-04-23 18:26:48 +01:00
Gymnasiast
6d3eca31fd
Add log_verbose for vehicle entries with broken peep loading positions
2019-04-22 23:27:25 +02:00
Hielke Morsink
ac7bc97736
Expose colour scheme in the tile inspector ( #6116 )
2019-04-22 15:49:09 +02:00
Trevor Harkness
700ebe646f
Add new class in SmallSceneryPlaceAction def
...
Change to definition to refer to created SmallSceneryPlaceAction subclass instead of GameActionResult
2019-04-22 02:33:46 -04:00
duncanspumpkin
cc2da47271
Fix parameters
2019-04-21 20:06:55 +01:00
duncanspumpkin
228628b702
Undo 2nd mistake
2019-04-21 19:59:37 +01:00
duncanspumpkin
90a04e2758
Undo mistake. Remove pointless parameter
2019-04-21 19:56:18 +01:00
Duncan
46844e2218
Merge branch 'develop' into issue-9053
2019-04-21 19:50:20 +01:00
Gymnasiast
ec6b738317
Fix #8079 : Crash when unloading buggy custom rides
2019-04-21 12:13:04 +02:00
Hielke Morsink
bcaa856911
Merge pull request #9089 from Broxzier/bugfix/9083-ghost-banner-index
...
Fix #9083 : Wrong sign index is set for clients
2019-04-21 10:26:05 +02:00
Michael Steenbeek
5a906b2378
Port more functions to Ride struct ( #9119 )
2019-04-20 22:22:39 +02:00
Michael Steenbeek
42a1a8704d
Use empty() for vectors; clean up bool comparisons ( #9118 )
2019-04-20 20:39:47 +02:00
Gymnasiast
61a402b913
Fix formatting
2019-04-20 19:19:33 +02:00
hokasha2016
6022521118
Fix #7871 : String::StartsWith() returns true if source is shorter than match
2019-04-20 18:55:27 +02:00
Gymnasiast
28ad78f204
Allow entry of numbers up to 10 million in string_to_money
2019-04-20 18:42:06 +02:00
Gymnasiast
abf416a5a9
Fix string_to_money rounding errors in 4.10, 5.10...
2019-04-20 18:37:50 +02:00
Hielke Morsink
71af88fc5c
Bump network version
2019-04-20 14:47:45 +02:00
duncanspumpkin
8035127acd
Allocate banner index in the constructor.
...
Note this does not fix the issue as ghosts still break placement
2019-04-20 00:05:04 +02:00
Trevor Harkness
0dfa079002
Fix remaining formatting issue
...
Remaining formatting error adjusted in SmallSceneryPlaceAction for CI tests
2019-04-19 02:38:38 -04:00
Trevor Harkness
844a28f3f5
Fix formatting and added to contributors.md
...
Adjusted formatting for CI tests
2019-04-19 02:18:55 -04:00
Trevor Harkness
6df19daa02
Remove comments from subclass
2019-04-17 23:03:37 -04:00
Trevor Harkness
8cb50432de
Fix #9053 . Remove instances of gSceneryGroundFlags
...
Created subclass of GameActionResult in LargeSceneryPlaceAction and SmallSceneryPlaceAction. Removed references to global variable in other files.
2019-04-17 22:55:37 -04:00
Hielke Morsink
70fc620ebe
Fix #9083 : Wrong sign index is set for clients
...
This issue was caused by the ghost for banners, which already create an entry on the banner. The game command is then received while the ghost still exists, giving the placed banner another ID.
This fix is basically a copy of the fix that is also `game_do_command_p` that tackles this same issue.
2019-04-16 20:26:42 +02:00
Florian Will
6e9a9448a2
Fix format issue, second attempt
...
Let's see if I can get this right.
2019-04-15 16:10:57 +02:00
Florian Will
35ff10e480
Fix format issue and add myself to contributors.md
2019-04-15 15:51:01 +02:00
Florian Will
eb6ea8e81d
Fix #5893 : Invalidate widget only if it's visible
...
Remove the widget_invalidate() call after changing a guest's
guest_heading_to_ride_id, because that call fails a debug assertion if
the guest window is open and the currently active tab is not the
"overview" tab. In Release builds (if assertion is disabled),
widget_invalidate() might access the widgets array out of bounds.
Instead, introduce a new flag PEEP_INVALIDATE_PEEP_ACTION for
window_invalidate_flags in the peep struct and set that flag. The guest
window update function then makes sure to invalidate the label if the
flag is set.
The flag could be used in other places to reduce libopenrct2 dependency
on window_*() calls (see #6808 ), but this commit only cares about cases
where the assertion would fail.
2019-04-15 14:26:33 +02:00
Duncan
2515f8d6d2
Merge pull request #9082 from duncanspumpkin/fix_9079
...
Fix 9079
2019-04-09 20:05:38 +01:00
Duncan
e01b5f908a
Merge pull request #9070 from ZehMatt/fix-9068
...
Fix #9068 : Unable to place staff or peeps during multiplayer
2019-04-09 20:05:21 +01:00
duncanspumpkin
0ffa6d1ae5
Increment network version
2019-04-09 18:46:31 +01:00
duncanspumpkin
e2e4c1d942
Fix #9079 . Null derference checked for when getting banner element.
...
Unsure how the save managed to get in this state
2019-04-09 18:39:33 +01:00
duncanspumpkin
2e104a00c8
Increment network version
2019-04-08 17:19:58 +01:00
duncanspumpkin
d6522f0aee
Fix formatting
2019-04-08 17:19:52 +01:00
duncanspumpkin
d40a22e32b
Make suggested changes
2019-04-07 15:11:03 +01:00
duncanspumpkin
b7c3324bae
Include missing include
2019-04-07 14:55:08 +01:00
duncanspumpkin
baad532c17
Fix formatting
2019-04-07 14:55:08 +01:00
duncanspumpkin
00cbd75641
Return more useful error messages.
...
Fix clearance checks always being on for underground placement
2019-04-07 14:55:08 +01:00
duncanspumpkin
d63919c0cc
Implement LargeSceneryPlaceAction
2019-04-07 14:55:07 +01:00
Matt
7c901addc6
Fix #9068 : Unable to place staff or peeps during multiplayer
2019-04-07 14:12:23 +02:00
duncanspumpkin
57efe286cf
Increment network version
2019-04-07 12:24:02 +01:00
duncanspumpkin
008ed86bca
Make requested fixes
2019-04-07 12:02:04 +01:00
duncanspumpkin
aa65e25c6b
Implement banner set style action
2019-04-07 10:10:36 +01:00
duncanspumpkin
3593366e95
Implement banner set colour action
2019-04-07 09:22:39 +01:00
duncanspumpkin
5ab42488a9
Implement large scenery set colour action
2019-04-07 09:22:33 +01:00
duncanspumpkin
8ef5afe2ce
Implement wall set colour action
2019-04-06 19:39:01 +01:00
duncanspumpkin
8fc1d70239
Implement small scenery set colour action
2019-04-06 19:39:00 +01:00
duncanspumpkin
63f9e3dbb4
Set tertiary colour correctly
2019-04-06 18:56:44 +01:00
duncanspumpkin
3e9356857f
Fix wall placement in track designs.
...
X and Y values go a bit screwey in ride previews. So you need to override there check.
Also fixed the wall from nesting the command wrong
2019-04-06 18:06:40 +01:00
duncanspumpkin
cee953f899
Fix #9042 . Pass the flags to wall placement when in track design mode
2019-04-04 19:23:44 +01:00
duncanspumpkin
eedb24700d
Fix #8535 , #8480 . Unintialised variable used to get path object.
...
When you try to mirror a track design that has a path object type that isn't loaded it will try to pass an uninitialised variable as the index of the path object. This will cause a bad pointer to be generated. Fix was to auto set it to zero and to be super careful reset it again to zero in the case when its not available
2019-04-04 19:23:44 +01:00
duncanspumpkin
5280728760
Fix formatting
2019-04-04 19:23:44 +01:00
duncanspumpkin
356a0e5e91
Rework flags
2019-04-04 19:23:44 +01:00
duncanspumpkin
06645f6a0d
Further small refactor. Name Game_command_flag_5
2019-04-04 19:23:44 +01:00
duncanspumpkin
561ce03d18
Fix formatting
2019-04-04 19:23:44 +01:00
duncanspumpkin
30a5194085
Use a vector for map selection tiles
2019-04-04 19:23:44 +01:00
duncanspumpkin
7b2363f0ef
Refactor further
2019-04-04 19:23:43 +01:00
duncanspumpkin
f7c84fff60
Split scenery place into multiple functions
2019-04-04 19:23:38 +01:00
duncanspumpkin
9f80a16353
Further rename
2019-04-04 18:58:52 +01:00
duncanspumpkin
2320cd169f
Rename PTD enum
2019-04-04 18:58:52 +01:00
ζeh Matt
62f163a67d
Don't enable multithreading option by default. ( #9039 )
2019-04-04 12:11:37 +02:00
anon569
3efdcdef43
Hungarian Forint fix ( #9043 )
...
https://en.wikipedia.org/wiki/Hungarian_forint
"The Hungarian abbreviation for forint is Ft, which is written after the number with a space between."
2019-04-04 08:01:21 +01:00
hokasha2016
1ff1f6d126
Add the Hungarian Forint (HUF) to the list of available currencies. ( #9017 )
2019-04-03 00:04:22 +02:00
Michał Janiszewski
2fb31910ca
Merge pull request #8481 from ZehMatt/multicore-rendering
...
Implement partial multicore rendering
2019-04-02 22:08:46 +02:00
Matt
c520b0061e
Refactor large_scenery_sign_fit_text to not return static local.
2019-04-02 20:14:50 +02:00
Matt
4e264bd45d
Use mutex to protect scrolling banner cache from data race
2019-04-02 20:14:50 +02:00
duncanspumpkin
c8523b18b9
One more null check
2019-04-02 19:08:06 +01:00
duncanspumpkin
78527f7af4
Extra checks for nullptrs and bad values
2019-04-02 18:52:52 +01:00
duncanspumpkin
09875311b3
Increment network version
2019-04-02 18:36:57 +01:00
duncanspumpkin
7e6254f30c
Fix function.
2019-04-02 18:36:57 +01:00
duncanspumpkin
29f5018bd1
Implement wall place game action
2019-04-02 18:36:57 +01:00
Gymnasiast
9839bb7bba
Fix path preview
...
More work is needed to properly split the paths, but this will do for now.
2019-04-01 21:58:57 +02:00
Michael Steenbeek
b618bbdcd4
Implement GameAction for setting date
2019-03-31 19:48:51 +02:00
Matt
1153b97ace
Use thread_local to protect globals from data race
2019-03-31 17:15:15 +02:00
Matt
4b1e7c3dd2
Remove _unk9E32BC from global scope and make it local
2019-03-31 17:15:15 +02:00
Matt
383ded68e9
Cleanup
2019-03-31 15:50:55 +02:00
Matt
65ef018e4e
Move paint_session_alloc and paint_session_free into Painter.
2019-03-31 15:50:55 +02:00
Matt
db96df010f
Expose Painter in Context
2019-03-31 15:50:55 +02:00
Matt
37c3809744
Implement partial multicore rendering
2019-03-31 15:50:55 +02:00
ζeh Matt
521b78390f
Fix #8909 : Potential crash when invoking game actions as server
2019-03-31 14:42:47 +02:00
ζeh Matt
0b41c0f9a1
Fix #8988 : Improve lookups for codepoint offsets
2019-03-30 21:50:49 +01:00
Michael Steenbeek
8d83f5a549
Merge pull request #8978 from Gymnasiast/refactor/inversions
...
Close #8965 : Refactor ride->inversions
2019-03-28 20:28:35 +01:00
Duncan
c01cfbdc26
Merge pull request #8902 from duncanspumpkin/land_smooth_ga
...
Land Smooth Game Action
2019-03-28 19:10:30 +00:00
Michael Steenbeek
a50c7836f8
Move more ride functions to struct methods ( #8977 )
2019-03-27 21:53:38 +01:00
Gymnasiast
731af74732
Cast after std::min
2019-03-27 21:49:10 +01:00
Michael Steenbeek
ec3d757854
Fix #5905 : Urban Park MGR has entrance/exit swapped
2019-03-27 20:53:48 +01:00
Michael Steenbeek
bbf523e829
Fix #8537 : Imported RCT1 rides/shops are all numbered 1
2019-03-27 20:07:13 +01:00
duncanspumpkin
9b4bc97826
Increment network version
2019-03-27 18:49:19 +00:00
duncanspumpkin
68bf1bc464
Make requested changes
2019-03-27 18:48:26 +00:00
duncanspumpkin
95b7a90c55
Refactor function names and variables
2019-03-27 18:48:26 +00:00
duncanspumpkin
cc57de791a
Fix formatting. Add correct headers
2019-03-27 18:48:26 +00:00
duncanspumpkin
227786e05b
Remove game command
2019-03-27 18:48:26 +00:00
duncanspumpkin
81307f71df
Implement LandSmoothAction
2019-03-27 18:48:26 +00:00
Gymnasiast
a27e04e5a3
Limit inversions and holes to 31 (for now)
2019-03-27 19:44:46 +01:00
Gymnasiast
a3a1028385
Drop bitmask from TrackShelteredEighths comparisons
2019-03-27 19:44:33 +01:00
Gymnasiast
bc0b0fe231
Increase argument size of get_inversions_ratings()
2019-03-27 15:57:17 +01:00
Gymnasiast
921e426605
Increase size of inversions and holes to uint16_t
2019-03-27 15:55:34 +01:00
Gymnasiast
44da799afd
Modify return type of get_num_of_sheltered_eighths()
2019-03-27 15:52:18 +01:00
Gymnasiast
ba404338cc
Max out inversions value instead of truncating
2019-03-27 14:02:32 +01:00
Gymnasiast
2a99c42242
Fix code to determine number of golf holes
2019-03-27 12:53:15 +01:00
ζeh Matt
31d32caf8c
Fix #8972 : Master server unable to query game info
2019-03-27 11:30:41 +01:00
Gymnasiast
64e51cd34b
Close #8965 : Refactor ride->inversions
2019-03-27 11:30:18 +01:00
Michael Steenbeek
d88d80335d
Fix #8882 : Submarine Ride does not count as indoors ( #8964 )
2019-03-27 10:09:14 +01:00
Gymnasiast
7f045918e1
Fix formatting
2019-03-27 10:06:25 +01:00
Gymnasiast
bbfa2570d5
Switch Czech to sprite font
2019-03-27 10:06:25 +01:00
Gymnasiast
ff12d5c202
Add Z with caron
2019-03-27 10:06:25 +01:00
Gymnasiast
cf65d01ac0
Add U with ring
2019-03-27 10:06:25 +01:00
Gymnasiast
ef5472c566
Add S with caron
2019-03-27 10:06:25 +01:00
Gymnasiast
fd1f763b83
Add R with caron
2019-03-27 10:06:25 +01:00
Gymnasiast
43d4a20b79
Add N with caron
2019-03-27 10:06:25 +01:00
Nazey
047fa65a66
Fix #8942 : Water level is raised abnormally ( #8971 )
2019-03-26 17:34:30 +01:00
Michael Steenbeek
c841ee31e7
Remove more remains of scenario description from Object Selection window
2019-03-25 17:21:53 +01:00
Michael Steenbeek
cf913d1419
Remove two unused functions
2019-03-25 15:56:40 +01:00
ζeh Matt
d41822e0f5
Network relevant player info on changes
2019-03-24 23:16:57 +01:00
Ben Hopkins
c537f87fd5
Add scenery picker shortcut
2019-03-24 22:45:42 +01:00
Gymnasiast
262a9f29e8
Fix formatting
2019-03-24 22:24:40 +01:00
ζeh Matt
184d95c720
Fix #8947 : Detection of AVX2 support
2019-03-24 21:53:54 +01:00
Duncan
791c3059f6
Add ParkEntranceRemove GameAction
2019-03-24 21:41:14 +01:00
Nazey
9cbc308c40
Remove gTrackGroundFlags by returning it within GameActionResult ( #8930 )
...
Fix #8726
2019-03-24 19:48:37 +00:00
Matt
c0cd1aaef3
Exclude host from rate limiting.
2019-03-22 08:06:54 +01:00
Matt
097ed015d8
Add cooldown time for SmallSceneryPlaceAction
2019-03-22 08:06:54 +01:00
Matt
cfe2fb939e
Add cooldown time to RideDemolishAction
2019-03-22 08:06:54 +01:00
Matt
7be312c4c6
Implement rate limiting times for game actions.
2019-03-22 08:06:54 +01:00
Michael Steenbeek
df687ac59c
Merge pull request #8928 from AaronVanGeffen/scenario-editor-cheats
...
Make cheats menu partially accessible in scenario editor
2019-03-21 17:42:20 +01:00
Aaron van Geffen
f4602d0a34
Use SCREEN_FLAGS_EDITOR when appropriate.
2019-03-20 20:58:08 +01:00
Duncan
476f392eeb
Merge pull request #8919 from duncanspumpkin/console_set_price
...
Console command to set price of all rides of type
2019-03-20 19:13:19 +00:00
Michael Steenbeek
1c570c8eec
Move some ride functions to struct methods
2019-03-20 20:05:25 +01:00
duncanspumpkin
320c88df99
Make requested changes
2019-03-20 18:48:01 +00:00
Gymnasiast
511dd44f6b
Bump network version
2019-03-20 16:57:22 +01:00
Gymnasiast
aa21f0fb1d
Prepare for food/drink stall recolouration
2019-03-19 22:55:28 +01:00
Gymnasiast
79318997bc
Remove old code for MEDIENTR
2019-03-19 22:21:06 +01:00
Gymnasiast
8b1330ec57
Add comment [ci skip]
2019-03-19 22:13:02 +01:00
Gymnasiast
14c2925ae5
Add import code to make Ice Cream Stalls light blue
2019-03-19 22:11:18 +01:00
Gymnasiast
59c74ead94
Add fallback for legacy objects
2019-03-19 21:20:31 +01:00
Gymnasiast
4f8548dfea
Allow different default colours per stall
2019-03-19 21:20:31 +01:00
Michael Steenbeek
68aa5122fa
Fix #6006 : Objects higher than 6 metres are considered trees
2019-03-18 22:56:14 +01:00
duncanspumpkin
d5fa7185ca
Prevent a crash when bad data passed
2019-03-18 21:50:29 +00:00
duncanspumpkin
576976627e
Use displayable character instead of pipe
2019-03-18 21:45:32 +00:00
duncanspumpkin
fb36d2b1f9
Set price of all rides from the console
2019-03-18 21:38:48 +00:00
duncanspumpkin
aa2f0a46d0
Increment network version
2019-03-18 20:01:30 +00:00
duncanspumpkin
add40feb57
Merge #8898 branch 'staff_ga' into game_actions
2019-03-18 20:00:34 +00:00
duncanspumpkin
351adcc88b
Merge #8897 branch 'surface_set_style_ga' into game_actions
2019-03-18 19:58:21 +00:00
duncanspumpkin
f28be1ae30
Merge #8881 branch 'set_park_open' into game_actions
2019-03-18 19:57:50 +00:00
duncanspumpkin
329514a49c
Merge #8900 branch 'zehmatt/mp-peep-flags-ga' into game_actions
2019-03-18 19:56:49 +00:00
Duncan
a9e9993ff5
Fix #8910 . Staff patrol areas sharing id's. ( #8912 )
2019-03-17 23:18:56 +01:00