glx22
a1e492d0d8
Fix #7439 : don't overwrite CompanyRemoveReason with ClientID ( #7465 )
2019-04-05 15:11:52 +02:00
Henry Wilson
ab711e6942
Codechange: Replaced SmallVector::[Begin|End]() with std alternatives
2019-03-26 20:15:57 +00:00
Henry Wilson
a0f36a50e6
Codechange: Replaced SmallVector::Append() with std::vector::[push|emplace]_back()
2019-03-26 20:15:57 +00:00
Henry Wilson
af7d9020a1
Codechange: Use override specifer for overriding member declarations
...
This is a C++11 feature that allows the compiler to check that a virtual
member declaration overrides a base-class member with the same signature.
Also src/blitter/32bpp_anim_sse4.hpp +38 is no longer erroneously marked
as virtual despite being a template.
2019-03-24 16:10:04 +01:00
Patric Stout
e3c639a09f
Remove: ENABLE_NETWORK switch
...
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
2019-03-20 19:24:55 +01:00
glx
8e7fe3973f
Add: CompanyCtrlAction enum for CMD_COMPANY_CTRL actions
2019-02-04 21:08:36 +01:00
Charles Pigott
f5b1115039
Doc: Lots and lots of doxymentation fixes
2018-10-31 12:35:54 +01:00
Matthijs Kooijman
fa87212a76
Fix: Some spelling errors in printed messages
2018-04-30 13:38:58 +02:00
frosch
b4b98e5165
(svn r27893) -Codechange: Use fallthrough attribute. (LordAro)
2017-08-13 18:38:42 +00:00
rubidium
f28ff446e9
(svn r26975) -Fix: reading too many bits when determining the client index for desync debug message
2014-10-07 17:32:29 +00:00
planetmaker
105306609f
(svn r26616) -Fix (r26576) [FS#6025]: First send packages about new company, then clients joining it to admin port (Taede)
2014-05-25 19:01:30 +00:00
rubidium
4a52300838
(svn r26576) -Fix [FS#6003]: [Network] AIs would not reset certain network state information upon creation of their company
2014-05-11 12:52:21 +00:00
rubidium
9ed12b0f07
(svn r26509) -Codechange: replace strdup with stredup (the latter ensures the return is not NULL)
2014-04-25 15:40:32 +00:00
rubidium
160ad31028
(svn r26488) -Codechange: perform the appropriate length checks when getting a client name
2014-04-23 21:19:54 +00:00
frosch
ef4c2ce031
(svn r26485) -Codechange: Replace ttd_strlcpy and ttd_strlcat with strecpy and strecat.
2014-04-23 20:44:42 +00:00
rubidium
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
rubidium
1a043202d1
(svn r26043) -Fix [FS#5811]: occasional hanging when client joins
2013-11-21 18:35:31 +00:00
rubidium
18a3a569fb
(svn r26005) -Fix [FS#5478]: crash when transferring savegame from server to client
2013-11-15 22:22:01 +00:00
planetmaker
c24374f99c
(svn r24900) -Fix [FS#5389]: Comments with typos (most fixes supplied by Eagle_rainbow)
2013-01-08 22:46:42 +00:00
frosch
de770d7563
(svn r24580) -Fix [FS#5308]: Do not add duplicates to the ban list. (alechz)
2012-10-09 20:36:31 +00:00
rubidium
a961276b6f
(svn r24221) -Fix [FS#5166]: Lag counters were not properly reset when switching states making it possible to get disconnected for lagging when you weren't lagging
2012-05-09 19:14:36 +00:00
rubidium
ea2f19d4f2
(svn r23958) -Fix: don't allow chat messages from pre-active clients. As they haven't got the savegame yet, they won't have the interface to send them either (dihedral)
2012-02-16 20:45:03 +00:00
rubidium
c5f7a0f69d
(svn r23957) -Fix [FS#4990]: allow sending chat to pre-active clients as the clients start accepting once they send 'map ok' to the server, which is the same moment we change their status to pre-active
2012-02-16 20:44:03 +00:00
smatz
b5525fd33d
(svn r23941) -Add: support for clang
2012-02-12 21:17:32 +00:00
rubidium
4f62472fd9
(svn r23817) -Fix [FS#4962]: desync due to different NewGRF version. So reduce the chance that it happens significantly with betas/RCs/nightlies by doing the same as is done for stable releases: check the NewGRF version of server vs client.
...
Previously this check was not done for nightlies/betas/RCs due to missing versioning information in the source tarballs, but they have that for a while now. So just force the NewGRF version check for all versions, and remove the broken --revision configure option
2012-01-17 17:27:38 +00:00
truebrain
6c7c02eb14
(svn r23780) -Fix [FS#4963] (r23764): also name the two new errors server-side. As extra, split up one of the errors in 3 errors, to be more specific what goes wrong. As cherry on top, make sure on all sides we can never again forget to add such entries on both sides, by introducing an assert_compile()
2012-01-09 21:22:48 +00:00
rubidium
182969f531
(svn r23769) -Codechange: make the lag/join start timeouts configurable as well
2012-01-07 14:43:45 +00:00
rubidium
bddfcaef95
(svn r23764) -Fix [FS#4955]: make default timeouts for certain states lower and configurable
2012-01-06 21:49:06 +00:00
rubidium
6d6be50ae0
(svn r23740) -Codechange: remove some 300 unneeded includes from the .cpp files
2012-01-03 21:32:51 +00:00
rubidium
104adbdb3a
(svn r23337) -Fix [FS#4826]: don't send chat messages to clients that haven't joined yet
2011-11-26 17:28:18 +00:00
rubidium
de27205e6c
(svn r23031) -Fix [FS#4804]: for the admin "bots" there was no distinction between bankruptcy and manual removal of companies even though the API suggested that
2011-10-15 20:42:32 +00:00
rubidium
f6b0561cd8
(svn r22805) -Codechange: move use of magic number for version checking to more logical location
2011-08-21 18:57:45 +00:00
rubidium
c4aa943aaa
(svn r22424) -Document: some more bits
2011-05-05 16:24:48 +00:00
rubidium
2e572b98de
(svn r22400) -Codechange: replace some defines in the tcp/game code so doxygen can create better documentation
2011-05-01 11:30:03 +00:00
rubidium
1c1e9f6941
(svn r22384) -Fix [FS#4585]: No client error packet was sent to the admin bots
2011-04-30 12:09:26 +00:00
rubidium
380d4b277b
(svn r22372) -Fix (r22364) [FS#4598]: segmentation fault when trying to get the server's IP
2011-04-22 19:53:28 +00:00
rubidium
ce91f6b45e
(svn r22370) -Codechange/fix: keep better accounting of the order in which clients joined:
...
* Clients can't be starved from joining the game
* Clients will see the amount of clients actually waiting in front of them, instead of the amount of waiting clients in total
2011-04-22 16:07:47 +00:00
rubidium
cdfc0ec4a3
(svn r22369) -Codechange: allocate ClientInfo when needed, i.e. don't allocate it for clients that are there to just get a list of companies. This means that these short lived clients won't be seen by the admin network in their client queries anymore
2011-04-22 16:05:05 +00:00
rubidium
2cae0cd54c
(svn r22368) -Codechange: move the IP address field from the ClientInfo to ClientSocket
2011-04-22 16:03:48 +00:00
rubidium
146d532d51
(svn r22367) -Codechange: send ClientSockets instead of ClientInfos to the admin "core" as they send IP addresses to the admin "bots"
2011-04-22 16:03:13 +00:00
rubidium
c61abe0019
(svn r22366) -Codechange: make GetClientIP a function of the server's ClientSocket, after all the Socket is the bit that's associated with the network
2011-04-22 16:02:21 +00:00
rubidium
caf02450fb
(svn r22365) -Codechange: add overload of NetworkServerKickOrBanIP using the ClientID, which later resolves the IP address to ban. This to consolidate the knowledge about resolving IP addresses
2011-04-22 15:59:32 +00:00
rubidium
1c419d99bc
(svn r22364) -Codechange: don't show the (unknown) client address in the client list at clients
2011-04-22 15:57:05 +00:00
rubidium
f1d0c1a746
(svn r22363) -Codechange: NetworkFindClientStateFromClientID -> NetworkClientSocket::GetByClientID
2011-04-22 15:54:42 +00:00
rubidium
bc9a803ea9
(svn r22362) -Codechange: NetworkFindClientInfoFromClientID -> NetworkClientInfo::GetByClientID
2011-04-22 15:54:16 +00:00
rubidium
393fb8e46b
(svn r22361) -Codechange: delete the client list popup when the client got removed (instead of previously selecting some other client)
2011-04-22 15:53:40 +00:00
smatz
b1286bbcda
(svn r22335) -Cleanup (r22308): remove superfluous tabs
2011-04-17 13:36:51 +00:00
rubidium
d1a50a01b4
(svn r22308) -Fix [FS#4574]: waiting on a server could kick the client, or rather the client would kick itself due to an unexpected packet
2011-04-09 21:52:38 +00:00
rubidium
848761e3a9
(svn r22092) -Fix-ish (r22068): when you change a boolean to a enum, check specifically for a particular value
2011-02-17 18:45:44 +00:00
smatz
a5b9858a36
(svn r22086) -Fix: do not check if we can allocate an item if we won't try to do so anyway
2011-02-15 13:15:12 +00:00
rubidium
befa79ba4a
(svn r22070) -Fix [FS#4503] (r21399): crashes when disconnecting after requesting the map
2011-02-12 21:30:57 +00:00
rubidium
a19bc28aba
(svn r22069) -Fix: delete all savegame packets, not just the first one
2011-02-12 21:29:35 +00:00
rubidium
adfd648031
(svn r22068) -Codechange/Fix: return "connection lost" instead of "okay" when SendPackets closed the connection
2011-02-12 21:09:34 +00:00
rubidium
92d0d6d10b
(svn r22067) -Fix: don't hold a mutex when sending packets and thus possibly closing the connection as that wants to acquire the mutex again
2011-02-12 21:07:30 +00:00
rubidium
d8cada7563
(svn r22064) -Fix [FS#4497] (r21399): crash when disconnecting and reconnecting while the server is still saving the savegame
2011-02-11 23:20:35 +00:00
rubidium
05a846a574
(svn r22032) -Codechange: add some asserts to verify we don't allocate too many NetworkClientSockets/Infos
2011-02-08 21:47:10 +00:00
rubidium
7eba2bf4d3
(svn r21890) -Cleanup: remove some unneeded includes
2011-01-22 14:52:20 +00:00
rubidium
795a528328
(svn r21854) -Codechange: refactor the password setting methods to make it possible to change the password of other companies (on the server)
2011-01-19 16:47:40 +00:00
rubidium
e54a1f6721
(svn r21853) -Codechange: HashCurrentCompanyPassword is only used by servers, so move it to network_server.* (dihedral)
2011-01-19 16:37:06 +00:00
rubidium
7dafd04f4b
(svn r21727) -Fix [FS#4377]: admin bots weren't always notified of password changes (dihedral)
2011-01-04 22:28:02 +00:00
smatz
810873ff33
(svn r21704) -Fix [FS#4374]: no need to perform any more checks after the connection is closed (Rubidium)
2011-01-03 18:36:51 +00:00
rubidium
b25cf57542
(svn r21701) -Codechange: ConsoleColour = TextColour, so make it that way and remove some unneeded casts
2011-01-03 12:01:41 +00:00
alberth
b633ffaa1d
(svn r21571) -Codechange: Having a break after a return is no good.
2010-12-21 15:23:54 +00:00
rubidium
9139a6c858
(svn r21405) -Codechange: prepare sending of company information in the UDP packet for longer company names (in bytes), by truncating the names if needed
2010-12-05 22:21:13 +00:00
rubidium
5f25cdbbd5
(svn r21401) -Fix: ofcourse MSVC x64 has something to complain about...
2010-12-05 15:08:41 +00:00
rubidium
216e48cd07
(svn r21399) -Change/Feature/Fix [FS#4284]: perform the compression of savegames to send to the client asynchroniously. This will reduce the lag of the other clients to the time it takes to make the memory dump and it will speed up downloading the map as the download starts earlier (possibly with a slightly lower bandwidth due to slow compression). This should also fix the lag message people get when the savegame compression takes more than a few seconds.
2010-12-05 14:48:39 +00:00
rubidium
02b3bc57d5
(svn r21398) -Change/Feature-ish: when making a savegame to send to a client, don't write it to disk but create the packets immediately
2010-12-05 14:45:52 +00:00
rubidium
97434f0e06
(svn r21392) -Change: prepare the network protocol for getting the file size later in the download process
2010-12-05 14:34:19 +00:00
rubidium
fd752ca2b0
(svn r21363) -Add: support for limiting the amount of (accepted) incoming data
2010-11-30 20:01:26 +00:00
rubidium
31c8ab0ed8
(svn r21361) -Change: make sure the client is listening, or rather receiving, our frames
2010-11-30 14:18:20 +00:00
rubidium
b6c2216749
(svn r21358) -Codechange: make some network function names conform to coding style
2010-11-30 13:38:46 +00:00
rubidium
c60a850fed
(svn r21350) -Fix: some indentation
2010-11-28 22:45:47 +00:00
rubidium
67f74559fc
(svn r21334) -Fix [FS#4271]: make (more) sure that the savegame and transferred file are the same file and not different ones
2010-11-26 22:25:02 +00:00
rubidium
6d09f4a3cb
(svn r21254) -Change: show a different "lag" message when a client is lagging because of connection trouble or lagging because the client is just slow
2010-11-19 12:33:19 +00:00
rubidium
673b3711b4
(svn r21182) -Fix: possible just-freed memory reads
2010-11-14 12:05:24 +00:00
rubidium
4ea67eff8b
(svn r21032) -Codechange: perform some more strict tests on the server side when receiving some packets and don't send some when the clients aren't ready for them
2010-10-24 20:30:53 +00:00
rubidium
f24c91c487
(svn r21030) -Codechange: move ClientStatus into the network server socket class
2010-10-24 20:07:32 +00:00
rubidium
2cd67a51ac
(svn r21029) -Codechange: split the map downloading packet + 3-state enum into 3 separate packets
2010-10-24 20:03:33 +00:00
rubidium
073b965829
(svn r21024) -Fix: erroneous tab
2010-10-24 15:02:43 +00:00
rubidium
af9a6b6b42
(svn r21001) -Fix [FS#4170] (r20936): clients were not always notified of a player leaving the game
2010-10-20 11:58:34 +00:00
rubidium
d71f590ed6
(svn r20993) -Codechange: some shuffling of game protocol packet description so they're documented in the "same" place as UDP, content and admin packets (dihedral)
2010-10-18 20:41:53 +00:00
rubidium
d9602f4ef9
(svn r20973) -Add: chat sending and receiving support for remote admins (dihedral)
2010-10-17 17:40:18 +00:00
rubidium
ae20cb4f3d
(svn r20970) -Add: company change notification to remote admins (dihedral)
2010-10-17 17:37:45 +00:00
rubidium
fe44944f32
(svn r20969) -Add: client info change notification to remote admins (dihedral)
2010-10-17 17:37:26 +00:00
rubidium
b4ce7fad7f
(svn r20967) -Add: infrastructure to send information to remote admins at specific intervals (dihedral)
2010-10-17 17:36:23 +00:00
rubidium
234bee0858
(svn r20938) -Codechange: make the code for listening on a socket (more) reusable
2010-10-15 21:56:06 +00:00
rubidium
c9cbab14ea
(svn r20937) -Codechange: move some variables from client/server to server only
2010-10-15 20:29:59 +00:00
rubidium
f712055002
(svn r20936) -Codechange: make server side packet sending methods class methods
2010-10-15 20:25:07 +00:00
rubidium
9858d699a3
(svn r20935) -Codechange: only let the server side use a pool of connected sockets
2010-10-15 19:58:56 +00:00
rubidium
bda26d03b5
(svn r20934) -Codechange: move NetworkGetClientName to the server's socket
2010-10-15 19:35:08 +00:00
rubidium
7ba07d9573
(svn r20929) -Codechange: make NetworkCloseClient a class method
2010-10-15 18:42:52 +00:00
rubidium
0ca7e4e82e
(svn r20924) -Codechange: make the game connection packet handling look more like UDP/content packet handling
2010-10-15 13:47:37 +00:00
rubidium
8eb07d097e
(svn r20923) -Codechange: prepare creating sub-classes of NetworkClientSocket for server and client side
2010-10-15 13:22:00 +00:00
alberth
9f5a96ead2
(svn r20689) -Codechange: Make some global functions used in 1 .cpp file static in that file.
2010-08-29 15:58:43 +00:00
rubidium
a4c6d07edc
(svn r20553) -Feature: allow rate limiting of incoming commands
2010-08-19 08:59:36 +00:00
rubidium
b594990071
(svn r20549) -Codechange: centralise the handling of the incoming commands (from clients and the server)
2010-08-18 22:40:17 +00:00
rubidium
e8e22c99fd
(svn r20548) -Codechange: rename some variables giving them slightly more meaningful names
2010-08-18 21:30:38 +00:00
rubidium
69fa0b36d3
(svn r20542) -Codechange: generalise the setting of "p2" to the ClientID.
2010-08-18 17:06:45 +00:00
rubidium
1c3d42598e
(svn r20510) -Codechange: unify packet queue handling and make insertion O(1) instead of O(n)
2010-08-15 23:44:45 +00:00
alberth
ee01ec9136
(svn r20291) -Codechange: Unify break coding style.
2010-08-01 21:19:49 +00:00