4017439c37
(svn r16948) -Codechange: some code reductions and usage of wrapper functions
2009-07-25 10:39:58 +00:00
7440ec7a73
(svn r16947) -Codechange: use TileArea instead of train_tile, trainst_w and trainst_h.
2009-07-25 08:54:19 +00:00
3ec35e4e8d
(svn r16942) -Codechange: document CanExpandRailStation and remove the 'magic' array of numbers for a named struct
2009-07-24 17:05:17 +00:00
cf38a5bee6
(svn r16939) -Codechange: s/RailwayStation/RailStation/ to unify the way it's written.
2009-07-24 11:47:12 +00:00
803cf87885
(svn r16934) -Codechange: introduce a simple helper function to check whether a station is pending deletion or not
2009-07-24 07:38:10 +00:00
5f9ee68eac
(svn r16926) -Fix (r16925): if checking whether a station can be adjoined, don't check whether 'the other station you have already found' to be valid but the station that you just found. Especially because you won't have found as station until you have found one.
2009-07-23 12:13:53 +00:00
16ad8df175
(svn r16925) -Fix (r16909): guard commands more against using waypoints as stations and/or accidentally reusing waypoints for stations or vice versa.
2009-07-23 12:02:09 +00:00
f48cc9d4bf
(svn r16923) -Codechange: move Cmd*Buoy* to waypoint_cmd.cpp and make them behave more like waypoints, e.g. reuse station signs of recently deleted buoys
2009-07-23 00:14:05 +00:00
cb0409fe52
(svn r16912) -Codechange: split waypoint.h in waypoint_base.h and waypoint_func.h
2009-07-22 10:18:19 +00:00
68ead6b84f
(svn r16909) -Fix [FS#2996]: NewGRF stations would be triggering assertions all over the place when using the more advanced station types.
...
-Change: make (rail) waypoints sub classes of 'base stations', make buoys waypoints and unify code between them where possible.
2009-07-22 08:59:57 +00:00
8405d7d7e7
(svn r16907) -Codechange: make a more clear distinction between reservation functions that return a bool and that return TrackBits; GetRailStationReservation vs GetRailwayStationReservation, which one returns the bool and which one the TrackBits?
2009-07-21 22:37:10 +00:00
f09df64608
(svn r16899) -Fix (r16896): Missing 'return'.
2009-07-21 16:20:02 +00:00
43eda3dfbf
(svn r16896) -Codechange: make station spec allocation and station animation functions work for both stations and waypoints
2009-07-21 11:11:05 +00:00
42e1bdacbc
(svn r16880) -Codechange: replace magic numbers with their enums and use a clearer variable name than 'flag' in the station naming function.
2009-07-19 15:58:47 +00:00
861a2163f6
(svn r16869) -Codechange: make drawing waypoints a tiny bit more like drawing stations
2009-07-18 10:01:31 +00:00
8c17c6cb2b
(svn r16868) -Codechange: unify UpdateAll[Station|Waypoint]VirtCoords
2009-07-18 08:41:58 +00:00
1f29e38b83
(svn r16849) -Codechange: replace GetCargo() by CargoSpec::Get()
2009-07-16 19:00:13 +00:00
2b1c43f81f
(svn r16825) -Codechange: unify dirtying when updating the viewport signs.
2009-07-13 23:15:13 +00:00
e067d4a4b8
(svn r16821) -Codechange: unify the naming of type::UpdateVirtCoord and UpdateAll[Type]VirtCoords.
2009-07-13 22:33:25 +00:00
b6960e4e17
(svn r16814) -Codechange: make IsNormalAircraft() member of Aircraft
2009-07-13 16:37:27 +00:00
86768da0f6
(svn r16791) -Codechange: unify (and document) the Remove[StationType] functions.
2009-07-10 22:46:30 +00:00
9ae07bba85
(svn r16766) -Codechange: remove station->MarkDirty. It is in all cases meant to only update the sign and not invalidate the widget; the widget would be invalidated by a call before/after the call to MarkDirty or it wouldn't make sense because e.g. the window doesn't exist anymore/yet.
2009-07-08 12:01:26 +00:00
3fb1506d6d
(svn r16765) -Codechange: give ViewportSign's width_1 and width_2 more self explaining names
2009-07-08 08:50:20 +00:00
3086383cdc
(svn r16761) -Codechange: make UpdateViewportSignPos(ition) a class function of ViewportSign
2009-07-07 16:51:20 +00:00
fbb2fb9720
(svn r16760) -Codechange: make UpdateStationVirtCoord a function of Station
2009-07-07 16:43:58 +00:00
4d14c1b534
(svn r16722) -Codechange: unify the naming of the Is/Set/HasArticulatedPart functions
2009-07-02 09:06:15 +00:00
61e735ba4c
(svn r16721) -Codechange: make Is/SetRoadVehicleFront, Is/Set/HasArticulatedPart member of RoadVehicle.
2009-07-02 08:59:27 +00:00
adc5363202
(svn r16717) -Codechange: make IsFrontEngine() member of Train
2009-07-01 22:22:01 +00:00
927c4a0fe8
(svn r16709) -Fix [FS#2994]: the list of animated tiles could have duplicates (only for old savegames) and tiles that weren't animated
2009-07-01 14:51:05 +00:00
a288e4d82f
(svn r16678) -Codechange: Turn CargoArray into a class, so one does not have to deal with sizeof() wrt. typedef-ed arrays.
2009-06-27 21:06:58 +00:00
812ad41f23
(svn r16676) -Codechange: Rename AcceptedCargo to CargoArray and its instances to more meaningful names.
2009-06-27 18:26:50 +00:00
50b5678e26
(svn r16673) -Codechange: rename GetProducedCargo() to AddProducedCargo() and change its behaviour accordingly
2009-06-27 17:05:20 +00:00
2987f02144
(svn r16663) -Codechange: make removing of railway station tiles faster
2009-06-26 12:25:53 +00:00
90554ee390
(svn r16662) -Codechange: replace GetRoadStopByTile() by RoadStop::GetByTile()
2009-06-26 10:45:20 +00:00
c0ac230e3e
(svn r16660) -Codechange: get rid of more dummy tile_type_procs
2009-06-25 20:08:59 +00:00
c30a87758f
(svn r16659) -Codechange: rename GetAcceptedCargo() to AddAcceptedCargo() and change its behaviour accordingly
...
-Codechange: remove dummy GetAcceptedCargo_*() handlers
2009-06-25 19:23:09 +00:00
38477f2b36
(svn r16655) -Codechange: use IsRailwayStationTile() more
2009-06-25 15:54:06 +00:00
fa1ad0fd3c
(svn r16654) -Codechange: cache industries in station's coverage area instead of searching them everytime payment is made
2009-06-25 15:42:03 +00:00
8343340acb
(svn r16643) -Codechange: replace GetStationByTile() by Station::GetByTile()
2009-06-24 17:39:54 +00:00
0045096403
(svn r16640) -Codechange: move roadstop stuff to separate files
2009-06-23 21:44:48 +00:00
c7bd6c8d34
(svn r16614) -Codechange: Make the airport min/max available year a property of the Airport class.
...
-Change: rename station.always_small_airport to station.never_expire_airports to make it more future-proof
2009-06-21 13:26:30 +00:00
ea03c76bd6
(svn r16569) -Codechange: remove the gaps in the AirportTiles enum
2009-06-12 19:44:47 +00:00
4b34957987
(svn r16566) -Codechange: enumify all airport tiles
2009-06-12 14:53:57 +00:00
0c10006907
(svn r16527) -Codechange: use static member functions instead of simple casts when converting Vehicle to specialised vehicle types. Includes safety check
2009-06-06 16:54:22 +00:00
bab70a823d
(svn r16491) -Codechange: Added parentheses around bitwise operators for code style.
2009-06-01 11:43:36 +00:00
45af2a294c
(svn r16452) -Fix: don't trigger station animations when the station was deleted in the same tick
2009-05-27 23:11:52 +00:00
5df12c37a9
(svn r16448) -Fix [FS#2909]: road vehicles ending up on the pavement when they are in a drive through station that got removed due to bankruptcy
2009-05-27 17:17:06 +00:00
5a463c8347
(svn r16442) -Codechange: use new Vehicle accessors at more places
2009-05-26 22:45:48 +00:00
0d99b6c71c
(svn r16421) -Codechange: do not unnecessarily remove constness or unnecessarily add it.
2009-05-24 20:29:04 +00:00
a4557c7da4
(svn r16416) -Fix [FS#2912]: Rework deleting of news when referenced vehicles/stations/industries are deleted.
2009-05-24 16:52:42 +00:00
80e94b9bb1
(svn r16391) -Codechange: use Train instead of Vehicle where appropriate.
2009-05-22 22:22:46 +00:00
7a37220881
(svn r16390) -Codechange: move u.road to RoadVehicle.
2009-05-22 20:22:20 +00:00
c882248348
(svn r16388) -Codechange: move u.air to Aircraft
2009-05-22 20:07:26 +00:00
441011b782
(svn r16382) -Codechange: make GetVehicleTrackdir a member function of Vehicle.
2009-05-22 18:17:20 +00:00
62a7948af0
(svn r16378) -Codechange: replace OldPool with simpler Pool. Compilation time, binary size and run time (with asserts disabled) should be improved
2009-05-22 15:13:50 +00:00
8808f3beea
(svn r16352) -Codechange: use PoolItem::GetIfValid() instead of PoolItem::IsValidID() and PoolItem::Get()
2009-05-18 16:21:28 +00:00
d1f9a90d32
(svn r16348) -Fix (r16280): buoys with invalid station ID could be left in the game
2009-05-18 00:33:24 +00:00
6b2f9e8c9e
(svn r16328) -Fix: desync when removing lots of stations
2009-05-17 10:19:00 +00:00
871107f529
(svn r16327) -Codechange: replace IsValidPoolItemID(index) by PoolItem::IsValidID(index)
2009-05-17 01:00:56 +00:00
6221d74644
(svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index)
2009-05-16 23:34:14 +00:00
683a6ca039
(svn r16308) -Fix: parameter is invalid when it's equal to length of an array (Yexo)
2009-05-14 23:40:03 +00:00
5f81ba886c
(svn r16297) -Codechange: silence more ICC warnings
2009-05-13 17:39:00 +00:00
552f10bb09
(svn r16268) -Fix (r9876): When callback 2E returns an amount of 0, do not transport 1 unit to the station.
2009-05-10 15:42:59 +00:00
59d45a04d6
(svn r16118) -Change/cleanup: remove the hexadecimal 'in TTD the string had this ID' from 'some' strings and replace the string name with something more sensible.
2009-04-21 23:40:56 +00:00
2ec09d95a1
(svn r16114) -Cleanup: unify some more strings and remove some more unused strings
2009-04-21 20:20:53 +00:00
faa1ec7a5d
(svn r16077) -Cleanup (r14456): Remove some code that is only used for some assertions, that haven't been triggered for a while.
2009-04-18 11:08:10 +00:00
34cc30e7fb
(svn r16057) -Fix [FS#2834] (r16037): division by zero when having an order with only one station that has either middle or near end stop location and where the platform is (significantly) longer than the train.
2009-04-13 22:27:21 +00:00
5790293af6
(svn r16037) -Feature: allow (per order) to let a train stop at the near end, middle or far end of a platform from the point of view of the driver of the train that enters the station.
2009-04-12 14:11:14 +00:00
f99b125c84
(svn r16029) -Fix [FS#2785]: do not give "... Mines" as name to the station of oil rigs, or more general: do not add "... Mines" when the all of the cargoes are part of the liquid, passenger or mail classes.
2009-04-11 17:09:38 +00:00
f16aa9f509
(svn r16025) -Fix [FS#2818]: "build separate station" in the station picker would reuse deleted stations.
2009-04-10 22:47:19 +00:00
7bbdd4f119
(svn r15747) -Fix [FS#2736]: road ownership getting lost when removing a road stop.
2009-03-16 20:45:32 +00:00
b25a4f8231
(svn r15718) -Cleanup: apply some comment coding style on the rest of the sources too
2009-03-15 00:32:18 +00:00
7831346ef8
(svn r15601) -Fix [FS#2615]: bridges/tunnels don't store tram owner making it possible to remove someone's tram tracks.
...
-Feature: allow building road stops on road/tram tracks of competitors.
2009-03-02 22:57:47 +00:00
3fdac6f702
(svn r15588) -Fix: change owner of waypoints and deleted stations when merging companies or when a company benkrupts
2009-02-26 14:07:42 +00:00
c5684e56ec
(svn r15583) -Fix: Do not use TILE_MASK when you do not want to wrap around them map.
2009-02-25 21:29:50 +00:00
d6e8601a62
(svn r15438) -Fix (r15434): MSVC performance warning
2009-02-10 04:23:37 +00:00
d846eef0b6
(svn r15434) -Codechange: bit of type safety for the DC_xxx flags.
2009-02-09 21:20:05 +00:00
c0a8d09ca7
(svn r15428) -Codechange: consistently use colour instead of having both color and colour.
2009-02-09 02:57:15 +00:00
377ce6c5bf
(svn r15410) -Cleanup: get rid of most of the references to the 'patches' except where it's used for backward compatability.
2009-02-08 12:25:13 +00:00
0d3f5e6e74
(svn r15299) -Cleanup: remove many redundant includes
2009-01-31 20:16:06 +00:00
d7971e5e37
(svn r15293) -Feature [FS#2583]: Give a more meaningful message when towns refuse construction of noise-controlled airports
2009-01-29 03:12:31 +00:00
659989af45
(svn r15278) -Fix [FS#2332]: test noise limit of nearest town instead of st->town
2009-01-26 21:09:17 +00:00
792d1bd883
(svn r15073) -Fix (r15067) [FS#2532]: Default copy constructors don't necessarily do what you want. Instead of creating one, we now pass a pointer around as that avoids additional allocations.
2009-01-13 20:43:53 +00:00
02bda12599
(svn r15067) -Fix [FS#2531]: Possible compiler bug, alleviated by using SmallVector instead of using std::set. SmallVector does everything needed anyway.
2009-01-13 18:18:53 +00:00
26e5ccb60d
(svn r15039) -Codechange: fix comments regarding old AI, remove one old AI hack
2009-01-12 19:49:23 +00:00
a3dd7506d3
(svn r15027) -Merge: tomatos and bananas left to be, here is NoAI for all to see.
...
NoAI is an API (a framework) to build your own AIs in. See:
http://wiki.openttd.org/wiki/index.php/AI:Main_Page
With many thanks to:
- glx and Rubidium for their syncing, feedback and hard work
- Yexo for his feedback, patches, and AIs which tested the system very deep
- Morloth for his feedback and patches
- TJIP for hosting a challenge which kept NoAI on track
- All AI authors for testing our AI API, and all other people who helped in one way or another
-Remove: all old AIs and their cheats/hacks
2009-01-12 17:11:45 +00:00
f5cff71284
(svn r14992) -Codechange: Rename 'CheckIfAuthorityAllows' to 'CheckIfAuthorityAllowsNewStation' and unduplicate a tiny bit of code.
2009-01-11 14:26:11 +00:00
0cd41d1dc6
(svn r14958) -Codechange [FS#1923]: when checking for unique names, compare only with manually set names
...
There are situations that aren't solvable (because of different language files), so if the user really wants to have duplicated name, allow him to do so. It solves desyncs between server and clients using different languages. It behaves the same in SP and MP, so users won't see the different behaviour as a bug (and even checking in SP could be worked around by the user).
2009-01-10 15:54:07 +00:00
db546e607f
(svn r14956) -Fix [FS#1832]: building new station parts didn't allocate a new station spec effectively breaking variable 41. This was due to the limited number of station specs that we can have per station. This fix makes newly build station parts create a new spec until one cannot allocate new station specs anymore and it'll revert to the old behaviour (sharing station specs).
2009-01-10 14:30:01 +00:00
1b546505d2
(svn r14955) -Fix: newgrf station specs didn't get deallocated when building a new station part over them.
2009-01-10 14:01:17 +00:00
f0b0691bfe
(svn r14933) -Codechange: check the whether a pool item can be constructed instead of trying to make it and check for NULL.
2009-01-09 14:59:02 +00:00
c8c61e36bd
(svn r14919) -Feature: distant joining of stations (Frostregen and PhilSophus)
2009-01-08 16:35:45 +00:00
9877b71ee0
(svn r14853) -Codechange: rename GetClosestStationFromTile to GetClosestDeletedStation as that's what it does instead of finding non-deleted stations.
2009-01-05 21:06:38 +00:00
7368c740a6
(svn r14828) -Codechange: move most of save/load-specific code to separate files
2009-01-04 15:32:25 +00:00
1357b0a4c2
(svn r14789) -Feature: allow scrolling with the left mouse button pressed (if enabled). Primarily useful for systems with touch screen (aapo)
2009-01-02 22:42:05 +00:00
87e5a8b52b
(svn r14754) -Codechange: get rid of _cmd_text and just pass it as (optional) parameter.
2008-12-28 14:37:19 +00:00
419f6e099f
(svn r14743) -Codechange: use INVALID_TILE to indicate station doesn't have queried facility (or station/roadstop is invalid) instead of 0 (Yexo)
2008-12-26 18:01:15 +00:00
d1ea050232
(svn r14700) -Fix (r1): loading of very old savegames was broken (STNS chunk is stored before MAP in old savegame)
2008-12-20 01:35:12 +00:00
259a073f0c
(svn r14606) -Codechange: Unify usage of PALETTE_MODIFIER_TRANSPARENT and PALETTE_MODIFIER_COLOR in spritelayout drawing.
...
-Fix [FS#2419]: The modifiers were not applied in all cases.
2008-11-22 16:04:11 +00:00
b759ccd032
(svn r14604) -Codechange: Simplify a function and rename it, and fix some comments.
2008-11-22 15:48:43 +00:00
rubidium