9b800a96ed
Codechange: Remove min/max functions in favour of STL variants ( #8502 )
2021-01-08 11:16:18 +01:00
62cdadb582
Change: move "give money" from client-list to company window
...
This is a much better location for this button, as you send
money from one company to another company, not from player
to player.
This is based on work done by JGRPP in:
f820543391https://www.tt-forums.net/viewtopic.php?p=1183311#p1183311
We did modify it to fix several bugs and clean up the code while
here anyway.
The callback was removed, as it meant a modified client could
prevent anyone from seeing money was transfered. The message
is now generated in the command itself, making that impossible.
2021-01-05 21:56:24 +01:00
ba49fa3b82
Codechange: Rename strings to match their usage.
2020-12-25 00:40:35 +01:00
2bb691f50e
Change: Remove the LAN/Internet combobox from the server list in favour of adding two separate search buttons.
2020-12-25 00:40:35 +01:00
d15dc9f40f
Add: support for emscripten (play-OpenTTD-in-the-browser)
...
Emscripten compiles to WASM, which can be loaded via
HTML / JavaScript. This allows you to play OpenTTD inside a
browser.
Co-authored-by: milek7 <me@milek7.pl>
2020-12-15 15:46:39 +01:00
224acb78b0
Fix: Compiler warnings about memsetting non-trivial classes
2020-06-27 14:51:14 +01:00
1ac0d4a5b2
Fix: Thread unsafe use of NetworkAddress::GetAddressAsString
...
Remove static buffer form of NetworkAddress::GetAddressAsString.
This is used in multiple threads concurrently, and is not thread-safe.
Replace it with a form returning std::string.
2020-06-21 11:47:56 +01:00
5880f1479f
Feature #7756 : Allow server to supply a reason to kicked/banned clients
...
This commit adds the missing feature of allowing the server owner to
provide a reason for kicking/banning a client, which the client sees in
a pop-up window after being kicked. The implementation extends the
network protocol by adding a new network action called
NETWORK_ACTION_KICKED that is capable of having an error string, unlike
the other network error packages. Additionally, the kick function
broadcasts a message to all clients about the kicked client and the
reason for the kick.
2020-02-04 22:17:39 +00:00
41232f18c1
Codechange: Replace network related FOR_ALL with range-based for loops
2019-12-21 20:13:03 +01:00
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
04f659e768
Fix: Some typos found using codespell
2019-09-29 21:27:32 +01:00
d5841109f0
Fix dcb2571: Missing override keywords
2019-04-25 17:45:00 +02:00
a64bd6e22c
Fix: Also breaking for warning text in set company password
2019-04-24 17:40:11 +02:00
dcb2571888
Add: Warn players that company passwords are not truly secure
2019-04-24 17:40:11 +02:00
8899272614
Codechange: use std::vector for _language_dropdown
2019-04-18 21:49:34 +02:00
2db88953e7
Codechange: use std::sort() in GUIList
2019-04-13 12:49:18 +01:00
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
e804173595
Codechange: If something is a vector of strings, use a vector of strings instead of an AutoFreeSmallVector.
2019-04-09 22:45:15 +02:00
66dd7c3879
Fix: MSVC warnings ( #7423 )
2019-03-28 00:09:33 +01:00
c01a2e2a81
Codechange: Removed SmallVector completely
2019-03-26 20:15:57 +00:00
ab711e6942
Codechange: Replaced SmallVector::[Begin|End]() with std alternatives
2019-03-26 20:15:57 +00:00
a0f36a50e6
Codechange: Replaced SmallVector::Append() with std::vector::[push|emplace]_back()
2019-03-26 20:15:57 +00:00
a690936ed7
Codechange: Replace SmallVector::Length() with std::vector::size()
2019-03-26 20:15:57 +00:00
9cba6f7193
Codechange: Replaced SmallVector::Compact() with std::vector::shrink_to_fit()
2019-03-26 20:15:57 +00:00
bfd79e59dc
Codechange: Replace SmallVector::Clear() with std::vector::clear()
2019-03-26 20:15:57 +00:00
317f69c152
Codechange: Use override specifier in Window-derived classes.
2019-03-24 16:10:04 +01:00
af7d9020a1
Codechange: Use override specifer for overriding member declarations
...
This is a C++11 feature that allows the compiler to check that a virtual
member declaration overrides a base-class member with the same signature.
Also src/blitter/32bpp_anim_sse4.hpp +38 is no longer erroneously marked
as virtual despite being a template.
2019-03-24 16:10:04 +01:00
e3c639a09f
Remove: ENABLE_NETWORK switch
...
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
2019-03-20 19:24:55 +01:00
7c31a32c2b
Fix: colour of network specific strings in company dropdown menus
2019-02-16 22:19:16 +01:00
5ff0c24993
Fix #6780 : Some windows didn't get updated from OnTick() ( #7048 )
2019-01-12 23:23:23 +00:00
b4b98e5165
(svn r27893) -Codechange: Use fallthrough attribute. (LordAro)
2017-08-13 18:38:42 +00:00
0adfb1ac6f
(svn r27653) -Fix(r27647): Rename FileOperation enum and values to SaveLoadOperation to avoid nameclash with windows compiler toolkit.
2016-09-04 16:06:50 +00:00
88bdf482c0
(svn r27648) -Codechange: Remove remaining _saveload_mode usage.
2016-09-04 12:56:56 +00:00
8084f39bf3
(svn r27577) -Fix [FS#6386]: Dock and roadstop picker, client list and town authority window did not auto-resize according to their content when they were positioned at the bottom of the screen. (Eearslya)
2016-05-22 10:52:02 +00:00
2c9117fbdd
(svn r27421) -Fix [FS#6265]: Consider text and icon sizes when drawing the client list. (_dp_)
2015-10-30 16:19:33 +00:00
fc50ff6531
(svn r27304) -Fix [FS#6321-ish]: Improve password window layout for big font sizes.
2015-06-20 12:30:10 +00:00
0877f892c5
(svn r26960) -Codechange: Draw sort button symbols as sprites, and pad sort buttons with non-static width.
2014-10-05 11:20:02 +00:00
59076ee32b
(svn r26923) -Codechange: Make multiplayer lobby fit to icon size.
2014-09-26 16:05:42 +00:00
5b82822c12
(svn r26486) -Codechange: replace a number of snprintfs with seprintf
2014-04-23 21:12:09 +00:00
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
bdd62a4b3e
(svn r26055) -Codechange: mark switch default as really not triggerable, as technically it's dead code
2013-11-22 21:47:03 +00:00
b911f4a452
(svn r25668) -Codechange: Pass proper Unicode UCS-4 characters instead of just UCS-2 to the window key press handlers.
2013-08-05 20:36:24 +00:00
43ec0bf0c1
(svn r25537) -Codechange: Optionally make WWT_MATRIX compute the number of rows and columns from the resize step size.
2013-06-30 14:36:31 +00:00
df732f2bae
(svn r25534) -Codechange: FinishInitNested calls OnResize, no need to setup scrollbar capacity before that.
2013-06-30 14:34:23 +00:00
98fdd20f84
(svn r25531) -Codechange: Use separate function to set data of WWT_MATRIX widgets.
2013-06-30 14:32:31 +00:00
4e4e635916
(svn r25294) -Feature: Add another button to window title bars to resize the window to its default size.
2013-05-26 19:30:07 +00:00
8157a8afd8
(svn r25290) -Add: Assign string names to notable windows.
2013-05-26 19:25:01 +00:00
56e4a8c4d6
(svn r25287) -Codechange: Keep a reference to the WindowDesc in the Window after construction.
2013-05-26 19:23:42 +00:00
7e4f68d275
(svn r25253) -Codechange: Rename the strings of the advertisement settings to better reflect what they do
2013-05-19 09:07:43 +00:00
579ee7a592
(svn r25089) -Codechange: Move CharSetFilter from QueryString to Textbuf.
2013-03-17 13:04:10 +00:00
3e02890b73
(svn r24983) -Change: Apply the same name sorting rules to content and NewGRF list as for the server list.
2013-02-09 17:31:07 +00:00
b533523258
(svn r24801) -Codechange: Add functions to set integral DParams to suitable values for size computations.
2012-12-08 17:18:51 +00:00
732e073261
(svn r24776) -Doc: Typo fixes, additions, and additional dots collected from various sources (including Eagle_rainbow, MinchinWeb)
2012-12-01 13:12:39 +00:00
4e8f3f7a99
(svn r24770) -Fix-ish: Calling GUIList::Sort repeatedly has no use without GUIList::NeedResort since the latter has the sideeffects.
2012-11-27 21:54:11 +00:00
507de921c2
(svn r24769) -Feature [FS#3852]: Add a string filter to the server list. (Eagle_rainbow)
2012-11-27 21:35:52 +00:00
b884195400
(svn r24768) -Fix: Adjust a comment to reflect some more truth.
2012-11-27 21:30:44 +00:00
9aeeb5acb9
(svn r24767) -Codechange: Remove some fragile hacks from the multiplayer list who tried to disguised themself as optimisations.
2012-11-27 21:21:01 +00:00
f5d8ba5d7f
(svn r24742) -Codechange: Remove QueryStringBaseWindow and store QueryStrings per widget instead.
2012-11-14 22:50:35 +00:00
6e6d94a2d1
(svn r24740) -Codechange: Remove duplicate members from QueryStringBaseWindow and directly use QueryString.
2012-11-14 22:50:26 +00:00
f6d4200f86
(svn r24738) -Codechange: Remove Textbuf::Initialize in favour of a constructor.
2012-11-14 22:50:17 +00:00
f2221e8b89
(svn r24736) -Cleanup: The third parameter of Textbuf::Initialize only makes sense if it is smaller than the second one, also its unit is not pixels.
2012-11-14 22:46:49 +00:00
2c22fe98dd
(svn r24734) -Codechange: Move QueryStringBaseWindow::OnOSKInput to Window::OnEditboxChanged.
2012-11-13 21:47:07 +00:00
c4d7c8dd42
(svn r24733) -Codechange: Move handling of editbox keys to window class.
2012-11-13 21:47:02 +00:00
7699a7dc06
(svn r24732) -Codechange: Unify handling of OK and CANCEL actions for editboxes.
2012-11-13 21:46:58 +00:00
fd55399167
(svn r24731) -Codechange: Remove OnOpenOSKWindow and instead specify OK and CANCEL buttons via QueryString members.
2012-11-13 21:46:54 +00:00
6d1fe626f5
(svn r24729) -Codechange: Unify the handling of HEBR_EDITING.
2012-11-13 21:46:46 +00:00
1071d51508
(svn r24727) -Fix: In various windows the OSK looked shiny but using it had no effect whatsoever.
2012-11-13 21:46:37 +00:00
137adb3496
(svn r24726) -Codechange: Move editbox mouseloop handling to Window class.
2012-11-13 21:46:33 +00:00
2614ed18f9
(svn r24725) -Cleanup: Remove old editbox focus code which is already handled more generally.
2012-11-13 21:46:22 +00:00
17025fa6ea
(svn r24724) -Codechange: Move drawing of editboxes to the widget drawing code.
2012-11-13 21:46:19 +00:00
03736af2ae
(svn r24700) -Cleanup: Remove WDF_UNCLICK_BUTTONS and make it the default.
2012-11-11 16:10:43 +00:00
7e57e8692a
(svn r24335) -Fix: The cursor in the company password window was not blinking due to wrong magic constants (same as r17539).
2012-06-09 14:49:49 +00:00
d58eee1e79
(svn r24324) -Codechange: Turn functions dealing with Textbufs into member functions.
2012-06-04 15:30:29 +00:00
1adb9a5c85
(svn r24070) -Fix [FS#5098]: the 'last joined' server was not properly selected anymore (adf88)
2012-03-25 19:46:59 +00:00
f2f939906e
(svn r24069) -Fix (r24062): crash when not having a valid last joined address
2012-03-25 19:43:17 +00:00
357843378f
(svn r24062) -Fix [FS#5097]: immediately start querying the last joined server instead of waiting for the requery loop (adf88)
2012-03-25 18:17:41 +00:00
446758872c
(svn r23906) -Codechange: replace magic numbers with named constants (adf88)
2012-02-06 20:47:47 +00:00
89ab59f0cb
(svn r23787) -Fix: add some missing spaces
2012-01-11 18:47:32 +00:00
6d6be50ae0
(svn r23740) -Codechange: remove some 300 unneeded includes from the .cpp files
2012-01-03 21:32:51 +00:00
6ed84aff8d
(svn r23710) -Change: make the default secondary sort method for the server list the number of clients instead of the name
2012-01-01 22:35:19 +00:00
9a921fd0ae
(svn r23709) -Feature-ish: try harder to sort text instead of fancy characters in the server names
2012-01-01 22:32:26 +00:00
1a6d352b92
(svn r23692) -Fix: use smallest_x of your children only when you let the children update it
2011-12-31 11:14:03 +00:00
f27b7e2a78
(svn r23691) -Fix: signed/unsigned issues, causing asserts for some languages in relation to the serverlist
2011-12-31 10:55:00 +00:00
561b25d031
(svn r23601) -Fix: fix the conflict in window number
2011-12-19 20:50:21 +00:00
4e4a87bd3c
(svn r23579) -Fix (r23525): Most up/down arrows stopped working.
2011-12-17 20:52:07 +00:00
e2d8abeec5
(svn r23544) -Codechange: document and rename widgets to be consistent and understandable
2011-12-16 18:02:27 +00:00
2aa774e831
(svn r23528) -Codechange: move widget enums to widgets/NNN_type.h
2011-12-15 22:22:55 +00:00
df0afdf0dc
(svn r23525) -Codechange: make Window::flags4 WindowFlags instead of uint16, with only values known in WindowFlags (and move out 2 timers to their own variable)
...
-Codechange: rename Window::flags4 to Window::flags
-Codechange: move some non-inline functions from .hpp to .cpp
2011-12-15 19:54:23 +00:00
b231e80125
(svn r23470) -Codechange: move declaration of SwitchToMode to a header instead of declaring it in 6 other files
2011-12-10 08:31:14 +00:00
dcba6c25ea
(svn r23465) -Feature [FS#4827]: add 'find missing content online' button to 'load savegame' and 'find network game' windows
2011-12-09 21:49:52 +00:00
aa668ba6bd
(svn r23202) -Fix [FS#4829]: unstable sorting in the network list when two servers had the exact same name
2011-11-12 19:26:53 +00:00
50d1541270
(svn r23017) -Codechange: Add support for resized scrollbars.
2011-10-11 08:07:47 +00:00
74f6813a55
(svn r23011) -Fix [FS#4791]: When the last used server is deleted from the list also clear the last used server if it is the same (monoid)
2011-10-07 08:17:47 +00:00
ad232bd497
(svn r22932) -Fix [FS#4766]: disable the white border on window creation for several windows (based on patch by monoid)
2011-09-15 13:26:27 +00:00
36e887591b
(svn r22696) -Fix: don't requery the servers when the server list window isn't opened
2011-07-30 10:44:58 +00:00
5e449b8fae
(svn r22429) -Add: some constants for specific palette colours used in the GUI.
2011-05-06 21:13:29 +00:00
c4aa943aaa
(svn r22424) -Document: some more bits
2011-05-05 16:24:48 +00:00
22286bd7b6
(svn r22421) -Fix: Replace various references to Windows palette greyscale indices with the DOS palette indices.
2011-05-04 17:45:16 +00:00
caf02450fb
(svn r22365) -Codechange: add overload of NetworkServerKickOrBanIP using the ClientID, which later resolves the IP address to ban. This to consolidate the knowledge about resolving IP addresses
2011-04-22 15:59:32 +00:00
bc9a803ea9
(svn r22362) -Codechange: NetworkFindClientInfoFromClientID -> NetworkClientInfo::GetByClientID
2011-04-22 15:54:16 +00:00
393fb8e46b
(svn r22361) -Codechange: delete the client list popup when the client got removed (instead of previously selecting some other client)
2011-04-22 15:53:40 +00:00
2802c742a4
(svn r22360) -Codechange: use globally unique client id to mark the selected client instead of the position in the client list
2011-04-22 15:52:50 +00:00
2f9b6156ee
(svn r22359) -Codechange: pass client info pointers instead of the position to the client popup list's callbacks
2011-04-22 15:51:52 +00:00
835ae31f45
(svn r22358) -Codechange: WC_TOOLBAR_MENU isn't the right name when its only used for client list popups
2011-04-22 15:50:13 +00:00
e2d5ce1b0e
(svn r22357) -Fix (r22345): crash when opening the chat box or company password input box
2011-04-22 15:03:08 +00:00
10caf391a1
(svn r22343) -Change: Remove pixel limiter for query strings.
2011-04-17 18:42:17 +00:00
652c9cb663
(svn r22247) -Codechange: Update comments wrt. ForceRebuild() in command-scope.
2011-03-13 21:34:21 +00:00
ec9540a12a
(svn r22241) -Codechange: Add additional to-be-used parameter to OnInvalidateData().
2011-03-13 21:31:29 +00:00
1a5087be69
(svn r22093) -Fix [FS#4514]: The server list did not get sorted with one item in it, so the "position in the list" variable was never updated causing problems when using the keyboard shortcuts for scrolling
2011-02-17 21:05:44 +00:00
5f7439a00f
(svn r22030) -Cleanup: dead code in NetworkGameWindow::OnInvalidateData (adf88)
2011-02-08 20:52:38 +00:00
62e5afcdf8
(svn r21918) -Fix [FS#4443]: Languages improperly sorted in the "start server" window (adf88)
2011-01-26 22:42:50 +00:00
cc8da3e5ab
(svn r21892) -Fix [FS#4421]: only some scenarios from the main scenario folder and no heightmaps could be started in the "start server" window
2011-01-22 23:07:23 +00:00
795a528328
(svn r21854) -Codechange: refactor the password setting methods to make it possible to change the password of other companies (on the server)
2011-01-19 16:47:40 +00:00
98df56d032
(svn r21390) -Codechange: prepare the network join progress bar for getting the file size later in the download process, i.e. when a chunk of the savegame is already received by the client
2010-12-05 14:32:13 +00:00
75f86a7a21
(svn r21344) -Feature [FS#4214]: Natural sorting of strings using ICU.
2010-11-27 22:52:12 +00:00
f5c6fd1a25
(svn r21331) -Codechange: Make drawing the widgets default behaviour in OnPaint().
2010-11-26 15:22:18 +00:00
30637a8340
(svn r21157) -Codechange: remove information about the text direction out of the language "list"
2010-11-13 09:56:25 +00:00
3972c790c2
(svn r20957) -Codechange: Add another parameter to FindGRFConfig() to define search restrictions.
2010-10-17 12:12:13 +00:00
515edee17c
(svn r20925) -Codechange: make the client send commands have a slightly more sensible name
2010-10-15 14:29:13 +00:00
48767d1bef
(svn r20720) -Add: separate GUI icons for vehicle/company profit, exclusive rights and unread news.
2010-09-02 20:00:48 +00:00
48d8f16653
(svn r20719) -Codechange: Remove some hardcoded iconsizes.
2010-09-02 19:34:44 +00:00
9a05f8004b
(svn r20692) -Fix [FS#4055]: crash after downloading missing content
2010-08-30 10:16:04 +00:00
30f2afac9b
(svn r20632) -Cleanup: remove "a few" unneeded includes, and add them to some headers
2010-08-26 22:01:16 +00:00
9e538acc03
(svn r20461) -Codechange: Replace WWT_HSCROLLBAR, WWT_SCROLLBAR and WWT_SCROLL2BAR with NWID_HSCROLLBAR and NWID_VSCROLLBAR.
2010-08-12 09:16:43 +00:00
71ca58c2bb
(svn r20453) -Codechange: Remove direct accesses to Window::hscroll, vscroll and vscroll2.
...
Note: All windows get individual members with the same names, which are initialised via Window::GetScrollbar(). This caching is not required at all, but simplifies conversion.
2010-08-12 08:37:01 +00:00
10339c60c0
(svn r20452) -Codechange: Remove NWidgetCore::FindScrollbar() and associate scrollbar explicitly using a NWidgetPart via SetScrollbar().
2010-08-12 06:44:45 +00:00
80c43f52e8
(svn r20289) -Codechange: Unify fall through coding style.
2010-08-01 20:52:11 +00:00
4bd32799f1
(svn r20286) -Codechange: Unify end of doxygen comments.
2010-08-01 19:44:49 +00:00
ed4f806f1d
(svn r20283) -Codechange: Unify start of doygen comments.
2010-08-01 19:22:34 +00:00
e356cb9405
(svn r20281) -Codechange: unify case scope closure + break coding style
2010-08-01 18:53:30 +00:00
88ca183191
(svn r20239) -Doc: Give a common name to all fall throughs (FALL THROUGH).
2010-07-29 14:26:28 +00:00
4203e641f8
(svn r20223) -Codechange: Replace scrolled row calculations by a call to GetScrolledRowFromWidget().
2010-07-26 13:08:48 +00:00
22b9bc5157
(svn r20043) -Codechange: Introduce vertical alignment for DrawStringMultiLine().
2010-07-02 13:53:05 +00:00
604e56adc2
(svn r20025) -Doc: Fix/add comments to let Doxygen know about the documentation.
2010-06-27 09:05:10 +00:00
9683b87466
(svn r20012) -Fix: when joining a company with a password you could only enter 20 characters of the password
2010-06-23 00:11:11 +00:00
876eb5ee0b
(svn r19998) -Codechange: Unify the order of ship and plane icon in network-lobby with the rest of the game (frosch)
2010-06-19 16:42:02 +00:00
99a11badaf
(svn r19996) -Codechange: Add NetworkVehicleType enum.
2010-06-19 16:37:56 +00:00
80fd67a314
(svn r19818) -Fix [FS#3784](r16004): kicking clients by IP didn't work
2010-05-13 16:00:50 +00:00
11d6e21c3a
(svn r19607) -Codechange: use different packet types instead of packet subtypes
2010-04-11 17:17:12 +00:00
d2dc3a2e2b
(svn r19606) -Codechange: remove global variable pw_type
2010-04-11 16:38:31 +00:00
a9c8dbc0a0
(svn r19255) -Codechange: encapsulate GRFIdentifier in GRFConfig instead of subclassing it
2010-02-25 20:05:31 +00:00
33a96b5ef3
(svn r19132) -Codechange: No need to end a line with ;;.
2010-02-14 16:31:35 +00:00
0072503496
(svn r19087) -Codechange: some typos in StringIDs
2010-02-10 20:20:18 +00:00
73ed81b1c7
(svn r19075) -Codechange: unhackify NetworkChangeCompanyPassword()
2010-02-10 15:17:27 +00:00
f9cebfcfc4
(svn r18967) -Fix (r18966): Never trust your copy&paste skills.
2010-01-30 18:43:14 +00:00
88019e64e1
(svn r18966) -Codechange: Remove Window::OnDoubleClick() in favour of a parameter for OnClick().
2010-01-30 18:34:48 +00:00
82fc28f77f
(svn r18809) -Codechange/Cleanup: remove unneeded headers from some files, if a header require a header make it include that header
2010-01-15 16:41:15 +00:00
29e05554d7
(svn r18645) -Fix [FS#3433](r942): out-of-bounds access in the 'Start new multiplayer game' GUI
2009-12-27 13:38:08 +00:00
0cb84effc8
(svn r18595) -Fix (r18277): one couldn't enter test via the keyboard in the company password window. Also replace a magic number with a enumified constant.
2009-12-21 20:32:20 +00:00
1d7a75032f
(svn r18589) -Codechange: Add tooltip to some network windows, remove old comment.
2009-12-21 16:28:50 +00:00
Charles Pigott