smatz
77eaefb61c
(svn r16720) -Codechange: make Set/ClearFrontEngine(), Set/ClearArticulatedPart(), Set/ClearWagon(), Set/ClearEngine(), Set/ClearFreeWagon() and Set/ClearMultiheaded() members of Train
2009-07-02 00:17:27 +00:00
smatz
d86e17d65a
(svn r16719) -Codechange: make IsArticulatedPart(), IsTrainEngine(), IsTrainWagon(), IsMultiheaded(), EngineHasArticPart() and IsRearDualheaded() members of Train
2009-07-01 23:57:20 +00:00
smatz
ecfaa0564d
(svn r16718) -Codechange: make IsFreeWagon() member of Train
2009-07-01 23:49:13 +00:00
smatz
adc5363202
(svn r16717) -Codechange: make IsFrontEngine() member of Train
2009-07-01 22:22:01 +00:00
smatz
38477f2b36
(svn r16655) -Codechange: use IsRailwayStationTile() more
2009-06-25 15:54:06 +00:00
smatz
029fb9bdee
(svn r16652) -Codechange: use less strict, but faster check for quickly bailing out in FindTrainCollideEnum() (Bilbo)
...
-Codechange: shuffle the code a bit
2009-06-24 23:59:20 +00:00
smatz
05c695a647
(svn r16646) -Codechange: rename GetDepotByTile() to Depot::GetByTile()
2009-06-24 19:26:41 +00:00
smatz
986cc75a12
(svn r16641) -Codechange: reduce number of multiplications done in FindTrainCollideEnum() to minimum
2009-06-23 23:31:43 +00:00
smatz
192b9bda7b
(svn r16633) -Codechange: remove checks for consistency of newpool
2009-06-23 10:44:46 +00:00
rubidium
512b021e26
(svn r16581) -Codechange: unify the access to Engine::lifelength.
2009-06-16 13:52:18 +00:00
rubidium
4b05617c42
(svn r16580) -Codechange: rename Engine::image_index to original_image_index to not confuse it with image_index from *VehInfo.
2009-06-16 13:31:06 +00:00
smatz
62f120b296
(svn r16571) -Fix [FS#2974](r16322): in some cases, train could be stuck in depot
2009-06-13 10:22:22 +00:00
smatz
5a6bb53894
(svn r16553) -Codechange: don't use TRACK_BIT_WORMHOLE and TRACK_BIT_DEPOT as bitmasks
2009-06-10 16:02:00 +00:00
smatz
1c5ca9822d
(svn r16545) -Cleanup: tunnels have been returning correct SlopeZ since r1
2009-06-09 20:04:46 +00:00
smatz
0c10006907
(svn r16527) -Codechange: use static member functions instead of simple casts when converting Vehicle to specialised vehicle types. Includes safety check
2009-06-06 16:54:22 +00:00
frosch
0d782b0f96
(svn r16498) -Codechange: Remove hardly used HASBITS.
2009-06-01 15:01:54 +00:00
smatz
de25de7a60
(svn r16494) -Codechange: cache train's speed limit caused by curves
2009-06-01 13:14:56 +00:00
alberth
bab70a823d
(svn r16491) -Codechange: Added parentheses around bitwise operators for code style.
2009-06-01 11:43:36 +00:00
frosch
9853c0dc22
(svn r16480) -Fix (r15617): Invalidate newgrf variable caches of more vehicles in more places. Esp. they were only invalidated for trains.
2009-05-31 12:03:14 +00:00
smatz
5a463c8347
(svn r16442) -Codechange: use new Vehicle accessors at more places
2009-05-26 22:45:48 +00:00
smatz
7ee882d03f
(svn r16441) -Codechange: new class SpecializedVehicle used as superclass for all vehicle types
2009-05-26 22:10:13 +00:00
yexo
0d56cfabfa
(svn r16439) -Change: Make the default vehicle servicing settings company-based settings, so in a multiplayer game everyone can change them.
2009-05-26 21:59:49 +00:00
rubidium
984bd3b98d
(svn r16427) -Codechange: replace a few magic numbers with an existing constant and unduplicate a few lines.
2009-05-26 08:53:16 +00:00
rubidium
0d99b6c71c
(svn r16421) -Codechange: do not unnecessarily remove constness or unnecessarily add it.
2009-05-24 20:29:04 +00:00
frosch
a4557c7da4
(svn r16416) -Fix [FS#2912]: Rework deleting of news when referenced vehicles/stations/industries are deleted.
2009-05-24 16:52:42 +00:00
frosch
8109a74c95
(svn r16414) -Change: Make it harder to ignore/close important error messages. Esp. do not close them automatically after some time.
2009-05-24 12:50:58 +00:00
rubidium
86710c5185
(svn r16397) -Codechange: move GetVehicleOrder/GetLastVehicleOrder into Vehicle
2009-05-23 12:27:42 +00:00
rubidium
6237fe1462
(svn r16394) -Codechange: move (NewGRF) cache variables into a separate struct so (some vehicle related) NewGRF cache 'desyncs' can be tested easier.
2009-05-23 09:10:56 +00:00
rubidium
da5661a0c8
(svn r16393) -Codechange: move VehicleRail to Train.
2009-05-22 22:55:41 +00:00
rubidium
c4b627af42
(svn r16392) -Codechange: move some variables (the ones that aren't caches) from VehicleRail to Train
2009-05-22 22:33:05 +00:00
rubidium
80e94b9bb1
(svn r16391) -Codechange: use Train instead of Vehicle where appropriate.
2009-05-22 22:22:46 +00:00
rubidium
6d1c974254
(svn r16384) -Codechange: move u.effect to EffectVehicle
2009-05-22 18:56:25 +00:00
rubidium
441011b782
(svn r16382) -Codechange: make GetVehicleTrackdir a member function of Vehicle.
2009-05-22 18:17:20 +00:00
smatz
62a7948af0
(svn r16378) -Codechange: replace OldPool with simpler Pool. Compilation time, binary size and run time (with asserts disabled) should be improved
2009-05-22 15:13:50 +00:00
smatz
b687ac51ee
(svn r16376) -Codechange: Vehicle::Tick() now returns false if the vehicle was deleted
2009-05-22 13:53:14 +00:00
smatz
8808f3beea
(svn r16352) -Codechange: use PoolItem::GetIfValid() instead of PoolItem::IsValidID() and PoolItem::Get()
2009-05-18 16:21:28 +00:00
smatz
0af27062c4
(svn r16349) -Codechange: rename IsPlainRailTile() to IsPlainRail(), introduce shiny new IsPlainRailTile()
2009-05-18 01:26:23 +00:00
smatz
871107f529
(svn r16327) -Codechange: replace IsValidPoolItemID(index) by PoolItem::IsValidID(index)
2009-05-17 01:00:56 +00:00
smatz
6221d74644
(svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index)
2009-05-16 23:34:14 +00:00
rubidium
8324cfc875
(svn r16322) -Fix [FS#2873]: trains could get stuck in a depot when they wanted to go to the same depot again.
2009-05-16 20:08:49 +00:00
frosch
32ecc48ec8
(svn r16303) -Codechange: Use the question mark as default sprite when creating vehicles, instead of arbitrary sprites not related to the vehicle. (though that also applies to the question mark)
2009-05-13 21:45:56 +00:00
smatz
a1addc1d95
(svn r16302) -Codechange: remove Vehicle::AllocateList
2009-05-13 21:38:23 +00:00
smatz
c0ed9f779b
(svn r16301) -Cleanup: remove unused parameter
2009-05-13 20:30:46 +00:00
frosch
677ea100b3
(svn r16260) -Codechange: Add Vehicle::IncrementOrderIndex() to deduplicate some code.
2009-05-09 13:37:18 +00:00
rubidium
2664f2a2d9
(svn r16242) -Codechange: rework pausing
...
-Fix [FS#2864]: autopause and manual pausing conflict with eachother
-Fix: new game + pause on new game + autopause make the game not unpause on the first join
2009-05-06 15:06:57 +00:00
rubidium
59d45a04d6
(svn r16118) -Change/cleanup: remove the hexadecimal 'in TTD the string had this ID' from 'some' strings and replace the string name with something more sensible.
2009-04-21 23:40:56 +00:00
rubidium
2a2b40461d
(svn r16087) -Fix (r16079): slow trains wouldn't crash into eachother anymore
2009-04-19 04:36:53 +00:00
rubidium
06a8a8ce8d
(svn r16079) -Fix [FS#2824]: insanely fast trains would not stop in time for stations
...
-Fix: insanely fast trains would sometimes 'jump' over waypoints/via stations within a tick, which would cause the order not to be processed causing the train to go in loops until (with luck) it 'hit' the tile
2009-04-18 13:43:05 +00:00
frosch
3086a89ee3
(svn r16075) -Fix (r15792)[FS#2844]: Mixed up TRACK_BIT_X/Y.
2009-04-17 23:16:01 +00:00
rubidium
34cc30e7fb
(svn r16057) -Fix [FS#2834] (r16037): division by zero when having an order with only one station that has either middle or near end stop location and where the platform is (significantly) longer than the train.
2009-04-13 22:27:21 +00:00
rubidium
5790293af6
(svn r16037) -Feature: allow (per order) to let a train stop at the near end, middle or far end of a platform from the point of view of the driver of the train that enters the station.
2009-04-12 14:11:14 +00:00
frosch
ce513b46b7
(svn r15793) -Feature: Allow train vehicles to be shorten to 1/8 length, even if not at the end of the train.
2009-03-21 22:32:51 +00:00
frosch
88a95661a3
(svn r15792) -Codechange: Use a different algorithm for train vehicles to follow the vehicle in front of them.
2009-03-21 22:25:38 +00:00
frosch
d452a0a0ec
(svn r15789) -Codechange: Add DiagdirBetweenTiles() and use it.
2009-03-21 21:43:23 +00:00
rubidium
b25a4f8231
(svn r15718) -Cleanup: apply some comment coding style on the rest of the sources too
2009-03-15 00:32:18 +00:00
frosch
4129b418cc
(svn r15701) -Fix [FS#2595]: Blame NewGRFs returning inconsistent information in purchase-list/after building before users have a chance to blame OpenTTD for incorrectly autorenewing/-replacing.
2009-03-13 21:28:40 +00:00
rubidium
cf21547814
(svn r15677) -Fix [FS#2546]: vehicle images would be determined during the process of moving the vehicle which means that only the (orientation) data for the vehicles in front of it is valid. Now the data for the vehicles behind the vehicle are valid too.
2009-03-11 23:23:08 +00:00
rubidium
655b0ccc2e
(svn r15676) -Codechange: remove the need for BeginVehicleMove and merge VehiclePositionChanged and EndVehicleMove.
2009-03-11 20:43:14 +00:00
rubidium
c0d71b84f9
(svn r15617) -Change [FS#2694]: vehicle variables 40-43 weren't cached (though spec stated they are). Caching these variables can yield a 10+% speed increase when those vehicle variables are queried often.
2009-03-04 23:32:23 +00:00
frosch
d3850e101c
(svn r15541) -Revert (r15399): 'v->cargo_type' is also used in other places, which cannot accept CT_INVALID.
...
-Codechange: Add Engine::GetDefaultCargoType() and Engine::CanCarryCargo() and use them.
-Fix [FS#2617]: When articulated parts have no available default cargo, use the cargo type of the first part for livery selection.
-Change: To decide whether a vehicle is refittable do not test its current capacity for being zero, but always use the 'capacity property'.
Note: The property is used unmodifed without calling CB 15/36. By setting it to a non-zero value and returning zero in the callback vehicles can be refitted to/from zero capacity for e.g. livery effects.
Note: It is intentional that you cannot control refittability by CB 36.
2009-02-21 12:52:41 +00:00
smatz
e1c43f4fac
(svn r15497) -Fix (r15027): when trains crashed, AIEvent was created only for one train
2009-02-16 17:16:58 +00:00
smatz
f65d70476b
(svn r15496) -Codechange: one division less in the train acceleration code
2009-02-16 01:57:55 +00:00
smatz
3072a5d7c2
(svn r15439) -Fix [FS#2626]: call Vehicle::LeaveStation() before reversing overlength loading train (station triggers were missed, PBS reservation could cause crash)
2009-02-10 12:49:12 +00:00
rubidium
d846eef0b6
(svn r15434) -Codechange: bit of type safety for the DC_xxx flags.
2009-02-09 21:20:05 +00:00
rubidium
c0a8d09ca7
(svn r15428) -Codechange: consistently use colour instead of having both color and colour.
2009-02-09 02:57:15 +00:00
frosch
7f198507f7
(svn r15358) -Add [NoAI]: AIEventVehicleCrashed::GetCrashReason()
2009-02-05 17:28:37 +00:00
peter1138
48e6e7d586
(svn r15320) -Codechange: Increase 'realistic' acceleration 'resolution' by one bit by reducing a division and removing a multiplication: 3/4*2 = 0; 3/2 = 1. And a smidgeon less CPU usage, hah.
2009-02-02 21:38:36 +00:00
michi_cc
44016a4d6e
(svn r15313) -Cleanup: Use helper functions we already have and add some documentation.
2009-02-02 01:28:42 +00:00
smatz
0d3f5e6e74
(svn r15299) -Cleanup: remove many redundant includes
2009-01-31 20:16:06 +00:00
glx
fc965a75dc
(svn r15269) -Codechange: reduced indentation in CmdBuildRail*
2009-01-25 15:35:21 +00:00
frosch
ca10c5c6e3
(svn r15268) -Fix: AIEventVehicleLost triggered at every pbs signal independent of the vehicle being lost.
2009-01-25 13:20:13 +00:00
glx
c1cf3934fa
(svn r15263) -Codechange: added Engine::GetCost() to remove some code duplication.
2009-01-25 00:57:03 +00:00
peter1138
3d404c2927
(svn r15236) -Codechange: Rename realistic_acceleration patch option to train_acceleration_model, and change from boolean to value. Don't forget to update your settings.
2009-01-23 20:53:43 +00:00
peter1138
c1622b04ab
(svn r15208) -Codechange: Remove some kind (undocumented, so who really knows) of original attempt to limit maximum tractive effort from 'realistic' acceleration.
2009-01-22 14:34:29 +00:00
peter1138
92b9ff3f96
(svn r15205) -Revert (r7421, partial): Support for MaxTE solves problem in a better way
2009-01-22 09:57:31 +00:00
frosch
2850bf9e00
(svn r15125) -Fix [FS#2544]: Do not try to determine the next order destination, if there are no orders.
2009-01-17 16:25:32 +00:00
smatz
e00cf92f47
(svn r15077) -Codechange: enumify DAYS_IN_YEAR and DAYS_IN_LEAP_YEAR
...
-Change: when computing daily running cost, divide by 365 (instead of 364). Since r12134, the rounding errors don't need this correction anymore
2009-01-13 22:58:03 +00:00
truebrain
a3dd7506d3
(svn r15027) -Merge: tomatos and bananas left to be, here is NoAI for all to see.
...
NoAI is an API (a framework) to build your own AIs in. See:
http://wiki.openttd.org/wiki/index.php/AI:Main_Page
With many thanks to:
- glx and Rubidium for their syncing, feedback and hard work
- Yexo for his feedback, patches, and AIs which tested the system very deep
- Morloth for his feedback and patches
- TJIP for hosting a challenge which kept NoAI on track
- All AI authors for testing our AI API, and all other people who helped in one way or another
-Remove: all old AIs and their cheats/hacks
2009-01-12 17:11:45 +00:00
frosch
2d4c9cda72
(svn r15009) -Fix [FS#2528]: No need to extent the reserved path when the vehicle is still loading.
2009-01-12 14:56:31 +00:00
frosch
5c78d35078
(svn r14994) -Fix [FS#Aali]: Better handling of OT_LOADING and OT_LEAVESTATION in ChooseTrainTrack.
2009-01-11 16:33:03 +00:00
frosch
a6fc079c52
(svn r14993) -Fix (r14957, r14975): Do not reverse the train with OT_LEAVESTATION as that breaks PBS prediction.
2009-01-11 15:39:49 +00:00
frosch
bc786f9e59
(svn r14975) -Fix (r14957): Do not immediatelly move the train when leaving the station and the destination is not yet known.
2009-01-10 17:39:43 +00:00
frosch
07d1c28025
(svn r14957) -Fix [FS#2516]: Do not abort train movement, when we are just about to reach the end of the platform.
2009-01-10 15:27:57 +00:00
rubidium
11da45ee55
(svn r14949) -Cleanup: pointer coding style
2009-01-10 00:31:47 +00:00
rubidium
c08f520acf
(svn r14943) -Cleanup: remove some rogue spaces/replace some rogue tabs with spaces
2009-01-09 22:48:57 +00:00
michi_cc
13f06c812d
(svn r14852) -Feature: Automatic reversing in front of block signals can now be disabled by setting pf.wait_oneway_signal respectively pf.wait_twoway_signal to 255.
2009-01-05 20:29:05 +00:00
michi_cc
c9d25e20f0
(svn r14851) -Fix: A train reversing in a non-PBS block can't be stuck.
2009-01-05 20:29:00 +00:00
michi_cc
f9f9bb9c3c
(svn r14850) -Fix [FS#2503]: Reversing a stuck train that is then not stuck anymore did not always reset the waiting timer.
2009-01-05 20:28:56 +00:00
smatz
67bf6a0998
(svn r14835) -Change: apply the 'warn if train's income is negative' setting to other vehicle types, too
2009-01-04 18:34:23 +00:00
smatz
9a09e5c4a0
(svn r14831) -Codechange: use {VEHICLE} instead of Train/Ship/Road veh/Aircraft/{STRING} {COMMA} in lang files (part by Swallow)
2009-01-04 17:42:46 +00:00
smatz
7368c740a6
(svn r14828) -Codechange: move most of save/load-specific code to separate files
2009-01-04 15:32:25 +00:00
rubidium
ce5304f9a2
(svn r14826) -Fix [FS#2494]: infinite loop in order lookahead when reserving a path (Swallow)
2009-01-04 14:36:19 +00:00
rubidium
0d54db5f9f
(svn r14803) -Codechange: move order list management into it's own class and remove the order count from the savegame as we can easily count that (PhilSophus)
2009-01-03 13:52:06 +00:00
rubidium
d428da5a35
(svn r14801) -Codechange: don't reference Vehicle::num_orders directly but through a method GetNumOrders() (PhilSophus)
2009-01-03 13:20:32 +00:00
rubidium
b3f2f40db7
(svn r14785) -Fix [FS#2132]: vehicle list for station gets closed when station view is closed even when the vehicle list is stickied. Other vehicle lists are not deleted when their 'opening' window gets closed so do the same with the station view.
2009-01-02 20:59:04 +00:00
rubidium
5a6d3a601d
(svn r14779) -Fix (r14747) [FS#2485]: selling an articulated vehicle removed only the first part and not the rest.
2008-12-31 17:52:42 +00:00
rubidium
87e5a8b52b
(svn r14754) -Codechange: get rid of _cmd_text and just pass it as (optional) parameter.
2008-12-28 14:37:19 +00:00
rubidium
3ebe66a5e4
(svn r14748) -Codechange: unduplicate window updating when deleting vehicles.
2008-12-26 21:08:51 +00:00
rubidium
f18043ee21
(svn r14747) -Codechange: remove DeleteVehicleChain in favour of the vehicle destructor as that was already doing the same for a few vehicle types.
2008-12-26 20:45:02 +00:00
smatz
419f6e099f
(svn r14743) -Codechange: use INVALID_TILE to indicate station doesn't have queried facility (or station/roadstop is invalid) instead of 0 (Yexo)
2008-12-26 18:01:15 +00:00