e3c75a30ba
Fix: unused variable warnings
2019-12-21 20:13:03 +01:00
41232f18c1
Codechange: Replace network related FOR_ALL with range-based for loops
2019-12-21 20:13:03 +01:00
13cc8a0cee
Cleanup: Removed SVN headers
2019-11-10 17:59:20 +00:00
7c8e7c6b6e
Codechange: Use null pointer literal instead of the NULL macro
2019-04-10 23:22:20 +02:00
e804173595
Codechange: If something is a vector of strings, use a vector of strings instead of an AutoFreeSmallVector.
2019-04-09 22:45:15 +02:00
ab711e6942
Codechange: Replaced SmallVector::[Begin|End]() with std alternatives
2019-03-26 20:15:57 +00:00
a0f36a50e6
Codechange: Replaced SmallVector::Append() with std::vector::[push|emplace]_back()
2019-03-26 20:15:57 +00:00
a690936ed7
Codechange: Replace SmallVector::Length() with std::vector::size()
2019-03-26 20:15:57 +00:00
07de9d6c3f
Codechange: Use override keyword in networking classes.
2019-03-24 17:38:42 +00:00
e3c639a09f
Remove: ENABLE_NETWORK switch
...
This switch has been a pain for years. Often disabling broke
compilation, as no developer compiles OpenTTD without, neither do
any of our official binaries.
Additionaly, it has grown so hugely in our codebase, that it
clearly shows that the current solution was a poor one. 350+
instances of "#ifdef ENABLE_NETWORK" were in the code, of which
only ~30 in the networking code itself. The rest were all around
the code to do the right thing, from GUI to NewGRF.
A more proper solution would be to stub all the functions, and
make sure the rest of the code can simply assume network is
available. This was also partially done, and most variables were
correct if networking was disabled. Despite that, often the #ifdefs
were still used.
With the recent removal of DOS, there is also no platform anymore
which we support where networking isn't working out-of-the-box.
All in all, it is time to remove the ENABLE_NETWORK switch. No
replacement is planned, but if you feel we really need this option,
we welcome any Pull Request which implements this in a way that
doesn't crawl through the code like this diff shows we used to.
2019-03-20 19:24:55 +01:00
830ed6be61
Fix: Do not mangle tagged revision strings for network revision strings
2019-02-12 21:32:43 +00:00
5f8354f358
Change: Make a shortened network revision string for use in server queries
2019-02-03 18:00:16 +01:00
ff5c05c1b4
(svn r27400) -Fix [FS#6368] (r26449): when a dedicated server was paused with no clients the tick length was increased significantly, making any assumptions about the tick length used further down in the code are not true anymore. One of such assumptions was that one should readvertise every 15 minutes worth of original ticks, but due to the lengthening this timeframe would be more like 45-60 minutes. Now we'll take the operating system's millisecond counter instead
2015-09-19 16:49:46 +00:00
e2f5081f40
(svn r26788) -Add: Desync replay option to skip/replay failed commands
2014-09-07 14:21:16 +00:00
937265d6d6
(svn r26786) -Fix: Also replay failed commands.
2014-09-07 13:36:18 +00:00
e64249446d
(svn r26577) -Fix [FS#6001]: [Network] Client of non-dedicated server was not correctly put into the first company for all state variables
2014-05-11 13:07:36 +00:00
9ed12b0f07
(svn r26509) -Codechange: replace strdup with stredup (the latter ensures the return is not NULL)
2014-04-25 15:40:32 +00:00
5b82822c12
(svn r26486) -Codechange: replace a number of snprintfs with seprintf
2014-04-23 21:12:09 +00:00
0463dbdc9e
(svn r26482) -Codechange: add an include that allows us to undefine/redefine "unsafe" functions to prevent them from being used, and thus having to care about certain aspects of their return values
2014-04-23 20:13:33 +00:00
3e9c10f9e1
(svn r26449) -Add: Allow more sound sleep for dedicated servers when there's nothing to do and nobody paying attention
2014-04-08 20:19:41 +00:00
c40f281545
(svn r25997) -Codechange: make it slightly more clear what ports are coming from where in the debug output when listening
2013-11-14 19:31:10 +00:00
c24374f99c
(svn r24900) -Fix [FS#5389]: Comments with typos (most fixes supplied by Eagle_rainbow)
2013-01-08 22:46:42 +00:00
6c7c02eb14
(svn r23780) -Fix [FS#4963] (r23764): also name the two new errors server-side. As extra, split up one of the errors in 3 errors, to be more specific what goes wrong. As cherry on top, make sure on all sides we can never again forget to add such entries on both sides, by introducing an assert_compile()
2012-01-09 21:22:48 +00:00
531e501b5a
(svn r23751) -Codechange: rename NetworkUDPGameLoop to a more descriptive name, and move the UDP specific bits to network_udp
2012-01-04 22:08:43 +00:00
6d6be50ae0
(svn r23740) -Codechange: remove some 300 unneeded includes from the .cpp files
2012-01-03 21:32:51 +00:00
55de5d336c
(svn r23618) -Add: ScriptGame::Pause, ScriptGame::Unpause, and ScriptGame::GetLandscape (GameScript only)
2011-12-19 20:58:59 +00:00
561b25d031
(svn r23601) -Fix: fix the conflict in window number
2011-12-19 20:50:21 +00:00
2bf0fc3c5c
(svn r23476) -Codechange: use the error queue to replace switch mode error strings, again making it possible to return multiple errors
2011-12-10 15:16:58 +00:00
998bbde49e
(svn r22934) -Fix [FS#4771]: prevent authentication bypass for the admin port when a new game is started
2011-09-15 18:28:39 +00:00
6bb33acc0d
(svn r22738) -Fix [FS#4722] (r21854): Setting company passwords via the GUI on servers (including starting a company with the default password) failed, so no client could join.
2011-08-13 08:32:55 +00:00
36e887591b
(svn r22696) -Fix: don't requery the servers when the server list window isn't opened
2011-07-30 10:44:58 +00:00
c4aa943aaa
(svn r22424) -Document: some more bits
2011-05-05 16:24:48 +00:00
944a5cb7aa
(svn r22423) -Document: some network stuff
2011-05-04 20:24:23 +00:00
2cae0cd54c
(svn r22368) -Codechange: move the IP address field from the ClientInfo to ClientSocket
2011-04-22 16:03:48 +00:00
f1d0c1a746
(svn r22363) -Codechange: NetworkFindClientStateFromClientID -> NetworkClientSocket::GetByClientID
2011-04-22 15:54:42 +00:00
bc9a803ea9
(svn r22362) -Codechange: NetworkFindClientInfoFromClientID -> NetworkClientInfo::GetByClientID
2011-04-22 15:54:16 +00:00
756cc6cf65
(svn r22116) -Codechange: use PoolBase::Clean() at more places
2011-02-19 23:05:47 +00:00
05a846a574
(svn r22032) -Codechange: add some asserts to verify we don't allocate too many NetworkClientSockets/Infos
2011-02-08 21:47:10 +00:00
795a528328
(svn r21854) -Codechange: refactor the password setting methods to make it possible to change the password of other companies (on the server)
2011-01-19 16:47:40 +00:00
e54a1f6721
(svn r21853) -Codechange: HashCurrentCompanyPassword is only used by servers, so move it to network_server.* (dihedral)
2011-01-19 16:37:06 +00:00
e95718bf43
(svn r21852) -Codechange: generalise GenerateCompanyPasswordHash (dihedral)
2011-01-19 16:35:11 +00:00
c9609bbbc2
(svn r21851) -Codechange: rename NetworkClientSetPassword to NetworkClientSetCompanyPassword (dihedral)
2011-01-19 16:32:23 +00:00
a82118f360
(svn r21850) -Codechange: move password hashing to a more general location (dihedral)
2011-01-19 16:30:09 +00:00
b25cf57542
(svn r21701) -Codechange: ConsoleColour = TextColour, so make it that way and remove some unneeded casts
2011-01-03 12:01:41 +00:00
b149fcd127
(svn r21513) -Feature [FS#532]: make the chat message timeout user configurable
2010-12-14 15:00:43 +00:00
e68efb9e71
(svn r21512) -Change/Feature: make the delay of the chat messages timing out unrelated to the number of passed game days, i.e. don't stop aging chat messages when the server is paused
2010-12-14 14:57:51 +00:00
cf61c2f11f
(svn r21412) -Codechange: limit company name by amount of characters, not bytes
2010-12-05 22:24:50 +00:00
b6c2216749
(svn r21358) -Codechange: make some network function names conform to coding style
2010-11-30 13:38:46 +00:00
bb02e30a37
(svn r21308) -Fix [FS#4262] (r20933-ish): crash upon desync
2010-11-23 23:59:24 +00:00
30637a8340
(svn r21157) -Codechange: remove information about the text direction out of the language "list"
2010-11-13 09:56:25 +00:00
f24c91c487
(svn r21030) -Codechange: move ClientStatus into the network server socket class
2010-10-24 20:07:32 +00:00
87edf2524d
(svn r21004) -Fix [FS#3746]: chat/console messages got sometimes messed up due to LTR names in RTL translations and vice-versa
2010-10-21 20:12:48 +00:00
44a03d0478
(svn r20988) -Fix [FS#4167]: no need to send packets and possibly get the connection closed when the next call also tries to send the packets and then closes the connection. Especially if the former frees a structure that the latter assumes to be still there
2010-10-18 10:44:51 +00:00
9a5e272195
(svn r20978) -Fix (r20963): MSVC seems to be complaining more than GCC once again :)
2010-10-17 17:52:12 +00:00
7cc8a363d8
(svn r20966) -Change: enable remote administration sockets (parts by Yexo and dihedral)
2010-10-17 17:35:42 +00:00
234bee0858
(svn r20938) -Codechange: make the code for listening on a socket (more) reusable
2010-10-15 21:56:06 +00:00
f712055002
(svn r20936) -Codechange: make server side packet sending methods class methods
2010-10-15 20:25:07 +00:00
9858d699a3
(svn r20935) -Codechange: only let the server side use a pool of connected sockets
2010-10-15 19:58:56 +00:00
bda26d03b5
(svn r20934) -Codechange: move NetworkGetClientName to the server's socket
2010-10-15 19:35:08 +00:00
f555e6d72e
(svn r20933) -Codechange: move some more client related methods and such to network_client.cpp
2010-10-15 19:33:08 +00:00
76579df240
(svn r20930) -Codechange: simplify the socket handler allocation
2010-10-15 18:45:56 +00:00
7ba07d9573
(svn r20929) -Codechange: make NetworkCloseClient a class method
2010-10-15 18:42:52 +00:00
515edee17c
(svn r20925) -Codechange: make the client send commands have a slightly more sensible name
2010-10-15 14:29:13 +00:00
0ca7e4e82e
(svn r20924) -Codechange: make the game connection packet handling look more like UDP/content packet handling
2010-10-15 13:47:37 +00:00
8eb07d097e
(svn r20923) -Codechange: prepare creating sub-classes of NetworkClientSocket for server and client side
2010-10-15 13:22:00 +00:00
fa6203fdc3
(svn r20678) -Codechange: Remove unused NetworkFindClientInfoFromIndex(), NetworkFindClientInfoFromIP().
2010-08-29 12:37:49 +00:00
a4c6d07edc
(svn r20553) -Feature: allow rate limiting of incoming commands
2010-08-19 08:59:36 +00:00
b594990071
(svn r20549) -Codechange: centralise the handling of the incoming commands (from clients and the server)
2010-08-18 22:40:17 +00:00
e1d35cba6d
(svn r20497) -Fix [FS#3960]: non-dedicated servers failing to load a game caused the introgame to be the server's game causing desyncs when people tried to join
2010-08-15 11:58:20 +00:00
4bd32799f1
(svn r20286) -Codechange: Unify end of doxygen comments.
2010-08-01 19:44:49 +00:00
ed4f806f1d
(svn r20283) -Codechange: Unify start of doygen comments.
2010-08-01 19:22:34 +00:00
e356cb9405
(svn r20281) -Codechange: unify case scope closure + break coding style
2010-08-01 18:53:30 +00:00
be6c058424
(svn r20211) -Codechange: Indented code should have curly braces around it.
2010-07-24 10:14:39 +00:00
52b211f939
(svn r19869) -Fix [FS#3819]: when a connection gets lost and a game with AIs was loaded the client might crash due to the AIs not being loaded while the game loop is executed
2010-05-20 18:54:14 +00:00
d2ed777fa5
(svn r19619) -Fix (r19618): [desync debug] inserting the "join" pause could cause a crash as some command data was not properly initialised
2010-04-13 18:40:47 +00:00
23190b8952
(svn r19617) -Fix [desync debug]: log the sync state only once per day, not multiple times when paused with _date_fract = 0
...
-Change [desync debug]: check the sync state from the command stream and make sure no unknown input is encountered
2010-04-13 17:36:19 +00:00
7f3844d3aa
(svn r19610) -Codechange: rename STATUS_AUTH to STATUS_AUTHORIZED
2010-04-11 17:32:14 +00:00
43015ad79b
(svn r19609) -Fix: do not print 'Connection lost' message for clients who failed to enter correct password
2010-04-11 17:25:44 +00:00
5c7aaf11ba
(svn r19602) -Codechange: add the name of the command to the desync logs
2010-04-11 10:11:26 +00:00
9b7d71699d
(svn r19601) -Fix: make the desync replay parse the "whole" string instead of everything up to the first space; make it log the sync state too
2010-04-11 09:54:44 +00:00
465e3be105
(svn r19593) -Codechange: improve loading/executing the desync logs
2010-04-09 17:08:44 +00:00
d8baa1342c
(svn r19589) -Change: add some more useful information to the desync log and unify the formatting
2010-04-08 21:14:49 +00:00
53aaabe6e9
(svn r19507) -Codechange: remove semicolon after DECLARE_POSTFIX_INCREMENT and DECLARE_ENUM_AS_BIT_SET
2010-03-23 22:25:43 +00:00
3c40fe42d4
(svn r19374) -Change: Update documentation for console command connect to use ip:port#company parameter format, in line with command line help.
2010-03-08 11:51:23 +00:00
33a96b5ef3
(svn r19132) -Codechange: No need to end a line with ;;.
2010-02-14 16:31:35 +00:00
ab35d95b5a
(svn r19072) -Fix [FS#3599]: possible read/write after free when the client triggered the server to close the connection
2010-02-09 23:49:19 +00:00
2db44fc18e
(svn r18994) -Change: content mirroring support (based on work by TrueBrain).
2010-02-03 18:42:23 +00:00
f608ad7baf
(svn r18875) -Codechange: remove some unneeded bits from the network protocol and improve the naming of some variables
2010-01-21 11:17:40 +00:00
82fc28f77f
(svn r18809) -Codechange/Cleanup: remove unneeded headers from some files, if a header require a header make it include that header
2010-01-15 16:41:15 +00:00
f89d6bea0e
(svn r18801) -Fix: in some cases error messages weren't properly sent to the client before closing the connection. As a result the client would say 'connection lost' when the cause was something completely different.
2010-01-14 21:48:42 +00:00
b00a5f1069
(svn r18330) -Cleanup: remove some unneeded includes
2009-11-28 20:35:25 +00:00
b0f18a27fb
(svn r18054) -Change/Fix [FS#3310]: make pause on join pause during the whole joining (including download) phase
2009-11-12 20:52:14 +00:00
2a1cab4d46
(svn r18052) -Codechange/Fix: make the 'pause' chat message when actually executing the pause command. This to prevent showing paused and especially unpaused to be shown when the state doesn't change. Output now mentions whether pause changes keep the game paused and what reasons for pausing there 'currently' are.
2009-11-12 20:33:30 +00:00
934e6a295d
(svn r18051) -Codechange: make the active clients pause use a separate bit in the pause mode
2009-11-12 17:46:04 +00:00
c08c10f329
(svn r18048) -Change: make no distinction between unpausing because of a client aborting to join or actually joining
2009-11-12 17:27:24 +00:00
c2221885f4
(svn r18027) -Codechange: make some unneededly global variables static and remove some unused variables
2009-11-09 09:59:35 +00:00
58a36f038b
(svn r17737) -Codechange: remove the chat window when you were chatting with someone who lost his/her connection or when you were team chatting and moved out of the company.
2009-10-07 17:36:33 +00:00
d6cded5380
(svn r17693) -Cleanup: remove some unneeded includes
2009-10-04 17:16:41 +00:00
afed4330da
(svn r17685) -Fix: autounpausing kept trying to unpause a loaded game that was paused due to an error. Just reject such savegames in dedicated servers.
2009-10-03 14:48:12 +00:00
124e543b1d
(svn r17667) -Fix [FS#3245]: autopause tried to (un)pause the server every tick when the pause command only gets processed once every frame_freq ticks. So it would spam the console with duplicate attempts.
2009-09-30 13:32:39 +00:00
b3c5c8cadb
(svn r17618) -Fix [FS#3226]: the 'lock' icon would erroneously be drawn for companies if the company had a password before the reset
2009-09-22 21:14:31 +00:00
ebd916be3d
(svn r17532) -Codechange: Rename several Invalidate functions to SetDirty for more consistency and distinguishability.
2009-09-13 19:15:59 +00:00
bd9670ea47
(svn r17467) -Change: show the client id in join messages at the server (patch by dihedral)
2009-09-07 21:28:16 +00:00
7fbc33dae1
(svn r17248) -Fix: add GPL license notice where appropriate
2009-08-21 20:21:05 +00:00
60a3bc9034
(svn r17247) -Change: move '3rd party' MD5 implementation also to the 3rdparty directory.
2009-08-21 20:15:17 +00:00
1fe3ad3288
(svn r17075) -Codechange: rename ~750 strings to be more uniform with their relatives
2009-08-05 17:59:21 +00:00
9b156c1bd4
(svn r16601) -Fix [FS#2880]: try 2... hopefully better this time
2009-06-19 20:26:18 +00:00
f8bccce555
(svn r16573) -Fix: [Network] Always send the starting date from the game you're currently playing instead the starting date from the config file.
2009-06-13 12:06:31 +00:00
35635c6248
(svn r16555) -Feature [FS#570]: ability to enter server and company password via command line when joining a server (based on patch by Progman, Ammler and planetmaker)
2009-06-10 19:00:34 +00:00
2b4d37de3d
(svn r16506) -Fix: count only active clients (not those waiting for map download) when checking min_active_clients limit
2009-06-02 19:56:23 +00:00
bab70a823d
(svn r16491) -Codechange: Added parentheses around bitwise operators for code style.
2009-06-01 11:43:36 +00:00
62a7948af0
(svn r16378) -Codechange: replace OldPool with simpler Pool. Compilation time, binary size and run time (with asserts disabled) should be improved
2009-05-22 15:13:50 +00:00
9f4d64bda0
(svn r16360) -Codechange: don't use _network_playas as a 'second' _local_company, but only as a storage location for the company you want to join in MP.
2009-05-19 21:20:14 +00:00
8808f3beea
(svn r16352) -Codechange: use PoolItem::GetIfValid() instead of PoolItem::IsValidID() and PoolItem::Get()
2009-05-18 16:21:28 +00:00
871107f529
(svn r16327) -Codechange: replace IsValidPoolItemID(index) by PoolItem::IsValidID(index)
2009-05-17 01:00:56 +00:00
6221d74644
(svn r16325) -Codechange: replace GetPoolItem(index) by PoolItem::Get(index)
2009-05-16 23:34:14 +00:00
101af1f9b5
(svn r16250) -Fix (r16242): do not try to unpause when paused for a joining company
2009-05-07 17:08:41 +00:00
2664f2a2d9
(svn r16242) -Codechange: rework pausing
...
-Fix [FS#2864]: autopause and manual pausing conflict with eachother
-Fix: new game + pause on new game + autopause make the game not unpause on the first join
2009-05-06 15:06:57 +00:00
169a003e9a
(svn r16135) -Fix [FS#2856]: always give the server an already resolved 'client address' so we can be sure the client address is always resolved
2009-04-24 10:52:51 +00:00
2663ad302f
(svn r16022) -Fix (r15159): sometimes the unregister "query" thread could be delayed so much that the network stuff was already closed and the packet would never reach the master server causing the server to appear online longer than necessary.
2009-04-10 20:18:48 +00:00
7d3db3ee91
(svn r16014) -Feature(-ish): allow binding to several IPs; [network]:server_bind_ip doesn't exist anymore. Add the IPs/hostnames to [server_bind_addresses]
2009-04-10 12:56:55 +00:00
ebe0f9e7f7
(svn r15998) -Codechange: some coding style updates
2009-04-09 01:16:15 +00:00
e779c56e31
(svn r15989) -Fix (r15987: segfault due to uninitialised sockets.
2009-04-08 21:03:00 +00:00
08e37a6f10
(svn r15987) -Fix: make the master socket only listen on the IP the server is bound to.
2009-04-08 19:36:51 +00:00
9d6edae94d
(svn r15981) -Fix: don't print the address family when writing the IP+port to the config file.
2009-04-08 12:09:07 +00:00
a5a424ce28
(svn r15978) -Codechange: support parsing [] enclosed IPv6 addresses.
2009-04-08 01:22:57 +00:00
8cf88876ef
(svn r15973) -Codechange: make it possible to listen on multiple TCP sockets
2009-04-08 00:05:16 +00:00
c0f8214218
(svn r15972) -Codechange: remove unneeded parameter
2009-04-08 00:03:05 +00:00
2a6e9288fd
(svn r15971) -Codechange: make it possible for UDP socket handlers to bind to multiple sockets.
2009-04-07 20:27:13 +00:00
82f8badc07
(svn r15969) -Codechange: make the list of broadcast addresses virtually unlimited.
2009-04-07 19:06:36 +00:00
22d9306889
(svn r15967) -Codechange: do not access NetworkSocketHandler::has_quit directly
2009-04-07 18:23:14 +00:00
c9ebf14ba5
(svn r15947) -Codechange: replace uint32 client_ip with NetworkAddress client_address.
2009-04-04 00:48:48 +00:00
2fd9f0fffa
(svn r15946) -Codechange: move netmask matching to NetworkAddress and add some support for IPv6 netmask matching.
2009-04-04 00:47:08 +00:00
1463b00b48
(svn r15940) -Codechange: move setting reuse address to the binding process.
2009-04-03 17:02:29 +00:00
5386fe1a1c
(svn r15932) -Codechange: show ip:port as (fallback) servername instead of only the ip. This way you can clearly see there aren't any duplicates.
2009-04-03 12:54:38 +00:00
89d0eca6b7
(svn r15931) -Codechange: let the host and ban lists use of SmallVector.
2009-04-03 12:49:58 +00:00
11723c40b2
(svn r15926) -Codechange: make the broadcast IP list less AF dependent.
2009-04-03 11:02:41 +00:00
47602d7b60
(svn r15925) -Codechange: remove _network_server_bind_ip as it's pretty AF dependant.
2009-04-03 10:29:56 +00:00
632d74c6b1
(svn r15922) -Codechange: unify the ways to listen on a socket
2009-04-03 01:24:52 +00:00
ba5aafb9bb
(svn r15921) -Fix: some OSes don't like sizeof(sockaddr_storage) but want sizeof(sockaddr) or whatever is 'valid' for the given protocol
2009-04-03 00:33:00 +00:00
beef5da970
(svn r15918) -Fix (r15917): comparing IPs sometimes failed due to 'random' data (as spotted by SpComb)
2009-04-02 23:03:18 +00:00
c5160c7c8e
(svn r15917) -Codechange: remove the latest traces of NetworkAddress::GetIP.
2009-04-02 20:39:30 +00:00
1e205e01b8
(svn r15916) -Codechange: let the network game list use NetworkAddress
2009-04-02 20:17:46 +00:00
ee4a660b0c
(svn r15773) -Fix [FS#2475]: number of active clients wasn't always properly
2009-03-19 23:32:39 +00:00
b25a4f8231
(svn r15718) -Cleanup: apply some comment coding style on the rest of the sources too
2009-03-15 00:32:18 +00:00
4a5c4f6089
(svn r15644) -Fix [FS#2710]: closing a network connection twice in the case that sending packets starts failing while disconnecting
2009-03-08 16:14:14 +00:00
642dc1ea5e
(svn r15640) -Fix [FS#2712]: game crashes when network pools are empty, so always allocate at least one pool block
2009-03-07 22:40:47 +00:00
66a8c0a132
(svn r15577) -Codechange: bool _networking belongs in network/ not gfx.cpp
2009-02-25 00:48:04 +00:00
c5677da94d
(svn r15529) -Fix [FS#2644]: the local command queue didn't get properly cleaned when leaving a game meaning you could end up executing commands of the previous network game.
2009-02-20 00:03:29 +00:00
8dae160d0f
(svn r15425) -Codechange: some color->colour changes and type safety.
2009-02-09 02:09:47 +00:00
glx