08814d50ea
(svn r13088) -Codechange: use SigSegState enum instead of bool variable (michi_cc)
2008-05-14 16:38:53 +00:00
eb112946a7
(svn r13074) -Fix: For multiheaded engines, halve power and running cost when used instead of when loading, to allow callback values to work properly.
2008-05-13 20:39:57 +00:00
e6c944a6c4
(svn r12975) -Codechange: replace DeleteWindow(w) with delete w.
2008-05-06 21:28:30 +00:00
d03994098b
(svn r12971) -Documentation: add @file in files that missed them and add something more than whitespace as description of files that don't have a description.
2008-05-06 15:11:33 +00:00
a00371c8db
(svn r12924) -Feature: Introducing the so called 'engine pool' which primarily removes the fixed engine type limits and also happens to allow (with the patch option 'dynamic_engines') multiple NewGRF vehicle sets to coexist.
2008-04-29 21:31:29 +00:00
60eb3c034f
(svn r12860) -Fix [FS#1947]: Train depart animation trigger was not called in some cases.
2008-04-24 07:44:21 +00:00
10ab24a5f1
(svn r12856) -Fix: Taking r12377 further, ensure that prop 25 is set for all vehicles in the consist before other properties.
2008-04-23 21:55:24 +00:00
5dcd689f56
(svn r12824) -Codechange: Standardise routines for drawing vehicle images, using correct types and less duplication.
2008-04-21 20:50:58 +00:00
5ef8c01ce7
(svn r12819) -Codechange: handle more NewGRFs in the same way as TTDP does it, i.e. testing the low bits for 0xFF or 0 instead of all bits.
2008-04-21 14:33:33 +00:00
22140d82c6
(svn r12818) -Codechange: make callbacks 31 and 37 behave like they do in TTDP according to frosch's survey.
2008-04-21 13:45:03 +00:00
b139756e2b
(svn r12804) -Codechange: move the effect vehicle handling out of vehicle.cpp
2008-04-20 11:12:07 +00:00
f55ffd14bd
(svn r12803) -Cleanup: rename SpecialVehicle to EffectVehicle to have a uniform naming of the thing instead of using both names for the same thing.
2008-04-20 10:13:54 +00:00
210d757499
(svn r12798) -Feature: Add some support for NewGRF station animation. (Thanks to mart3p for samples and fixes)
2008-04-19 23:19:12 +00:00
0e624275ee
(svn r12795) -Fix [FS#1938]: vehicles could break down during loading and keep loading. The intention of the break down code is not to break down when having zero speed, therefor break downs now do not happen when loading.
2008-04-19 21:23:42 +00:00
9d8fa486af
(svn r12761) -Codechange: lots of minor whitespace coding style fixes around operators.
2008-04-18 04:37:06 +00:00
02cdf01507
(svn r12754) -Codechange: split depot.h into depot_map.h, depot_func.h and depot_base.h and remove quite a lot of unneeded (before this) includes of depot.h.
2008-04-17 19:10:30 +00:00
059e94e355
(svn r12753) -Codechange: do not use IsDepotTypeTile() where simpler function can be used
2008-04-17 18:24:45 +00:00
9488db56d4
(svn r12745) -Codechange: a bit of naming conventions, introduce Is*DepotTile()
2008-04-17 00:44:20 +00:00
3a84a74f4d
(svn r12711) -Codechange: remove unneeded loops
2008-04-14 20:48:17 +00:00
14b307a621
(svn r12698) -Codechange: skip orders to stations that do not have a train part anymore, just like is done for road vehicles and ships.
2008-04-14 07:08:43 +00:00
570519d79b
(svn r12658) -Codechange: unify a vast portion of the CmdSend<VehicleType>ToDepot commands.
2008-04-11 08:40:10 +00:00
62bdc381e7
(svn r12657) -Codechange: add 'FindClosestDepot' to the vehicle class.
2008-04-11 08:14:43 +00:00
96700d5605
(svn r12629) -Codechange: Split VehicleNeedsService() into Vehicle::NeedsServicing() and Vehicle::NeedsAutomaticServicing().
...
-Fix (r11052): Disable servicing by service-interval if a vehicle has depot orders.
2008-04-08 15:48:32 +00:00
f1cd7ef5ee
(svn r12615) -Codechange: rename some enums related to depot orders to make it more clear that they are no loading/unloading flags. Also add more type strictness.
2008-04-07 19:18:56 +00:00
ac389e16d2
(svn r12605) -Cleanup: variable scope and coding style in train*
2008-04-07 12:36:50 +00:00
fb1c4eccd8
(svn r12593) -Codechange: hide Order's flags in most of the code.
2008-04-06 15:09:45 +00:00
d6623cf654
(svn r12588) -Codechange: do not access the destination of an order directly.
2008-04-06 07:48:51 +00:00
5b47f81b0f
(svn r12584) -Codechange: do not access the order type directly.
2008-04-05 23:36:54 +00:00
aef20ec54d
(svn r12580) -Codechange: merge some logical related to non-stop orders.
2008-04-05 15:30:15 +00:00
5eb5889954
(svn r12578) -Codechange: merge the aircrafts ProcessOrder too into the 'unified' ProcessOrder.
2008-04-05 12:01:34 +00:00
bdd64495cd
(svn r12575) -Codechange: unduplicate Process*Orders for trains, ships and road vehicles.
2008-04-05 10:55:50 +00:00
549d05dc4d
(svn r12532) -Cleanup: Replace two tables of magic values with already existing functions.
2008-04-01 14:47:57 +00:00
15a9fba867
(svn r12531) -Codechange: Rename some variables for consistency.
2008-04-01 14:03:20 +00:00
ef2be7d0fc
(svn r12490) -Codechange: rename engine.h to engine_func.h and remove unneeded inclusions of engine.h and/or replace them with engine_type.h.
2008-03-31 00:17:39 +00:00
2edd403656
(svn r12489) -Codechange: split station.h into station_base.h and station_func.h.
2008-03-31 00:06:17 +00:00
4a1035ab95
(svn r12488) -Codechange: split order.h into order_base.h and order_func.h.
2008-03-30 23:24:18 +00:00
a81a572434
(svn r12482) -Fix: [build train] we don't need to have a depot in order to just check the price of a rail vehicle so don't check for compatible rails on the tile either
...
also wagons will only need tracks they can drive on in order to be build so there is no reason to check for power in the depot
2008-03-28 22:59:43 +00:00
eeabab4555
(svn r12459) -Codechange: split news.h into news_type.h and news_func.h.
2008-03-28 08:53:36 +00:00
ac4ec8c2d2
(svn r12386) -Fix [FS#1841](r2428): train could break apart when reversed while partially in a depot
2008-03-19 20:50:19 +00:00
031c9da01c
(svn r12384) -Fix (r2428): do not disconnect train when reversing, it may 'think' it is whole in a depot
2008-03-19 20:42:05 +00:00
985dbaa093
(svn r12380) -Fix: update train acceleration and max speed after setting cached value to ensure the correct max speed is used with disabled real acceleration
2008-03-17 22:13:00 +00:00
fbf70d53ec
(svn r12379) -Codechange: removed now redondant InvalidateWindow() calls
2008-03-17 22:04:15 +00:00
2b86efea74
(svn r12378) -Fix: refresh vehicle details window when cached values are updated
2008-03-17 21:50:53 +00:00
e2ec1e7032
(svn r12377) -Fix [FS#1854]: set cached value for vehicle property 25 before other cached values
2008-03-17 21:49:14 +00:00
89e9bbfa98
(svn r12369) -Fix (r1681): reset train speed limits when _patches.realistic_acceleration changes
2008-03-15 19:24:13 +00:00
bfae49aeb2
(svn r12368) -Codechange: use explicit body for loops and conditions and remove -Wno-empty-body from the configure script
2008-03-15 13:21:31 +00:00
6bb37edfb6
(svn r12332) -Fix (r12331): Invalidate cached data and update image after setting flag.
2008-03-03 21:42:37 +00:00
b64f637c72
(svn r12331) -Feature: [NewGRF] vehicle variable FE bit 8
2008-03-03 20:56:30 +00:00
dda6cab17a
(svn r12209) -Fix: [NewGRF] Support using any base price for rail and road vehicles' running cost, and show running cost of wagons if they have it.
2008-02-21 19:09:10 +00:00
79b6b9cb66
(svn r12205) -Codechange: rename RailVehicleInfo::running_cost_base to running_cost, inline with other vehicle types (It is the factor, not the base)
2008-02-20 20:56:54 +00:00
1e74834441
(svn r12203) -Fix (r12199): Make trains pay attention to signals again.
2008-02-20 19:37:46 +00:00
b7993793c8
(svn r12199) -Codechange: Remove magic around the results of GetTileTrackStatus().
2008-02-20 17:49:50 +00:00
a190606f2e
(svn r12197) -Fix [FS#1788](r12134): show correct last year profit when the train had negative income
...
-Codechange: use GetDisplayProfitThisYear() to convert vehicle profit to readable form
2008-02-20 17:06:58 +00:00
73a6525129
(svn r12194) -Codechange: apply coding style on enum TrainSubtype
2008-02-20 15:18:35 +00:00
169ac7c91d
(svn r12189) -Codechange: mark some functions in train_cmd.cpp inline (called once or very short)
2008-02-20 12:07:22 +00:00
595d9357c3
(svn r12188) -Codechange [FS#1782]: do not check twice for correct rail owner (patch by Vikthor)
2008-02-20 11:00:17 +00:00
509b3a3247
(svn r12179) -Codechange: use GetCrossingRailTrack() and GetCrossingRailAxis() to improve code readability
2008-02-18 18:35:36 +00:00
c7a8080c3a
(svn r12178) -Codechange: use the 'side' parameter in TrainController and TrainCheckIfLineEnds to simplify the code
2008-02-18 16:35:38 +00:00
a0ddc43e92
(svn r12134) -Change: count the number of ticks a vehicle was running this day to calculate running cost
...
-Fix [FS#1739]: vehicle profit is now counted with 8bit fract, so it is now shown properly in the vehicle details window
2008-02-13 19:24:40 +00:00
fd51465c8b
(svn r12132) -Cleanup: convert pathfinder selection from if/else to switch/case at many places
2008-02-13 17:54:11 +00:00
480036254b
(svn r12131) -Fix (r3374): with mammoth trains disabled, maximum train length was limited to 9
2008-02-13 16:49:25 +00:00
507728f46b
(svn r12129) -Change [FS#1759]: simplified patch settings for pathfinders (Yorick)
2008-02-13 14:21:36 +00:00
df7327b453
(svn r12128) -Codechange: Replace last use of TrainPlayLeaveStationSound(v) with v->PlayLeaveStationSound(), and remove wrapper function.
2008-02-13 09:34:56 +00:00
7b9efcea21
(svn r12085) -Fix(r12058): Road vehicles could get stuck, when NPF told them to reverse on junction tiles. (spotted by SmatZ)
2008-02-08 16:25:55 +00:00
62b3520e51
(svn r12066) -Codechange: Rename GetBridge for the more common GetBridgeSpec
...
-Codechange: Remove direct access to the _bridge table in favor of the above mentioned GetBridgeSpec
-Codechange: Rationalize the use of Bridge type pointer
2008-02-05 05:21:02 +00:00
04ef38ec60
(svn r12057) -Fix: slowdown train when approaching 90deg turn when 90deg turns are forbidden
2008-02-04 15:56:39 +00:00
525409b0fc
(svn r12037) -Codechange: replace OnNewDay_(Aircraft|RoadVeh|Ship|Train) with an OnNewDay method in the Vehicle class
2008-02-01 22:02:14 +00:00
c8ba8d930b
(svn r11996) -Fix [FS#1706]: update train statusbar when stopping from zero speed
2008-01-27 20:20:53 +00:00
0b888ccc00
(svn r11960) -Cleanup: simplify some IsTunnel(Tile) / IsBridge(Tile) conditions
2008-01-23 14:51:36 +00:00
730dda867b
(svn r11922) -Codechange: use MaybeBarCrossingWithSound() to bar crossing with sound
2008-01-18 21:44:20 +00:00
1d59439166
(svn r11916) -Codechange: use enums from VehicleViewWindowWidgets instead of constants
...
-Fix: refit button widget was not correctly updated
2008-01-18 13:02:47 +00:00
8d077b16d8
(svn r11910) -Fix: play 'ding-ding' crossing sound in more cases (except gameload and crossing construction)
...
-Fix: crossing sound is bound to tile, not to vehicle
2008-01-17 20:41:33 +00:00
822242f411
(svn r11908) -Fix: update crossing when merging a company, when building a crossing and after loading older savegame
2008-01-17 19:49:06 +00:00
c74cf439fa
(svn r11900) -Fix: set correctly crossing state after train reversal, train leaving crossing, train crash
...
Fixes several ways to leave crossing red forever or to leave it unbarred when there is a train on crossing
2008-01-17 17:57:39 +00:00
ac7bc24b0e
(svn r11882) -Codechange: introduce MarkSingleVehicleDirty() and simplify the code at some places
2008-01-16 21:17:31 +00:00
692fbb3c05
(svn r11877) -Fix: another way to crash competitors' train in a station
...
-Codechange: increase the speed train is approaching line end/semaphore in non-diagonal direction a bit
2008-01-16 15:48:36 +00:00
40a7ace4fa
(svn r11870) -Fix: slow down train when approaching tile we can't enter in more cases
...
(tunnel/bridge/depot from wrong direction, competitor's track, wrong railtype)
-Fix: do not make crossing red when we can't enter it in any case
2008-01-16 00:33:28 +00:00
576f8ad93e
(svn r11866) -Codechange: swap OFB_* and OF_* so it conceptually in sync with other cases of *B_* vs *_* like VETSB_* and VETS_*.
2008-01-15 18:44:22 +00:00
245f05a7cc
(svn r11864) -Codechange: pass owner whose signals we will update instead of complex detection later
2008-01-15 15:00:01 +00:00
7beb63a93b
(svn r11847) -Fix: do not affect the speed a train is entering a depot by trackbits behind it
2008-01-14 14:46:09 +00:00
bfc4d80c8e
(svn r11845) -Codechange: simplify train collision detection a bit
2008-01-13 23:53:33 +00:00
8da51e5eb2
(svn r11835) -Fix: mark depot, viewports, vehicle lists and vehicle details dirty when a train crashes
2008-01-13 14:42:28 +00:00
dc87b05e8c
(svn r11834) -Codechange: only include settings_type.h if needed.
2008-01-13 14:37:30 +00:00
b0c34f4d62
(svn r11831) -Fix: call TrainConsistChanged() when removing crashed train part to be consistent with saveload process
2008-01-13 13:11:59 +00:00
d4e6a6bf57
(svn r11828) -Codechange: include table/* as the last includes and remove an unneeded include from openttd.h.
2008-01-13 01:21:35 +00:00
ab8382c0db
(svn r11822) -Codechange: Replaced fixed size custom name array. Names are now attached to their object directly and there is
...
no limit to the amount of names.
-Fix: NewGRF engines could not be renamed.
2008-01-12 19:58:06 +00:00
a222fe2e86
(svn r11821) -Fix (r11802): 'optimization assert' when removing crashed wagon in some cases
2008-01-12 19:33:25 +00:00
704a75871a
(svn r11820) -Fix: invalidate depot window when removing crashed train
2008-01-12 19:24:58 +00:00
712d4b6259
(svn r11819) -Fix: do not access the Vehicle struct that has been already deleted when removing crashed train
2008-01-12 19:20:44 +00:00
ac528411df
(svn r11818) -Codechange: split player.h into smaller pieces.
2008-01-12 14:10:35 +00:00
4d04077156
(svn r11812) -Codechange: introduce TrainExitDir() to simplify some functions
2008-01-11 15:10:59 +00:00
f44a9a5d5b
(svn r11802) -Fix [FS#716]: do not crash trains when leaving depot to a very long track
...
-Codechange: use dedicated pathfinder for signal updating, resulting in better performance and possible future improvements
2008-01-09 23:00:59 +00:00
998d7644f6
(svn r11800) -Codechange: move some functions to a more logical location + some type safety.
2008-01-09 21:05:03 +00:00
46650c54b6
(svn r11793) -Codechange: pass the expense type via the CommandCost instead of a global variable. Patch by Noldo (FS#1114).
2008-01-09 16:55:48 +00:00
a01fc4c142
(svn r11789) -Codechange: coding style for global variable names
2008-01-09 10:15:20 +00:00
0e517fe023
(svn r11787) -Codechange: more header rewrites. This time related to viewport.h.
2008-01-09 09:45:45 +00:00
a8a3a7e3f2
(svn r11775) -Codechange: move all autoreplace/autorenew functions to a single location.
2008-01-07 09:19:53 +00:00
b0ac283aec
(svn r11774) -Change: do not include variables.h in a header when it is not needed.
2008-01-07 00:57:19 +00:00
7302d8c88b
(svn r11760) -Codechange: unify the way how other end of a tunnel/bridge is determined at some places
...
-Fix: adding road/tram to tram/road bridge was cheaper by one tile
2008-01-04 19:45:29 +00:00
47082fec5c
(svn r11741) -Feature: Add support for NewGRF's train 'tilt' flag. Trains with tilt capability (specific details are per NewGRF set) will be given a 20% speed limit bonus on curves.
2008-01-01 22:24:18 +00:00
47d23eb003
(svn r11738) -Codechange: Refactor realistic acceleration's curve counting to use DirDiffs instead of local tables, and remove an unnecessary loop.
2008-01-01 18:12:17 +00:00
a8611311ac
(svn r11733) -Fix: Max speed for entering stations overrode the max speed of curves
2008-01-01 14:15:28 +00:00
a967a7287f
(svn r11732) -Fix (r4150): elrail merge gave elrail, monorail & maglev unintended speed bonuses for curves, as the bonus was based on the railtype index. The bonus is now specified by a property of the railtype.
2008-01-01 14:00:31 +00:00
7031358cff
(svn r11731) -Fix [FS#1582]: Clear sprite override data before performing NewGRF wagon attach callback. This stopped
...
the callback working for autoreplace and when moving wagons from train to train in a depot.
-Fix (r11724): Don't check wagon attach callback for the chain when moving a single wagon.
2007-12-31 21:51:16 +00:00
1a70eed58c
(svn r11724) -Fix: make it impossible (for users) to circumvent the length checking of the NewGRF 'allow wagon attach' callback by moving several wagons at a time.
2007-12-30 21:35:48 +00:00
e5e75bd8f8
(svn r11719) -Codechange: split sound.h in a header with types and one with functions.
2007-12-29 09:24:26 +00:00
38f0e422ac
(svn r11707) -Fix: do not allow refitting flooded (destroyed) vehicles
2007-12-27 14:10:47 +00:00
384503e7d3
(svn r11706) -Codechange: split vehicle.h and remove another bunch of useless includes.
2007-12-27 13:35:39 +00:00
4e66f5a04b
(svn r11705) -Fix [FS#1557]: trains could have sprites with wrong direction when reversing, also was inconsistent with save/load process (possible desyncs)
2007-12-27 13:25:23 +00:00
b9046c97fb
(svn r11702) -Codechange: move all date related stuff to date*.
2007-12-26 13:50:40 +00:00
2786d789a1
(svn r11701) -Codechange: removal unnecessary inclusions of map.h (and split map.h).
2007-12-26 11:45:43 +00:00
429521a7d1
(svn r11692) -Codechange: move some functions from 'functions.h' to a more logical place and remove about 50% of the includes of 'functions.h'
2007-12-25 11:26:07 +00:00
6a9e77e079
(svn r11680) -Codechange: refactor more out of openttd.h and functions.h.
2007-12-21 22:50:51 +00:00
9e9cfe6e59
(svn r11677) -Codechange: move price and command related types/functions to their respective places.
2007-12-21 21:50:46 +00:00
433a9f3c09
(svn r11675) -Codechange: split the string types from the string functions.
2007-12-21 19:49:27 +00:00
5b49e75453
(svn r11669) -Codechange: refactor tile.h -> tile_type.h and tile_map.h
2007-12-19 23:26:02 +00:00
f56a354d31
(svn r11661) -Codechange: some header reworks in order to try to reduce the compile time of OpenTTD by reduce the amount of circular-ish dependencies.
2007-12-18 19:52:14 +00:00
145517fb8e
(svn r11649) -Codechange: some code can be simplified thanks to changes in r11642
2007-12-16 19:30:42 +00:00
3cee0abdba
(svn r11644) -Codechange: merge some functions from tunnel_map.h and bridge_map.h into tunnelbridge_map.h
2007-12-16 15:38:51 +00:00
acf6e08f78
(svn r11642) -Codechange: VehicleFromPos does check for v->tile == tile, so remove useless checks
2007-12-15 23:11:18 +00:00
5992187a85
(svn r11634) -Fix: update signals when deleting crashed train on a bridge, update even when train is rotated
2007-12-15 00:04:01 +00:00
4b7f8f04a3
(svn r11633) -Codechange: merge CheckTunnelEmpty and IsVehicleOnBridge into GetVehicleTunnelBridge
2007-12-14 23:21:20 +00:00
ed54703db8
(svn r11623) -Fix [FS#1533] (r11619): assert when train is going over two crossings next to each other
2007-12-11 22:50:13 +00:00
359c9aea3f
(svn r11619) -Fix [FS#1531]: do not make crossing red behind depot the train is entering
2007-12-11 19:09:36 +00:00
0f43982c72
(svn r11567) -Fix [FS#1512] (r11011): break the chain before moving a vehicle after another in the same chain
2007-12-04 15:32:54 +00:00
bdc7fd2d76
(svn r11523) -Codechange: Move the CHANCE macros to core/random_func.cpp cause they depend on Random()
...
-Codechange: Convert the CHANCE macros to functions and rename them fitting to the naming style
2007-11-25 15:35:25 +00:00
a91c2a4c39
(svn r11485) -Codechange: Remove the doubled function ToggleBitT and rename the remaining to fit with the naming style
2007-11-20 14:11:19 +00:00
eeaa348f8b
(svn r11484) -Codechange: Remove the doubled function SetBitT and rename the remaining to fit with the naming style
2007-11-20 13:35:54 +00:00
5c31a973a1
(svn r11482) -Codechange: Remove the doubled function ClrBitT and rename the remaining to fit with the naming style
2007-11-19 21:32:20 +00:00
71c4325c50
(svn r11481) -Codechange: Rename the HASBIT function to fit with the naming style
2007-11-19 21:02:30 +00:00
50bfe1a19d
(svn r11476) -Codechange: rename the function myabs to abs to get rid of an unneeded define
2007-11-19 18:58:04 +00:00
8be526e499
(svn r11475) -Codechange: rename clamp and clampu to Clamp and ClampU to fit with the coding style
2007-11-19 18:38:10 +00:00
f28723830f
(svn r11431) -Codechange: [NewGRF] Add support for changing rail vehicle user-defined bit mask (prop 25) via callback 36
2007-11-15 00:13:12 +00:00
4b8aaa994c
(svn r11383) -Codechange: fixed all the mess around KillFirstBit (tnx to Rubidium and skidd13)
2007-11-04 23:06:39 +00:00
4041d8108a
(svn r11352) -Codechange: cache callback 2D result (vehicle color mapping) instead calling it every time the vehicle is drawn
2007-10-28 15:40:18 +00:00
68a1fbd437
(svn r11333) -Fix: Train engines still had a value of 0.
2007-10-21 16:52:01 +00:00
4bb210614b
(svn r11332) -Fix: vehicles getting a value of 0 on construction.
...
-Fix: assertion when selling vehicles.
2007-10-21 16:45:00 +00:00
cbfe23108c
(svn r11230) -Fix [FS#1228]: one could construct trains out of crashed wagons and engines. Based on a patch by SmatZ.
2007-10-08 20:16:25 +00:00
b6c9bc80cf
(svn r11229) -Fix [FS#1307]: one could sell vehicles that were crashed in a depot, which would still yield money.
2007-10-08 20:06:37 +00:00
127c7c9b0f
(svn r11173) -Codechange: rename some callback enums so they are more uniform.
2007-09-26 17:33:32 +00:00
a6a8502ca3
(svn r11134) -Fix [FS#1238]: vehicles got removed twice from the group list when selling whole trains.
2007-09-21 17:56:55 +00:00
257fdb38e6
(svn r11122) -Fix [FS#1234]: crash when building a NewGRF vehicle when the articulated build vehicle callback returneed a different value for the purchase window than the normal build. Thanks for Dalestan and _minime_ for pointers to possible causes.
2007-09-17 04:23:03 +00:00
9da9e77641
(svn r11120) -Codechange: remove the arbitrary limit of 10 articulated parts for a vehicle.
2007-09-16 20:48:00 +00:00
74d0bf52b2
(svn r11086) -Fix/Revert (r11053, r10984): "fixing" r11053 made the acceleration code use the wrong speed, which can be fixed by reverting a small piece of r10984.
2007-09-10 17:13:37 +00:00
38ff181ebf
(svn r11072) -Fix [FS#1045]: when a vehicle had a service order, the goto-depot button did not make it possible to stop the vehicle at that depot.
2007-09-09 17:42:59 +00:00
91a49cee55
(svn r11059) -Fix [FS#1182]: inconsistency between Rail<->ElRail conversions of different kinds of rail containing tiles (normal rail, stations, depots, etc). Patch by SmatZ.
2007-09-08 09:52:02 +00:00
15ea3be986
(svn r11048) -Fix [FS#1206]: several cases where (re)moving eninges on a train would corrupt the vehicle counts for the groups.
2007-09-05 21:05:12 +00:00
7cdf6d1cbe
(svn r11045) -Codechange: added a function to tell if a vehicle is the rear part of a dualheaded train engine
2007-09-05 10:15:23 +00:00
2c8e50f20c
(svn r11017) -Codechange: unify determining whether a vehicle needs/can be service a little more.
2007-08-31 17:13:39 +00:00
aba867d78d
(svn r11011) -Fix [FS#1129]: GetFirstVehicleInChain did change the game state while being marked const.
...
-Codechange: do not brute force determine the first vehicle in the chain or previous vehicle, but do it by properly accounting the previous and first pointers when updating the next pointer. This gives a performance increase of about 15% when there are a lot of vehicles in the game.
2007-08-30 21:11:12 +00:00
9b65bc430c
(svn r11004) -Codechange: some reworks of the saveload mechanism to be able to save and load private and protected variables in the vehicle struct.
2007-08-30 13:09:44 +00:00
cb7eaff353
(svn r11003) -Codechange: replace Vehicle->next to Vehicle->Next() and Vehicle->SetNext() so we can trap instances that change a next pointer and (in the future) update the first/previous pointers based on that.
2007-08-30 13:03:56 +00:00
3f3b013b99
(svn r10999) -Codechange: unify the way the running cost of a vehicle is determined. Patch by nycom.
2007-08-29 21:27:16 +00:00
5d628e6135
(svn r10997) -Codechange: unify the vehicle view window. Patch by PhilSophus.
2007-08-29 20:50:58 +00:00
a5b32d8d72
(svn r10984) -Codechange: unify the way one can get the current speed in the same forwat so we can display it.
2007-08-26 20:43:22 +00:00
a83ccad6bd
(svn r10983) -Codechange: use vehstatus & VS_CRASHED instead of some other "methods" custom to each vehicle to determine whether the vehicle is crashed.
2007-08-26 20:16:02 +00:00
a973c893fb
(svn r10823) -Fix r8610 [FS#1097]: the autoreplace window vehicle count didn't always update correctly) (Matthias)
2007-08-07 23:07:10 +00:00
836105864c
(svn r10770) -Codechange: use the pool item class as super class for the vehicle struct.
...
-Codechange: do not force "special" vehicles to be allocated in the low 1024 vehicle slots and non "special" vehicles in the rest of the slots.
2007-08-03 19:36:00 +00:00
92061aba4e
(svn r10734) -Fix [FS#1030]: Revert r10513) and add special cases for collision detection on bridges/tunnels.
2007-07-30 08:49:41 +00:00
5bd241eb5b
(svn r10697) -Codechange: give a more sensible names to some of the unkX variables.
2007-07-26 15:37:19 +00:00
efc7fdf2fd
(svn r10587) -Codechange: move the string/dparam related stuff from variables.h to strings.h
2007-07-16 09:16:58 +00:00
b876be0064
(svn r10493) -Codechange: update some callback ID enums to reflect their changed usage, add a few and update the comments.
2007-07-09 19:38:12 +00:00
7ba2e75f3e
(svn r10474) -Fix [FS#995]: wrong group count after train crash.
2007-07-08 09:29:28 +00:00
90f85c957a
(svn r10409) -Codechange: replace (Aircraft|RoadVeh|Ship|Train)_Tick with a Tick method in the Vehicle class.
2007-07-01 19:24:54 +00:00
83a880c882
(svn r10408) -Codechange: make GetImage a class method of Vehicle instead of Get(Aircraft|RoadVeh|Ship|Train)Image.
2007-07-01 19:11:47 +00:00
3a82c1e9ea
(svn r10381) -Fix [FS#951]: skipping an order made train reverse immediatelly. Patch by boekabart.
2007-06-28 22:03:34 +00:00
de357c74c1
(svn r10363) -Fix [FS#911]: invalidating autoreplace windows didn't take account of vehicle group (Matthias Wolf)
2007-06-27 20:40:20 +00:00
a6da8c9519
(svn r10344) -Fix (r10317): confusion between TRACK_n and TRACK_BIT_n stopped NW/SE slopes being picked up, and compare middle of tile against current z, not previous.
2007-06-26 20:03:17 +00:00
fb284a9264
(svn r10335) -Fix (r10331): Increment the current order index *after* using it in UpdateVehicleTimetable.
2007-06-25 23:14:13 +00:00
9c0ccadbe0
(svn r10317) -Fix [FS#786]: acceleration not calculated properly when a train goes up a hill between tunnels.
2007-06-25 08:24:03 +00:00
34723257f0
(svn r10288) -Fix [FS#202]: also age engines that aren't front-engines (based on a patch by kaan)
2007-06-22 22:42:18 +00:00
117368a5a9
(svn r10287) -Fix (r10266): some surprises from that (almost always) complaining compiler...
2007-06-22 22:28:15 +00:00
e5c352818d
(svn r10266) -Codechange: keep track of the origin, time of travel and accumulated feeder share (transfers) of individual pieces of cargo. This means that cargo isn't thrown on a big pile when it's put in a station or unloaded at a station, however the GUI does not reflect these changes yet so you will not actually see it.
2007-06-22 11:58:59 +00:00
9c0944aa09
(svn r10258) -Codechange: as we are now using int64 all over the place, it's better to use int64 variables in the string generating too instead of packing them into two int32s.
...
-Fix: some displays of money were wrong.
2007-06-21 17:25:17 +00:00
eb1472a82d
(svn r10247) -Fix (r10210): *always* call SetDParamMoney when you want to place money in some string.
2007-06-21 14:54:51 +00:00
f806b46cc9
(svn r10246) -Fix (r10297): some forgotten money conversions and truncation issues. Thanks to benc for providing the patch.
2007-06-21 14:32:27 +00:00
cf0118ee63
(svn r10236) -Feature: Introduce a form of timetabling for vehicles.
2007-06-20 19:17:22 +00:00
e7191fc57a
(svn r10222) -Fix [FS#892]: Only 2 trains could crash at one time as collision checking stopped on the first hit. This could cause desyncs in network games as the collision hash order is not guaranteed. (patch by B. N. Smatz)
2007-06-19 16:40:59 +00:00
2ee73b50b8
(svn r10208) -Codechange: replace int32 with Money where appropriate.
2007-06-18 21:44:47 +00:00
49220cc6f1
(svn r10205) -Codechange: refactor returning of cost, so it can be more easily modified.
2007-06-18 19:53:50 +00:00
966e2738b9
(svn r10197) -Codechange: replace int32 with CommandCost where appropriate.
2007-06-18 10:48:15 +00:00
94bd08fc17
(svn r10177) -Fix: Passengers has one A and two Es (ln)
2007-06-17 10:47:30 +00:00
78d797a6b7
(svn r10111) -Codechange: Add new vehicle hash table for collision detection and finding vehicles on a tile. The hash area scanned is far smaller than the old hash table, which is now used for viewport updates only. This should give a significant performance improvement for games with many vehicles. (Based on work by 'B. N. SmatZ!' and 'madman2003')
2007-06-12 11:22:32 +00:00
3e326085fa
(svn r10097) -Feature: Add support for articulated road vehicles, or callbacks 11 and 17 for
...
road vehicles for those who prefer the technical explanation.
2007-06-11 14:00:16 +00:00
43482d22d0
(svn r10028) -Fix (r2270/r2951): When deleting the first engine of a train with multiple engines, only reopen the train window if the player had the original train window open. This fixes 'random' windows opening for multiple players of the same company.
2007-06-02 20:08:23 +00:00
e129438139
(svn r10026) -Fix: unlinking a rail vehicle didn't clear the first pointer
...
After r9973, this could cause some asserts as some vehicles could end up with first pointers to chains they didn't belong to
2007-06-02 17:23:31 +00:00
229e311cb9
(svn r10023) -Fix (r3218): When selling trains, if there were no wagons between multiheaded
...
engines the rear part could be checked despite having already been deleted,
triggering an assert.
2007-06-02 14:42:25 +00:00
1e7b8190f2
(svn r10022) -Fix (r10007): Set the type of multiheaded trains before the subtype.
2007-06-02 11:15:38 +00:00
ab8503f5a5
(svn r10008) -Codechange: Move a couple of functions related to articulated vehicles to a file of their own.
2007-06-01 11:41:02 +00:00
dce1101039
(svn r10007) -Codechange: Add some asserts to IsFrontEngine and friends to ensure that only trains use them.
2007-06-01 11:17:30 +00:00
bc41dc4966
(svn r9987) -Fix [FS#818]: a train under a bridge could collide with a train on the bridge.
2007-05-30 13:27:56 +00:00
77f5c1e25e
(svn r9973) -Cleanup: removed some code that kept both ends of a dualheaded engine in the same train (when moving wagons in a depot)
...
NormaliseTrainConsist() is called later in the same command and it will take care of this issue
2007-05-29 10:35:52 +00:00
a6bea527a3
(svn r9967) -Fix (r9938): autoreplace would in certain conditions move dualheaded engines in a train (usually to the rear)
...
-Change: moving an engine in between the two ends of a dualheaded engine will now move the rear dualheaded engine to the front of the newly added engine (instead of moving the new engine to the rear of the rear dualheaded engine)
This can make a difference if there are wagons in the train
2007-05-28 21:40:40 +00:00
440d723d84
(svn r9914) -Codechange: prepare GTTS and the pathfinders to handle multiple road types on a single tile.
2007-05-24 22:41:50 +00:00
60a2c5280e
(svn r9875) -Fix (r9828): Only set carriage capacity if the wagon has not been refitted.
2007-05-19 10:29:51 +00:00
7d4be11516
(svn r9874) -Feature: advanced vehicle lists a.k.a. group interface. Now you can make groups of vehicles and perform all kinds of tasks on that given group. Original code by nycom and graphics by skidd13.
2007-05-19 09:40:18 +00:00
1d5135830a
(svn r9828) -Codechange: [NewGRF] Add support for changing cargo capacity with callback 36. This is set on construction for ships and roadvehicles, and whenever carriages are attached for trains.
2007-05-12 07:05:34 +00:00
dc2073b96e
(svn r9818) -Codechange: Cache wagon override sprite set whenever consist is changed, instead of 'recalculating' it every time it is used or just tested.
2007-05-10 06:42:43 +00:00
2efecd34c4
(svn r9808) -Codechange: unify the Handle<VehicleType>Loading functions.
2007-05-07 16:21:34 +00:00
161786e222
(svn r9807) -Codechange: unify playing of sound when vehicle has been loaded and leaves the station.
2007-05-07 15:58:05 +00:00
4591fb5b0d
(svn r9806) -Codechange: [NewGRF] Add callback 36 support for purchase cost, for all vehicle types.
2007-05-07 13:26:10 +00:00
feadd86819
(svn r9802) -Fix: a vehicle without visual effects isn't per definition unpowered (mart3p).
2007-05-06 20:00:36 +00:00
411985b13a
(svn r9801) -Fix: do not assume that trains running on monorail/maglev cannot smoke/spark (mart3p).
2007-05-06 19:58:34 +00:00
208e40a839
(svn r9800) -Codechange: play sound effects based on the engine class, not the rail type (mart3p).
2007-05-06 19:51:25 +00:00
abbaa1691e
(svn r9794) -Codechange: refactor the question whether a vehicle can be loaded into LoadUnloadVehicle instead of duplicating it for each vehicle.
2007-05-06 14:59:01 +00:00
b76cc8c96b
(svn r9784) -Codechange: remove unused variable.
2007-05-04 22:38:36 +00:00
e81906c62d
(svn r9780) -Codechange: [NewGRF] Add support for variable vehicle weight for trains (callback 36, property 16)
2007-05-04 19:24:01 +00:00
981bf52bdd
(svn r9770) -Codechange: perform the payment of cargo when loading/unloading, but when arriving at the station.
2007-05-02 18:29:11 +00:00
a4e045a3fb
(svn r9760) -Codechange: remove the need for saving some vehicle variables.
2007-05-01 16:35:14 +00:00
cbd9a1bf0d
(svn r9756) -Fix [FS#755]: LeaveStation wasn't always called when a station was left.
2007-04-29 22:51:12 +00:00
ec9ac99d01
(svn r9755) -Codechange: refactor some more of the begin loading stuff.
2007-04-29 22:33:51 +00:00
202009522c
(svn r9754) -Codechange: make classes for all vehicle types, so we can make nicer/better maintainable code, i.e. virtual methods instead of switches.
2007-04-29 21:24:08 +00:00
6440440f12
(svn r9752) -Codechange: remove some duplication related to BeginLoading.
2007-04-29 18:21:24 +00:00
02e770ff2c
(svn r9742) -Fix (r9689) [FS#739]: Fix cloning with refit costs again, hopefully for good this time.
2007-04-29 08:43:00 +00:00
034f3591cf
(svn r9685) -Fix (r9683): Call v->LeaveStation() when a vehicle in a station is sent to a depot.
2007-04-20 11:39:01 +00:00
80c259f64f
(svn r9672) -Cleanup: lots of coding style fixes around operands.
2007-04-18 22:10:36 +00:00
41cf2fa69b
(svn r9671) -Codechange: Implement NewGRF callback 36, which allows changing of various properties which were previously static. Vehicle max speed and train power/te/running costs are adjustable.
2007-04-18 18:37:40 +00:00
d6651c1741
(svn r9665) -Documentation: Doxygen corrections,errors, corrections of corrections...
2007-04-18 00:41:09 +00:00
ccaaa7d33a
(svn r9609) -Codechange: Move some function prototypes out of functions.h and into landscape.h, and add a few where they didn't exist.
2007-04-12 13:07:15 +00:00
f81217bcf4
(svn r9558) -Documentation: doxygen and comment changes: 'T' now. Almost done
2007-04-04 03:21:14 +00:00
eae03e0f72
(svn r9543) -Fix [FS#691]: Split up STR_ENGINE_NOT_BUILDABLE into four strings so it can be
...
translated properly and remove "buildable", since it isn't actually a word.
2007-04-02 11:35:08 +00:00
06d3669bb5
(svn r9400) -Codechange: Use some more representative enum names for landscape types.
2007-03-22 03:42:43 +00:00
457930c483
(svn r9322) -Codechange: Use cargo class to count crash/flood victims
2007-03-19 12:40:51 +00:00
84d9f832c3
(svn r9277) -Fix [FS#685]: shared orders got messed up when the 'first' trains got removed in the depot.
2007-03-18 15:32:42 +00:00
92486ac980
(svn r9259) -Codechange: NUM_CARGO isn't a valid cargo type...
2007-03-16 21:42:11 +00:00
c7bcdb69b1
(svn r9146) -Fix [NTP][FS#676](r6800): "Train is lost" message is generated incorrectly. Forgot to set the best bird distance to zero in case we found the destination to indicate success. (de_zeurkous)
2007-03-13 21:04:22 +00:00
c2b7d0192d
(svn r9072) -Codechange: [Orders] added methods to orders to free them and check if they are in use
2007-03-08 21:39:34 +00:00
ce919e8c71
(svn r9068) -Codechange: capitalize the VEH_Train etc. enums to match the coding style (and rest of the code).
2007-03-08 16:27:54 +00:00
24c4d5b06d
(svn r9051) -Codechange: typedef [enum|struct] Y {} X; -> [enum|struct] X {};
2007-03-07 12:11:48 +00:00
36bb92ae24
(svn r9050) -Codechange: Foo(void) -> Foo()
2007-03-07 11:47:46 +00:00
469fbc912c
(svn r8946) -Feature: [NewGRF] Add support for vehicle variables 0xFE and 0xFF bit 10,
...
which is set when a vehicle was built during the exclusive testing phase.
2007-02-28 17:59:05 +00:00
aadd8a4b44
(svn r8945) -Codechange: Rename v->load_status to v->vehicle_flags so it can be used for more than just the gradual loading status.
2007-02-28 17:18:36 +00:00
4908115355
(svn r8935) -Codechange: unification of track type between road and rail tiles, unification of ground type between normal rail tiles and depots/waypoints and removing the need for RailTileSubType.
2007-02-27 23:36:28 +00:00
311af1a956
(svn r8900) -Fix
...
Get rid of DECLARE_ENUM_AS_BIT_INDEX(Track, TrackBits)
2007-02-25 11:49:43 +00:00
3ce4baa9fc
(svn r8899) -Fix
...
Remove the unused second parameter from GetTileRailType()
2007-02-25 11:36:19 +00:00
1ce43c1a37
(svn r8897) -Fix
...
Change the signature of GetNewVehiclePos():
-void GetNewVehiclePos(const Vehicle *v, GetNewVehiclePosResult *gp);
+GetNewVehiclePosResult GetNewVehiclePos(const Vehicle *v);
2007-02-25 10:49:13 +00:00
696b895b77
(svn r8896) -Fix
...
Most (i.e. 13 of 15) callers of GetNewVehiclePos() do not care for the return and the others can figure it out by inspecting the information returned in struct GetNewVehiclePosResult.
Therefore remove the return value.
2007-02-25 10:25:25 +00:00
1864d28cb8
(svn r8894) -Fix
...
Slightly simplify the control flow of TrainController()
2007-02-25 09:47:46 +00:00
e949a956bd
(svn r8893) -Fix
...
variable scope, const, misc.
2007-02-25 09:27:03 +00:00
12b1804d4e
(svn r8884) -Fix
...
Replace SetSpeedLimitOnBridge() by something simpler
2007-02-24 18:44:30 +00:00
caa129958d
(svn r8878) -Fix
...
-Fix: Do a better job when checking the parameters of CmdMoveRailVehicle()
NOTE: 0.5 candidate
2007-02-24 14:36:14 +00:00
89613b6cc4
(svn r8850) -Codechange: Use the cargo type's is_freight flag instead of checking the cargo type to determine if the cargo type is freight cargo type cargo type.
2007-02-22 22:53:49 +00:00
ef2daa5060
(svn r8826) -Codechange: Replace _cargoc's separate arrays with a regular struct array (with accessor) and implement new initialization method using cargo labels.
2007-02-20 22:09:21 +00:00
d9385f2798
(svn r8709) -Fix/Codechange: Rename the function GetStationPlatforms into GetPlatformLength because that is what it really does. Overload it because there is already a GetPlatformLength (one gives the length of the whole platform, the other gives the remaining length in a given direction). Turned both functions into methods of Station. While messing around with it, fix a problem where loading times for overhanging trains are miscomputed.
2007-02-13 16:36:38 +00:00
d1d1d170f3
(svn r8703) -Codechange/cleanup: some magic numbers -> enums and other small coding style changes to the ShipController and TrainController.
2007-02-13 11:29:20 +00:00
4ec7eb2201
(svn r8701) -Codechange: replace magic numbers with enums for u.rail.track.
2007-02-13 10:46:45 +00:00
af3001b988
(svn r8700) -Fix (8698): replaced a magic number with the wrong enum :(
2007-02-13 10:43:50 +00:00
a419f4aeda
(svn r8698) -Codechange: enumify the returns of VehicleEnterTile
2007-02-13 10:26:53 +00:00
80125fd934
(svn r8610) -Codechange/Feature: rewrote the list handling in the autoreplace window
...
-The user will notice the following changes:
All vehicle types behaves in the same way
Adding/removing an engine (new design and so on) can no longer result in the window selecting a new engine
All valid replacements will be displayed since it looks at refitting options as well (this solves the missing ships with the newships GRF)
Since you can't replace an engine into itself, the engine selected in the left list will no longer appear in the right list
-The code changes:
Instead of looping all engines all the time, each list generates a list like the build windows
This ensures consistent list generation since only one function can loop all engines
Unified code for all vehicle types
It now use the lists to call the drawing code in the build vehicle window
Works on selected EngineIDs instead of selected index in the list
2007-02-06 11:11:12 +00:00
c326ff3795
(svn r8550) -Fix
...
Building a vehicle does not involve allocating orders, so do not check whether orders could be allocated
2007-02-03 09:05:43 +00:00
smatz